From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 84333 invoked by alias); 13 Jul 2018 15:10:30 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 84323 invoked by uid 89); 13 Jul 2018 15:10:29 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-qk0-f194.google.com Received: from mail-qk0-f194.google.com (HELO mail-qk0-f194.google.com) (209.85.220.194) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 13 Jul 2018 15:10:28 +0000 Received: by mail-qk0-f194.google.com with SMTP id b66-v6so17329555qkj.1 for ; Fri, 13 Jul 2018 08:10:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=mY9gZEA339j5NdE0A03uW17RKH3cYovADPejjaFw03E=; b=FhYSBP3bmVa0c5p5flMxXQNPWO/dW7ggjqZ1H6+GGNHImd2p0ULApo4sgiPObuBcGC byOV+pw9DmlUa2x9OG7eQE5sc2syP9hamBxis/Q6JLaV8Lc7xHpQu3laqh89JnitSrwO 1RaB/BX2xNAtuMMAyOLRikl817AvSbqeXj75LhYxZfHGtFgwhKIBf0GfVM/ZvymLvseU rQQCailWXascAVl/jaV6rlNrLA3ZnZHKg/y47eQgtHj6WfeAG7cNeULm9kC3xqSajyfo ootOeKPwCJ79I7E09Nih1COTNmKm+gsCUVCecnJgwEGVhzcVt2C5E4VVQhQ1xRsHhlmE Aq8A== Return-Path: Received: from localhost.localdomain (184-96-226-101.hlrn.qwest.net. [184.96.226.101]) by smtp.gmail.com with ESMTPSA id 3-v6sm21337975qts.31.2018.07.13.08.10.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 13 Jul 2018 08:10:24 -0700 (PDT) Subject: Re: [PATCH] reject conflicting attributes before calling handlers (PR 86453) To: Christophe Lyon References: <4c30a386-0be0-f796-a651-757d86ee16b4@gmail.com> Cc: Richard Biener , gcc Patches From: Martin Sebor Message-ID: <59d49ddf-0d8f-5b6e-58e2-5d37acb7e83c@gmail.com> Date: Fri, 13 Jul 2018 15:10:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-07/txt/msg00700.txt.bz2 On 07/13/2018 02:53 AM, Christophe Lyon wrote: > Hi, > > On Thu, 12 Jul 2018 at 00:04, Martin Sebor wrote: >> >> The attached change set adjusts the attribute exclusion code >> to detect and reject incompatible attributes before attribute >> handlers are called to have a chance to make changes despite >> the exclusions. The handlers are not run when a conflict is >> found. >> >> Tested on x86_64-linux. I expected the fallout to be bigger >> but only a handful of tests needed adjusting and the changes >> all look like clear improvements. I.e., conflicting attributes >> that diagnosed as being ignored really are being ignored as one >> would expect. >> > > Since you committed this patch (r262596), I've noticed regressions on > aarch64/arm: > g++.dg/warn/pr86453.C -std=c++11 (test for warnings, line 4) > g++.dg/warn/pr86453.C -std=c++11 (test for excess errors) > g++.dg/warn/pr86453.C -std=c++14 (test for warnings, line 4) > g++.dg/warn/pr86453.C -std=c++14 (test for excess errors) > g++.dg/warn/pr86453.C -std=c++98 (test for warnings, line 4) > g++.dg/warn/pr86453.C -std=c++98 (test for excess errors) > > The log says: > Excess errors: > /gcc/testsuite/g++.dg/warn/pr86453.C:4:44: warning: ignoring attribute > 'packed' because it conflicts with attribute 'aligned' [-Wattributes] > > Isn't there the same message on x86_64? There was. The test above was added between the time I tested my patch and the time I committed it. I adjusted it yesterday via r262609 so the failure should be gone. Martin