From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id E7F2F385782C for ; Tue, 28 Nov 2023 17:18:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E7F2F385782C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E7F2F385782C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701191901; cv=none; b=u5ip7ZJmAGO/i43J+I0sZ97AdN1xwJEG4dSdgLMDVNRoRLDpZ3m/g9SfZlTIq1wA8vSoWT/scXvHscaEnpWJf7AQrxN4xsL30yPt+Orll/XvuRFOZruHPoLWwNifjUV8dyl4juOuYZIE+Mw6bkAVAavYIQTXmS1iNtGJlAU9RtA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701191901; c=relaxed/simple; bh=NfRdssedb+wKIQlEKOwwttHxPo2Zx4aFCzeUIEZQpcw=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=NjDZZHVgGUnrK/aGphxEknvvXdPKAf4/8SLV+PQsi7w1htBJj029tdYI53yvLWA8vXmxhKcGt9XF3imaDB+Zt4pO3cKWPDrsUWzOzKiqd2ZfBjGBxCgGkJ/CSkG1BX0NA3qibsWJnqEhLNUwX8xGrEhm7Uw53nlLcg2D8N+bYq4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701191899; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TGJAmBQ83bBscr/pOAFE3B/6VFhAlgVaWuLu6/JAt44=; b=J+FQhsgyZqb2eU7CpHYxBBWEqYC5YTskpsyBsaN90bcUdu6fTXOsprWgp+Xi40G+JfOPRL lSF2t9sfFoHHmehFMl2WY5f1HlfA7p2A9xYjV9UABM1jAxvJmUDbiaU9YMnLl4oekkWOpK bJRfOCfLFoQGqtZ3HBiRr2sMA5N7V5c= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-562-PuUJS0PxOWKotEYvzDC0Lw-1; Tue, 28 Nov 2023 12:18:18 -0500 X-MC-Unique: PuUJS0PxOWKotEYvzDC0Lw-1 Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-77d8b1e25d9so722555085a.1 for ; Tue, 28 Nov 2023 09:18:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701191897; x=1701796697; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TGJAmBQ83bBscr/pOAFE3B/6VFhAlgVaWuLu6/JAt44=; b=H24yHdTNxb98y/YL8Cyi43skrY34P1nygJcdQaG4OV/NFPHdaHjF1TyVEU7D5h3UFb zqGd5fzFZMa0nBUhnhed8KEXJWe/mqhupq3rbCoUtecXC7cfM6ZUw0iD9eL3jdxaxGqO k0VgT/1plfEPfljphAHEGu1lpBUVDDlqHo84EiIMagaECi+DVgOHlQPMKleHSCiNYtG5 rvbRwxVV3++WyjeLW97yvr4vzM4TOYrQn1/+++p9iiQ+c5lEqs3FtSihwA+LAcBH3f9Y eBJYxmKq6wJnTb+TADbGpudzQoLVXyBE9fEwxu+xQCSwux4WXK9OY60BzU05I+QaQMlj yrGQ== X-Gm-Message-State: AOJu0YxarkPwuAq7ZpyUuVMKCvpw0/fZ63xCYaYF3TKA0pv4L0f5dQTZ Y0XOq6T+56FsOVCI2xJ3DVQ0JutpMzNkShNTiJLk86qdMmTuHPVsCCBumFTcix5M11LDb4HCa7K YSG06Ag60JjiJOPdqRUdfxEvQVA== X-Received: by 2002:a05:620a:1a02:b0:77d:855a:b58d with SMTP id bk2-20020a05620a1a0200b0077d855ab58dmr22722849qkb.1.1701191897148; Tue, 28 Nov 2023 09:18:17 -0800 (PST) X-Google-Smtp-Source: AGHT+IGt2QYyG9acvXEehhuPtE9NW60V514XKyLdmz7oorlAHDNlMoQzjLdbKHRwHldnNsZvmSA5Fg== X-Received: by 2002:a05:620a:1a02:b0:77d:855a:b58d with SMTP id bk2-20020a05620a1a0200b0077d855ab58dmr22722814qkb.1.1701191896876; Tue, 28 Nov 2023 09:18:16 -0800 (PST) Received: from [192.168.1.145] (130-44-146-16.s12558.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.146.16]) by smtp.gmail.com with ESMTPSA id c4-20020a05620a200400b0077a02b8b504sm4590547qka.52.2023.11.28.09.18.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Nov 2023 09:18:16 -0800 (PST) Message-ID: <59dbc6a2-6cb8-4287-bc61-c3b9fab0b791@redhat.com> Date: Tue, 28 Nov 2023 12:18:15 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] c++: Fix up __has_extension (cxx_init_captures) To: Jakub Jelinek , Alex Coplan Cc: gcc-patches@gcc.gnu.org References: <54f7dafb-e8cf-4282-a042-a4abcba6494f@redhat.com> From: Jason Merrill In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/28/23 12:12, Jakub Jelinek wrote: > On Tue, Nov 28, 2023 at 04:45:41PM +0000, Alex Coplan wrote: >>> --- gcc/cp/cp-objcp-common.cc.jj 2023-11-27 17:34:25.000000000 +0100 >>> +++ gcc/cp/cp-objcp-common.cc 2023-11-28 08:55:18.868419864 +0100 >>> @@ -145,7 +145,7 @@ static constexpr cp_feature_info cp_feat >>> { "cxx_contextual_conversions", { cxx14, cxx98 } }, >>> { "cxx_decltype_auto", cxx14 }, >>> { "cxx_aggregate_nsdmi", cxx14 }, >>> - { "cxx_init_captures", cxx14 }, >>> + { "cxx_init_captures", { cxx14, cxx11 } }, >> >> FWIW it looks like this is what I had in the original RFC here: >> >> https://gcc.gnu.org/pipermail/gcc-patches/2023-May/617878.html >> >> but Jason suggested we be more conservative about what we advertise as >> extensions in his review here: >> >> https://gcc.gnu.org/pipermail/gcc-patches/2023-May/618232.html > > Wasn't that suggestion mostly about C++98 though? It was mostly about defaulting to being conservative. But init-captures in C++11 shouldn't cause any trouble. > Jason, shall I commit the patch as approved, or shall Alex tweak the > testcase instead? Go ahead with your patch. Jason