From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 47790 invoked by alias); 27 Jul 2018 15:07:27 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 47781 invoked by uid 89); 27 Jul 2018 15:07:27 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=AltiVec, vec_vaddcuq, Nilsen, nilsen X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0a-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.156.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 27 Jul 2018 15:07:26 +0000 Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w6RF4UhI031938 for ; Fri, 27 Jul 2018 11:07:24 -0400 Received: from e13.ny.us.ibm.com (e13.ny.us.ibm.com [129.33.205.203]) by mx0a-001b2d01.pphosted.com with ESMTP id 2kg317qsfv-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 27 Jul 2018 11:07:24 -0400 Received: from localhost by e13.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 27 Jul 2018 11:07:23 -0400 Received: from b01cxnp22036.gho.pok.ibm.com (9.57.198.26) by e13.ny.us.ibm.com (146.89.104.200) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Fri, 27 Jul 2018 11:07:21 -0400 Received: from b01ledav005.gho.pok.ibm.com (b01ledav005.gho.pok.ibm.com [9.57.199.110]) by b01cxnp22036.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w6RF7KF460686438 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 27 Jul 2018 15:07:20 GMT Received: from b01ledav005.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 289FAAE060; Fri, 27 Jul 2018 11:06:33 -0400 (EDT) Received: from b01ledav005.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0D123AE05F; Fri, 27 Jul 2018 11:06:33 -0400 (EDT) Received: from kelvins-mbp-2.rchland.ibm.com (unknown [9.10.86.22]) by b01ledav005.gho.pok.ibm.com (Postfix) with ESMTP; Fri, 27 Jul 2018 11:06:32 -0400 (EDT) Subject: Re: Fwd: [PATCH, rs6000] Replace __uint128_t and __int128_t with __uint128 and __int128 in Power PC built-in documentation To: Segher Boessenkool Cc: gcc-patches@gcc.gnu.org References: <84e63e5f-e4fe-b2fe-b944-bbab22bdf295@linux.ibm.com> <6def80ed-43ef-14c0-3482-129f44c1244e@linux.ibm.com> <20180726145420.GW16221@gate.crashing.org> From: Kelvin Nilsen Date: Fri, 27 Jul 2018 15:07:00 -0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180726145420.GW16221@gate.crashing.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit x-cbid: 18072715-0064-0000-0000-000003308B4B X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00009438; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000266; SDB=6.01066910; UDB=6.00548188; IPR=6.00844776; MB=3.00022354; MTD=3.00000008; XFM=3.00000015; UTC=2018-07-27 15:07:22 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18072715-0065-0000-0000-00003A171D45 Message-Id: <59f39fa2-64c4-3ce1-a091-6924c8489447@linux.ibm.com> X-SW-Source: 2018-07/txt/msg01733.txt.bz2 Thanks for review and approval. To respond to your question about error messages: > > microdoc3.c:22:3: error: invalid parameter combination for AltiVec intrinsic ‘__builtin_vec_vaddcuq’ > u1 = vec_vaddcuq (d2, d3); > ^~ On 7/26/18 9:54 AM, Segher Boessenkool wrote: > On Thu, Jul 26, 2018 at 08:40:01AM -0500, Kelvin Nilsen wrote: >> To improve internal consistency and to improve consistency with published ABI documents, this patch replaces the __uint128_t type with __uint128 and replaces __int128_t with __int128. > >> Is this ok for trunk? > > Looks good, thanks! Most (all?) of these functions are not documented > in the ABI, but this is a step forward anyway. Okay for trunk. > > What do things like error messages involving these functions look like? > What types do those say? > > > Segher > >