From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 1C2D83830FF8 for ; Wed, 14 Dec 2022 11:23:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1C2D83830FF8 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2BEBEFFE005648; Wed, 14 Dec 2022 11:23:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pp1; bh=L5T8HQdLU+FYi2PeCUG5bJyOokU6WgbuNQkxX614V5M=; b=j5zrcpT7Hh+O/pIgHWW6bRvoLZaU/5YAamEvAbwUdquDfTJNmhVdzxMjtJbVHX3mHDae xenBrnMzVX34p0Xeq7ds+HRp+NKqa7h7F+w63PANUQpl6hKpML32HhyQ3AsEcc4zMLU9 9g0ppdprkujp71mqvvBJnRRA8NsCQUXNqn9OMugWdk1g5sL2X2uDQSwG9NCSTkTxNBaf YA8+kpqvWBVOl3aj3B1SUXgD8ZijgnMBmLHpRUcGpNJv2+nc9we4gBd+ABqQoKNHOfNn gIRSllZocafH6n2dil1PEA6MWgYiKq3lD0sjRUoCiQaD+eVnXgS0UGI2Y+iD3fv9hV9L WQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3mfde8g73e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 14 Dec 2022 11:23:48 +0000 Received: from m0098419.ppops.net (m0098419.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 2BEBHghN020916; Wed, 14 Dec 2022 11:23:47 GMT Received: from ppma01fra.de.ibm.com (46.49.7a9f.ip4.static.sl-reverse.com [159.122.73.70]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3mfde8g72x-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 14 Dec 2022 11:23:47 +0000 Received: from pps.filterd (ppma01fra.de.ibm.com [127.0.0.1]) by ppma01fra.de.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 2BDJdnso013410; Wed, 14 Dec 2022 11:23:45 GMT Received: from smtprelay04.fra02v.mail.ibm.com ([9.218.2.228]) by ppma01fra.de.ibm.com (PPS) with ESMTPS id 3meyqxrswk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 14 Dec 2022 11:23:45 +0000 Received: from smtpav05.fra02v.mail.ibm.com (smtpav05.fra02v.mail.ibm.com [10.20.54.104]) by smtprelay04.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 2BEBNfoa22086298 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 14 Dec 2022 11:23:41 GMT Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id AB0FB2006A; Wed, 14 Dec 2022 11:23:41 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id BEFC02004D; Wed, 14 Dec 2022 11:23:39 +0000 (GMT) Received: from [9.197.253.236] (unknown [9.197.253.236]) by smtpav05.fra02v.mail.ibm.com (Postfix) with ESMTP; Wed, 14 Dec 2022 11:23:39 +0000 (GMT) Message-ID: <59fbb646-c855-c4cd-10f9-40996f4e9720@linux.ibm.com> Date: Wed, 14 Dec 2022 19:23:38 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: PING^1 [PATCH 0/9] rs6000: Rework rs6000_emit_vector_compare Content-Language: en-US To: gcc-patches@gcc.gnu.org Cc: segher@kernel.crashing.org, dje.gcc@gmail.com, bergner@linux.ibm.com, meissner@linux.ibm.com References: <20221124091557.514727-1-linkw@linux.ibm.com> From: "Kewen.Lin" In-Reply-To: <20221124091557.514727-1-linkw@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: C-fMIRMsj9r1wzyaI_eqSpwS-VgUednW X-Proofpoint-ORIG-GUID: 43awHY6tSlRCD-JLqQOz34mVo5UrlJW5 Content-Transfer-Encoding: 7bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-12-14_04,2022-12-14_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 impostorscore=0 bulkscore=0 suspectscore=0 phishscore=0 lowpriorityscore=0 mlxlogscore=999 priorityscore=1501 spamscore=0 mlxscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2212140087 X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi, Gentle ping this series: https://gcc.gnu.org/pipermail/gcc-patches/2022-November/607146.html BR, Kewen on 2022/11/24 17:15, Kewen Lin wrote: > Hi, > > Following Segher's suggestion, this patch series is to rework > function rs6000_emit_vector_compare for vector float and int > in multiple steps, it's based on the previous attempts [1][2]. > As mentioned in [1], the need to rework this for float is to > make a centralized place for vector float comparison handlings > instead of supporting with swapping ops and reversing code etc. > dispersedly. It's also for a subsequent patch to handle > comparison operators with or without trapping math (PR105480). > With the handling on vector float reworked, we can further make > the handling on vector int simplified as shown. > > For Segher's concern about whether this rework causes any > assembly change, I constructed two testcases for vector float[3] > and int[4] respectively before, it showed the most are fine > excepting for the difference on LE and UNGT, it's demonstrated > as improvement since it uses GE instead of GT ior EQ. The > associated test case in patch 3/9 is a good example. > > Besides, w/ and w/o the whole patch series, I built the whole > SPEC2017 at options -O3 and -Ofast separately, checked the > differences on object assembly. The result showed that the > most are unchanged, except for: > > * at -O3, 521.wrf_r has 9 object files and 526.blender_r has > 9 object files with differences. > > * at -Ofast, 521.wrf_r has 12 object files, 526.blender_r has > one and 527.cam4_r has 4 object files with differences. > > By looking into these differences, all significant differences > are caused by the known improvement mentined above transforming > GT ior EQ to GE, which can also affect unrolling decision due > to insn count. Some other trivial differences are branch > target offset difference, nop difference for alignment, vsx > register number differences etc. > > I also evaluated the runtime performance for these changed > benchmarks, the result is neutral. > > These patches are bootstrapped and regress-tested > incrementally on powerpc64-linux-gnu P7 & P8, and > powerpc64le-linux-gnu P9 & P10. > > Is it ok for trunk? > > BR, > Kewen > ----- > [1] https://gcc.gnu.org/pipermail/gcc-patches/2022-November/606375.html > [2] https://gcc.gnu.org/pipermail/gcc-patches/2022-November/606376.html > [3] https://gcc.gnu.org/pipermail/gcc-patches/2022-November/606504.html > [4] https://gcc.gnu.org/pipermail/gcc-patches/2022-November/606506.html > > Kewen Lin (9): > rs6000: Rework vector float comparison in rs6000_emit_vector_compare - p1 > rs6000: Rework vector float comparison in rs6000_emit_vector_compare - p2 > rs6000: Rework vector float comparison in rs6000_emit_vector_compare - p3 > rs6000: Rework vector float comparison in rs6000_emit_vector_compare - p4 > rs6000: Rework vector integer comparison in rs6000_emit_vector_compare - p1 > rs6000: Rework vector integer comparison in rs6000_emit_vector_compare - p2 > rs6000: Rework vector integer comparison in rs6000_emit_vector_compare - p3 > rs6000: Rework vector integer comparison in rs6000_emit_vector_compare - p4 > rs6000: Rework vector integer comparison in rs6000_emit_vector_compare - p5 > > gcc/config/rs6000/rs6000.cc | 180 ++++++-------------- > gcc/testsuite/gcc.target/powerpc/vcond-fp.c | 25 +++ > 2 files changed, 74 insertions(+), 131 deletions(-) > create mode 100644 gcc/testsuite/gcc.target/powerpc/vcond-fp.c >