[PATCH][ARM] Fix more -Wreturn-type fallout

[PATCH][ARM] Fix more -Wreturn-type fallout

[Sudi Das]

[-- Attachment #1: Type: text/plain, Size: 373 bytes --]


Hi

This patch fixes a couple of more tests that are giving out warnings with -Wreturn-type:
- g++.dg/ext/pr57735.C
- gcc.target/arm/pr54300.C

*** gcc/testsuite/ChangeLog ***

2017-11-10  Sudakshina Das  <sudi.das@arm.com>

	* g++.dg/ext/pr57735.C: Add -Wno-return-type for test.
	* gcc.target/arm/pr54300.C (main): Add return type and
	return a value.
    

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: rb8505.patch --]
[-- Type: text/x-patch; name="rb8505.patch", Size: 1276 bytes --]

diff --git a/gcc/testsuite/g++.dg/ext/pr57735.C b/gcc/testsuite/g++.dg/ext/pr57735.C
index a8f7d05712c9a823564d58e2a149c7bc356a5e9e..d9fc9e4aa5e4f47a77c2f9266456e274a9f06d68 100644
--- a/gcc/testsuite/g++.dg/ext/pr57735.C
+++ b/gcc/testsuite/g++.dg/ext/pr57735.C
@@ -2,7 +2,7 @@
 /* { dg-require-effective-target arm_arch_v5te_ok } */
 /* { dg-require-effective-target arm_arm_ok } */
 /* { dg-skip-if "do not override -mfloat-abi" { *-*-* } { "-mfloat-abi=*" } {"-mfloat-abi=soft" } } */
-/* { dg-options "-march=armv5te -marm  -mtune=xscale -mfloat-abi=soft -O1" } */
+/* { dg-options "-march=armv5te -marm  -mtune=xscale -mfloat-abi=soft -O1 -Wno-return-type" } */
 
 typedef unsigned int size_t;
 __extension__
diff --git a/gcc/testsuite/gcc.target/arm/pr54300.C b/gcc/testsuite/gcc.target/arm/pr54300.C
index eb1a74e36cff6d57f7444e1ca34b704c80efbf54..9105e279b331180aed8c5cadef2194cfe5b446ea 100644
--- a/gcc/testsuite/gcc.target/arm/pr54300.C
+++ b/gcc/testsuite/gcc.target/arm/pr54300.C
@@ -51,6 +51,7 @@ test(unsigned short *_Inp, int32_t *_Out,
   vst1q_s32( _Out, c );
 }
 
+int
 main()
 {
   unsigned short a[4] = {1, 2, 3, 4};
@@ -58,4 +59,5 @@ main()
   test(a, b, 1, 1, ~0);
   if (b[0] != 1 || b[1] != 2 || b[2] != 3 || b[3] != 4)
     abort();
+  return 0;
 }

Re: [PATCH][ARM] Fix more -Wreturn-type fallout

[Kyrill Tkachov]

Hi Sudi,

On 10/11/17 17:06, Sudi Das wrote:
>
> Hi
>
> This patch fixes a couple of more tests that are giving out warnings 
> with -Wreturn-type:
> - g++.dg/ext/pr57735.C
> - gcc.target/arm/pr54300.C
>

Thank you for the patch.
I've committed it on your behalf with r254773.

Kyrill

> *** gcc/testsuite/ChangeLog ***
>
> 2017-11-10  Sudakshina Das  <sudi.das@arm.com>
>
>         * g++.dg/ext/pr57735.C: Add -Wno-return-type for test.
>         * gcc.target/arm/pr54300.C (main): Add return type and
>         return a value.