From: Kyrill Tkachov <kyrylo.tkachov@foss.arm.com>
To: Tamar Christina <Tamar.Christina@arm.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Cc: nd <nd@arm.com>,
Ramana Radhakrishnan <Ramana.Radhakrishnan@arm.com>,
Richard Earnshaw <Richard.Earnshaw@arm.com>,
"nickc@redhat.com" <nickc@redhat.com>
Subject: Re: [PATCH][GCC][ARM] Silence more re-definition warnings, make test case failure case more explicit.
Date: Fri, 09 Feb 2018 12:14:00 -0000 [thread overview]
Message-ID: <5A7D90B4.2060005@foss.arm.com> (raw)
In-Reply-To: <20180207183550.GA6132@arm.com>
Hi Tamar,
On 07/02/18 18:35, Tamar Christina wrote:
> Hi All,
>
> The previous testcase would fail on a system where the initial mode is thumb and later
> switches to an arm mode. This would again cause some warnings to be emitted.
>
> This patch visits all builtins defined with builtin_define_with_int_value and undefines
> them if they could possibly change by changing the architecture.
>
> The testcase has also been updated to make it fail more easily on such cases.
>
> Bootstrapped and regtested on arm-none-Linux-gnueabihf and no issues.
>
> Ok for trunk?
>
Ok.
Thanks,
Kyrill
> Thanks,
> Tamar
>
>
> gcc/
> 2018-02-07 Tamar Christina <tamar.christina@arm.com>
>
> PR target/82641
> * config/arm/arm-c.c (arm_cpu_builtins): Un-define __ARM_FEATURE_LDREX,
> __ARM_ARCH_PROFILE, __ARM_ARCH_ISA_THUMB, __ARM_FP and __ARM_NEON_FP.
>
> gcc/testsuite
> 2018-02-07 Tamar Christina <tamar.christina@arm.com>
>
> PR target/82641
> * gcc.target/arm/pragma_arch_switch_2.c: Use armv6 and armv5t.
>
> --
prev parent reply other threads:[~2018-02-09 12:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-07 18:36 Tamar Christina
2018-02-09 12:14 ` Kyrill Tkachov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5A7D90B4.2060005@foss.arm.com \
--to=kyrylo.tkachov@foss.arm.com \
--cc=Ramana.Radhakrishnan@arm.com \
--cc=Richard.Earnshaw@arm.com \
--cc=Tamar.Christina@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=nd@arm.com \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).