From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 49002 invoked by alias); 9 Feb 2018 12:14:50 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 48991 invoked by uid 89); 9 Feb 2018 12:14:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy= X-HELO: foss.arm.com Received: from usa-sjc-mx-foss1.foss.arm.com (HELO foss.arm.com) (217.140.101.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 09 Feb 2018 12:14:49 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AB45D80D; Fri, 9 Feb 2018 04:14:47 -0800 (PST) Received: from [10.2.207.77] (e100706-lin.cambridge.arm.com [10.2.207.77]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6B3C63F25C; Fri, 9 Feb 2018 04:14:46 -0800 (PST) Message-ID: <5A7D90B4.2060005@foss.arm.com> Date: Fri, 09 Feb 2018 12:14:00 -0000 From: Kyrill Tkachov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Tamar Christina , "gcc-patches@gcc.gnu.org" CC: nd , Ramana Radhakrishnan , Richard Earnshaw , "nickc@redhat.com" Subject: Re: [PATCH][GCC][ARM] Silence more re-definition warnings, make test case failure case more explicit. References: <20180207183550.GA6132@arm.com> In-Reply-To: <20180207183550.GA6132@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2018-02/txt/msg00507.txt.bz2 Hi Tamar, On 07/02/18 18:35, Tamar Christina wrote: > Hi All, > > The previous testcase would fail on a system where the initial mode is thumb and later > switches to an arm mode. This would again cause some warnings to be emitted. > > This patch visits all builtins defined with builtin_define_with_int_value and undefines > them if they could possibly change by changing the architecture. > > The testcase has also been updated to make it fail more easily on such cases. > > Bootstrapped and regtested on arm-none-Linux-gnueabihf and no issues. > > Ok for trunk? > Ok. Thanks, Kyrill > Thanks, > Tamar > > > gcc/ > 2018-02-07 Tamar Christina > > PR target/82641 > * config/arm/arm-c.c (arm_cpu_builtins): Un-define __ARM_FEATURE_LDREX, > __ARM_ARCH_PROFILE, __ARM_ARCH_ISA_THUMB, __ARM_FP and __ARM_NEON_FP. > > gcc/testsuite > 2018-02-07 Tamar Christina > > PR target/82641 > * gcc.target/arm/pragma_arch_switch_2.c: Use armv6 and armv5t. > > --