From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 102542 invoked by alias); 16 May 2018 09:08:57 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 102533 invoked by uid 89); 16 May 2018 09:08:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-10.9 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY autolearn=ham version=3.3.2 spammy= X-HELO: foss.arm.com Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 16 May 2018 09:08:54 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CF5D180D; Wed, 16 May 2018 02:08:52 -0700 (PDT) Received: from [10.2.207.77] (e100706-lin.cambridge.arm.com [10.2.207.77]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B52FD3F25D; Wed, 16 May 2018 02:08:51 -0700 (PDT) Message-ID: <5AFBF522.5040805@foss.arm.com> Date: Wed, 16 May 2018 09:22:00 -0000 From: Kyrill Tkachov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Luis Machado , gcc-patches@gcc.gnu.org CC: james.greenhalgh@arm.com, Richard.Earnshaw@arm.com, "H.J. Lu" , Jeff Law Subject: Re: [PATCH 1/2] Introduce prefetch-minimum stride option References: <1516628770-25036-1-git-send-email-luis.machado@linaro.org> <1516628770-25036-2-git-send-email-luis.machado@linaro.org> <468c1099-3a87-6e95-53c4-3ba62fe3472f@linaro.org> <5AFAAA57.2080501@foss.arm.com> <3b4ec84e-5902-f7de-f047-282c3b3fff08@linaro.org> In-Reply-To: <3b4ec84e-5902-f7de-f047-282c3b3fff08@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2018-05/txt/msg00714.txt.bz2 On 15/05/18 12:12, Luis Machado wrote: > Hi, > > On 05/15/2018 06:37 AM, Kyrill Tkachov wrote: >> Hi Luis, >> >> On 14/05/18 22:18, Luis Machado wrote: >>> Hi, >>> >>> Here's an updated version of the patch (now reverted) that addresses the previous bootstrap problem (signedness and long long/int conversion). >>> >>> I've checked that it bootstraps properly on both aarch64-linux and x86_64-linux and that tests look sane. >>> >>> James, would you please give this one a try to see if you can still reproduce PR85682? I couldn't reproduce it in multiple attempts. >>> >> >> The patch doesn't hit the regressions in PR85682 from what I can see. >> I have a comment on the patch below. >> > > Great. Thanks for checking Kyrill. > >> --- a/gcc/tree-ssa-loop-prefetch.c >> +++ b/gcc/tree-ssa-loop-prefetch.c >> @@ -992,6 +992,23 @@ prune_by_reuse (struct mem_ref_group *groups) >> static bool >> should_issue_prefetch_p (struct mem_ref *ref) >> { >> + /* Some processors may have a hardware prefetcher that may conflict with >> + prefetch hints for a range of strides. Make sure we don't issue >> + prefetches for such cases if the stride is within this particular >> + range. */ >> + if (cst_and_fits_in_hwi (ref->group->step) >> + && abs_hwi (int_cst_value (ref->group->step)) < >> + (HOST_WIDE_INT) PREFETCH_MINIMUM_STRIDE) >> + { >> >> The '<' should go on the line below together with PREFETCH_MINIMUM_STRIDE. > > I've fixed this locally now. Thanks. I haven't followed the patch in detail, are you looking for midend changes approval since the last version? Or do you need aarch64 approval? Kyrill