From: Kyrill Tkachov <kyrylo.tkachov@foss.arm.com>
To: Tamar Christina <tamar.christina@arm.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Cc: nd <nd@arm.com>, James Greenhalgh <James.Greenhalgh@arm.com>,
Richard Earnshaw <Richard.Earnshaw@arm.com>,
Marcus Shawcroft <Marcus.Shawcroft@arm.com>
Subject: Re: [PATCH][GCC][AArch64] Correct 3 way XOR instructions adding missing patterns.
Date: Thu, 17 May 2018 09:56:00 -0000 [thread overview]
Message-ID: <5AFD50BB.6030200@foss.arm.com> (raw)
In-Reply-To: <20180430141233.GA28350@arm.com>
Hi Tamar,
On 30/04/18 15:12, Tamar Christina wrote:
> Hi All,
>
> This patch adds the missing neon intrinsics for all 128 bit vector Integer modes for the
> three-way XOR and negate and xor instructions for Arm8.2-a to Armv8.4-a.
>
> Bootstrapped and regtested on aarch64-none-linux-gnue and no issues.
>
> Ok for master? And for backport to the GCC-8 branch?
>
This looks ok to me and appropriate for trunk but you'll need approval from a maintainer.
Thanks,
Kyrill
> gcc/
> 2018-04-30 Tamar Christina <tamar.christina@arm.com>
>
> * config/aarch64/aarch64-simd.md (aarch64_eor3qv8hi): Change to
> eor3q<mode>4.
> (aarch64_bcaxqv8hi): Change to bcaxq<mode>4.
> * config/aarch64/aarch64-simd-builtins.def (veor3q_u8, veor3q_u32,
> veor3q_u64, veor3q_s8, veor3q_s16, veor3q_s32, veor3q_s64, vbcaxq_u8,
> vbcaxq_u32, vbcaxq_u64, vbcaxq_s8, vbcaxq_s16, vbcaxq_s32,
> vbcaxq_s64): New.
> * config/aarch64/arm_neon.h: Likewise.
> * config/aarch64/iterators.md (VQ_I): New.
>
> gcc/testsuite/
> 2018-04-30 Tamar Christina <tamar.christina@arm.com>
>
> * gcc.target/gcc.target/aarch64/sha3.h (veor3q_u8, veor3q_u32,
> veor3q_u64, veor3q_s8, veor3q_s16, veor3q_s32, veor3q_s64, vbcaxq_u8,
> vbcaxq_u32, vbcaxq_u64, vbcaxq_s8, vbcaxq_s16, vbcaxq_s32,
> vbcaxq_s64): New.
> * gcc.target/gcc.target/aarch64/sha3_1.c: Likewise.
> * gcc.target/gcc.target/aarch64/sha3_1.c: Likewise.
> * gcc.target/gcc.target/aarch64/sha3_1.c: Likewise.
>
> Thanks,
> Tamar
>
> --
next prev parent reply other threads:[~2018-05-17 9:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-30 14:34 Tamar Christina
2018-05-08 7:40 ` Tamar Christina
2018-05-17 9:56 ` Kyrill Tkachov [this message]
2018-05-18 15:10 ` Richard Earnshaw (lists)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5AFD50BB.6030200@foss.arm.com \
--to=kyrylo.tkachov@foss.arm.com \
--cc=James.Greenhalgh@arm.com \
--cc=Marcus.Shawcroft@arm.com \
--cc=Richard.Earnshaw@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=nd@arm.com \
--cc=tamar.christina@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).