From: Kyrill Tkachov <kyrylo.tkachov@foss.arm.com>
To: "christophe.lyon@st.com" <christophe.lyon@st.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Cc: "christophe.lyon@linaro.org" <christophe.lyon@linaro.org>
Subject: Re: [ARM/FDPIC v2 07/21] [ARM] FDPIC: Avoid saving/restoring r9 on stack since it is RO
Date: Wed, 29 Aug 2018 10:52:00 -0000 [thread overview]
Message-ID: <5B867B01.7050400@foss.arm.com> (raw)
In-Reply-To: <20180713161136.29104-8-christophe.lyon@st.com>
Hi Christophe,
On 13/07/18 17:11, christophe.lyon@st.com wrote:
> From: Christophe Lyon <christophe.lyon@linaro.org>
>
> 2018-XX-XX Christophe Lyon <christophe.lyon@st.com>
> Mickaël Guêné <mickael.guene@st.com>
>
> gcc/
> * config/arm/arm.c (arm_compute_save_reg0_reg12_mask): Handle
> FDPIC.
> (thumb1_compute_save_core_reg_mask): Likewise.
>
> Change-Id: Ib534cf91704cdc740867b46a8fe45fda27894562
>
> diff --git a/gcc/config/arm/arm.c b/gcc/config/arm/arm.c
> index 44c3b08..c9f391b 100644
> --- a/gcc/config/arm/arm.c
> +++ b/gcc/config/arm/arm.c
> @@ -19486,7 +19486,7 @@ arm_compute_save_reg0_reg12_mask (void)
>
> /* Also save the pic base register if necessary. */
> if (flag_pic
> - && !TARGET_SINGLE_PIC_BASE
> + && !TARGET_SINGLE_PIC_BASE && !TARGET_FDPIC
> && arm_pic_register != INVALID_REGNUM
> && crtl->uses_pic_offset_table)
> save_reg_mask |= 1 << PIC_OFFSET_TABLE_REGNUM;
> @@ -19520,7 +19520,7 @@ arm_compute_save_reg0_reg12_mask (void)
> /* If we aren't loading the PIC register,
> don't stack it even though it may be live. */
> if (flag_pic
> - && !TARGET_SINGLE_PIC_BASE
> + && !TARGET_SINGLE_PIC_BASE && !TARGET_FDPIC
> && arm_pic_register != INVALID_REGNUM
> && (df_regs_ever_live_p (PIC_OFFSET_TABLE_REGNUM)
> || crtl->uses_pic_offset_table))
> @@ -19689,7 +19689,7 @@ thumb1_compute_save_core_reg_mask (void)
> mask |= 1 << HARD_FRAME_POINTER_REGNUM;
>
> if (flag_pic
> - && !TARGET_SINGLE_PIC_BASE
> + && !TARGET_SINGLE_PIC_BASE && !TARGET_FDPIC
> && arm_pic_register != INVALID_REGNUM
> && crtl->uses_pic_offset_table)
> mask |= 1 << PIC_OFFSET_TABLE_REGNUM;
Is this change necessary? FDPIC is only supported for Armv7 onwards, so the Thumb1 path shouldn't be called?
Thanks,
Kyrill
> --
> 2.6.3
>
next prev parent reply other threads:[~2018-08-29 10:52 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-13 16:12 [ARM/FDPIC v2 00/21] FDPIC ABI for ARM christophe.lyon
2018-07-13 16:12 ` [ARM/FDPIC v2 01/21] [ARM] FDPIC: Add -mfdpic option support christophe.lyon
2018-08-29 10:46 ` Kyrill Tkachov
2018-08-31 14:09 ` Christophe Lyon
2018-09-21 15:41 ` Christophe Lyon
2018-07-13 16:12 ` [ARM/FDPIC v2 02/21] [ARM] FDPIC: Handle arm*-*-uclinuxfdpiceabi in configure scripts christophe.lyon
2018-08-29 10:46 ` Kyrill Tkachov
2018-08-31 14:13 ` Christophe Lyon
2018-09-09 8:16 ` Christophe Lyon
2018-07-13 16:13 ` [ARM/FDPIC v2 03/21] [ARM] FDPIC: Force FDPIC related options unless -mno-fdpic is provided christophe.lyon
2018-07-13 16:13 ` [ARM/FDPIC v2 04/21] [ARM] FDPIC: Add support for FDPIC for arm architecture christophe.lyon
2018-08-29 10:46 ` Kyrill Tkachov
2018-09-04 15:29 ` Richard Earnshaw (lists)
2018-09-05 12:07 ` Christophe Lyon
2018-07-13 16:13 ` [ARM/FDPIC v2 05/21] [ARM] FDPIC: Fix __do_global_dtors_aux and frame_dummy generation christophe.lyon
2018-07-13 16:14 ` [ARM/FDPIC v2 08/21] [ARM] FDPIC: Ensure local/global binding for function descriptors christophe.lyon
2018-07-13 16:14 ` [ARM/FDPIC v2 06/21] [ARM] FDPIC: Add support for c++ exceptions christophe.lyon
2018-08-29 10:49 ` Kyrill Tkachov
2018-07-13 16:14 ` [ARM/FDPIC v2 07/21] [ARM] FDPIC: Avoid saving/restoring r9 on stack since it is RO christophe.lyon
2018-08-29 10:52 ` Kyrill Tkachov [this message]
2018-07-13 16:15 ` [ARM/FDPIC v2 09/21] [ARM] FDPIC: Add support for taking address of nested function christophe.lyon
2018-08-29 11:01 ` Kyrill Tkachov
2018-08-31 14:17 ` Christophe Lyon
2018-07-13 16:15 ` [ARM/FDPIC v2 11/21] [ARM] FDPIC: Add support to unwind FDPIC signal frame christophe.lyon
2018-07-13 16:15 ` [ARM/FDPIC v2 10/21] [ARM] FDPIC: Implement TLS support christophe.lyon
2018-07-13 16:16 ` [ARM/FDPIC v2 14/21] [ARM][testsuite] FDPIC: Skip unsupported tests christophe.lyon
2018-07-13 16:16 ` [ARM/FDPIC v2 13/21] [ARM] FDPIC: Force LSB bit for PC in Cortex-M architecture christophe.lyon
2018-07-13 16:16 ` [ARM/FDPIC v2 12/21] [ARM] FDPIC: Restore r9 after we call __aeabi_read_tp christophe.lyon
2018-07-13 16:17 ` [ARM/FDPIC v2 15/21] [ARM][testsuite] FDPIC: Adjust scan-assembler patterns christophe.lyon
2018-07-13 16:17 ` [ARM/FDPIC v2 16/21] [ARM][testsuite] FDPIC: Skip v8-m and v6-m tests that currently produce an ICE christophe.lyon
2018-07-13 16:17 ` [ARM/FDPIC v2 17/21] [ARM][testsuite] FDPIC: Skip tests that don't work in PIC mode christophe.lyon
2018-07-13 16:18 ` [ARM/FDPIC v2 18/21] [ARM][testsuite] FDPIC: Handle *-*-uclinux* christophe.lyon
2018-07-13 16:18 ` [ARM/FDPIC v2 19/21] [ARM][testsuite] FDPIC: Enable tests on pie_enabled targets christophe.lyon
2018-07-13 16:18 ` [ARM/FDPIC v2 20/21] [ARM][testsuite] FDPIC: Adjust pr43698.c to avoid clash with uclibc christophe.lyon
2018-07-13 16:19 ` [ARM/FDPIC v2 21/21] [ARM][testsuite] FDPIC: Skip tests using architecture older than v7 christophe.lyon
2018-08-01 14:03 ` [ARM/FDPIC v2 00/21] FDPIC ABI for ARM Christophe Lyon
2018-08-16 22:20 ` Christophe Lyon
2018-08-28 16:09 ` Christophe Lyon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5B867B01.7050400@foss.arm.com \
--to=kyrylo.tkachov@foss.arm.com \
--cc=christophe.lyon@linaro.org \
--cc=christophe.lyon@st.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).