* [PATCH] Fix gcc.dg/warn-abs-1.c for arm and aarch64-none-elf
@ 2018-09-18 13:50 Kyrill Tkachov
2018-09-18 14:00 ` Jeff Law
2018-09-18 14:04 ` Rainer Orth
0 siblings, 2 replies; 4+ messages in thread
From: Kyrill Tkachov @ 2018-09-18 13:50 UTC (permalink / raw)
To: gcc-patches; +Cc: mjambor, Jeff Law
[-- Attachment #1: Type: text/plain, Size: 688 bytes --]
Hi all,
This new test has some difficulties on the fabsl function.
On arm this is because we don't support the _Float128 type which the test uses.
This is handled in the patch by requiring a float128 target selector.
On aarch64-none-elf, a Newlib target, it fails because fabsl is not available.
long double support is known to be incomplete in newlib, and the fabsl function is not available
for targets where long double is larger than a double.
Therefore this patch skips the test on such targets.
Ok for trunk?
Thanks,
Kyrill
2018-09-18 Kyrylo Tkachov <kyrylo.tkachov@arm.com>
* gcc.dg/warn-abs-1.c: Require float128 target.
Skip if large_long_double newlib target.
[-- Attachment #2: warn-abs.patch --]
[-- Type: text/x-patch, Size: 501 bytes --]
diff --git a/gcc/testsuite/gcc.dg/warn-abs-1.c b/gcc/testsuite/gcc.dg/warn-abs-1.c
index 6aa937c3a2e9921e90969911550eebf2965ffdb4..129a3af8ac69a93596e98c6e50089fe9b74fe3d0 100644
--- a/gcc/testsuite/gcc.dg/warn-abs-1.c
+++ b/gcc/testsuite/gcc.dg/warn-abs-1.c
@@ -1,4 +1,5 @@
-/* { dg-do compile } */
+/* { dg-do compile { target float128 } } */
+/* { dg-skip-if "incomplete long double support" { { newlib } && large_long_double } } */
/* { dg-options "-Wabsolute-value" } */
#include <stdlib.h>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] Fix gcc.dg/warn-abs-1.c for arm and aarch64-none-elf
2018-09-18 13:50 [PATCH] Fix gcc.dg/warn-abs-1.c for arm and aarch64-none-elf Kyrill Tkachov
@ 2018-09-18 14:00 ` Jeff Law
2018-09-18 14:04 ` Rainer Orth
1 sibling, 0 replies; 4+ messages in thread
From: Jeff Law @ 2018-09-18 14:00 UTC (permalink / raw)
To: Kyrill Tkachov, gcc-patches; +Cc: mjambor
On 9/18/18 7:45 AM, Kyrill Tkachov wrote:
> Hi all,
>
> This new test has some difficulties on the fabsl function.
> On arm this is because we don't support the _Float128 type which the
> test uses.
> This is handled in the patch by requiring a float128 target selector.
>
> On aarch64-none-elf, a Newlib target, it fails because fabsl is not
> available.
> long double support is known to be incomplete in newlib, and the fabsl
> function is not available
> for targets where long double is larger than a double.
> Therefore this patch skips the test on such targets.
>
> Ok for trunk?
>
> Thanks,
> Kyrill
>
> 2018-09-18 Kyrylo Tkachov <kyrylo.tkachov@arm.com>
>
> Â Â Â * gcc.dg/warn-abs-1.c: Require float128 target.
> Â Â Â Skip if large_long_double newlib target.
OK
jeff
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Fix gcc.dg/warn-abs-1.c for arm and aarch64-none-elf
2018-09-18 13:50 [PATCH] Fix gcc.dg/warn-abs-1.c for arm and aarch64-none-elf Kyrill Tkachov
2018-09-18 14:00 ` Jeff Law
@ 2018-09-18 14:04 ` Rainer Orth
2018-09-18 14:19 ` Kyrill Tkachov
1 sibling, 1 reply; 4+ messages in thread
From: Rainer Orth @ 2018-09-18 14:04 UTC (permalink / raw)
To: Kyrill Tkachov; +Cc: gcc-patches, mjambor, Jeff Law
Hi Kyrill,
> This new test has some difficulties on the fabsl function.
> On arm this is because we don't support the _Float128 type which the test uses.
> This is handled in the patch by requiring a float128 target selector.
>
> On aarch64-none-elf, a Newlib target, it fails because fabsl is not available.
> long double support is known to be incomplete in newlib, and the fabsl
> function is not available
> for targets where long double is larger than a double.
> Therefore this patch skips the test on such targets.
this is PR testsuite/87339. Please fix the ChangeLog accordingly.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Fix gcc.dg/warn-abs-1.c for arm and aarch64-none-elf
2018-09-18 14:04 ` Rainer Orth
@ 2018-09-18 14:19 ` Kyrill Tkachov
0 siblings, 0 replies; 4+ messages in thread
From: Kyrill Tkachov @ 2018-09-18 14:19 UTC (permalink / raw)
To: Rainer Orth; +Cc: gcc-patches, mjambor, Jeff Law
On 18/09/18 14:59, Rainer Orth wrote:
> Hi Kyrill,
>
>> This new test has some difficulties on the fabsl function.
>> On arm this is because we don't support the _Float128 type which the test uses.
>> This is handled in the patch by requiring a float128 target selector.
>>
>> On aarch64-none-elf, a Newlib target, it fails because fabsl is not available.
>> long double support is known to be incomplete in newlib, and the fabsl
>> function is not available
>> for targets where long double is larger than a double.
>> Therefore this patch skips the test on such targets.
> this is PR testsuite/87339. Please fix the ChangeLog accordingly.
Ah, thanks. I've adjusted the ChangeLog entry with r264393.
Kyrill
> Rainer
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-09-18 14:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-18 13:50 [PATCH] Fix gcc.dg/warn-abs-1.c for arm and aarch64-none-elf Kyrill Tkachov
2018-09-18 14:00 ` Jeff Law
2018-09-18 14:04 ` Rainer Orth
2018-09-18 14:19 ` Kyrill Tkachov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).