From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by sourceware.org (Postfix) with ESMTPS id C7BBF3858409 for ; Mon, 13 Dec 2021 14:47:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C7BBF3858409 Received: by mail-wm1-x335.google.com with SMTP id j140-20020a1c2392000000b003399ae48f58so14178522wmj.5 for ; Mon, 13 Dec 2021 06:47:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:user-agent:in-reply-to :references:message-id:mime-version:content-transfer-encoding; bh=QTRoY1nAtbZ0XtEg4pdIhDRgIqjwabcRKMqWVxHsqHA=; b=utaDjvOgMR+1r9jBO9JC3H12DnvmIudJt2WHab4xFQFcfreRw3H3gmFGaRNSFqp3lM sLG1nyLXeNGFZbpm8iS/wXR5zY4UFbmE4YIBwPwmHY6fp2CChmUsT11U/NonCEXKws1E Ia2S6EZC7nvumOVQnVRI9a04ByUmC+4qzxOGiLurj5ihxsehrI3ORaS2gdI+GCrrHFM6 JFc76UII01eaZN7rSmcxQVVhFIImvLyJwfgOKU/iDdkGXu7nfv+2/w/Tak+HjqaWCaWA 6bHF8HxCjDuy5xA5o3C+vDCAdiwFTGP4B5NnGiOX0K1LnVm5biQl1svcmj2iRKnD8pgV xK3g== X-Gm-Message-State: AOAM532qGzBqRf7PDCjwKYjNwb+Ro5UW6AwGMvZBQ9e09trdoihhV7VU EzNI0S7VGcBLJ281gmfXXHk7ehoNuM8= X-Google-Smtp-Source: ABdhPJzAGhtQyc2EQwJjrTCf1HKrdiAPI6rHP5GXT3+e69i/Q5yWLmgSvxeBjUYc5vmlbsd7Zf5uYQ== X-Received: by 2002:a05:600c:5101:: with SMTP id o1mr38406778wms.81.1639406826705; Mon, 13 Dec 2021 06:47:06 -0800 (PST) Received: from [127.0.0.1] (dynamic-002-247-253-179.2.247.pool.telefonica.de. [2.247.253.179]) by smtp.gmail.com with ESMTPSA id n2sm7320945wmi.36.2021.12.13.06.47.06 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 13 Dec 2021 06:47:06 -0800 (PST) Date: Mon, 13 Dec 2021 15:47:05 +0100 From: Richard Biener To: gcc-patches@gcc.gnu.org, Tobias Burnus , Joel Hutton , Richard Sandiford CC: GCC Patches , Richard Biener Subject: =?US-ASCII?Q?Re=3A_GCC_11_backport_does_not?= =?US-ASCII?Q?_build_=28no_=22directly=5Fsupport?= =?US-ASCII?Q?ed=5Fp=22=29_-_was=3A_Re=3A_pr103523=3A_?= =?US-ASCII?Q?Check_for_PLUS/MINUS_support?= User-Agent: K-9 Mail for Android In-Reply-To: <0cf2edb4-f9f4-4623-e2b2-d0952385174d@codesourcery.com> References: <0cf2edb4-f9f4-4623-e2b2-d0952385174d@codesourcery.com> Message-ID: <5BD5E539-4E9C-440D-B01B-068DF5D0571F@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=0.3 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Dec 2021 14:47:10 -0000 On December 13, 2021 3:27:50 PM GMT+01:00, Tobias Burnus wrote: >Hi Joel, > >your patch fails here with: > >=2E=2E/=2E=2E/repos/gcc-11-commit/gcc/tree-vect-loop=2Ec:8000:8: error: >=E2=80=98directly_supported_p=E2=80=99 was not declared in this scope > 8000 |=C2=A0=C2=A0 if (!directly_supported_p (PLUS_EXPR, step_vectype) > |=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ^~~~~~~~~~~~~~~~~~~~ > >And "git grep" shows that this is only present in: > >gcc/tree-vect-loop=2Ec: if (!directly_supported_p (PLUS_EXPR, step_vecty= pe) >gcc/tree-vect-loop=2Ec: || !directly_supported_p (MINUS_EXPR, >step_vectype)) > >That's different on mainline, which offers that function=2E Just as a reminder, backports need regular bootstrap and regtest validatio= n on the respective branches=2E=20 Richard=2E=20 >Tobias > >On 10=2E12=2E21 14:24, Joel Hutton via Gcc-patches wrote: >> ok for backport to 11? >> ________________________________ >> From: Richard Sandiford >> Sent: 10 December 2021 10:22 >> To: Joel Hutton >> Cc: GCC Patches ; Richard Biener >> Subject: Re: pr103523: Check for PLUS/MINUS support >> >> Joel Hutton writes: >>> Hi all, >>> >>> This is to address pr103523=2E >>> >>> bootstrapped and regression tested on aarch64=2E >>> >>> Check for PLUS_EXPR/MINUS_EXPR support in vectorizable_induction=2E >>> PR103523 is an ICE on valid code: >>> >>> void d(float *a, float b, int c) { >>> float e; >>> for (; c; c--, e +=3D b) >>> a[c] =3D e; >>> } >>> >>> This is due to not checking for PLUS_EXPR support, which is missing in >>> VNx2sf mode=2E This causes an ICE at expand time=2E This patch adds a = check >>> for support in vectorizable_induction=2E >>> >>> gcc/ChangeLog: >>> >>> PR tree-optimization/PR103523 >> The bugzilla hook expects: PR tree-optimization/103523 >> >>> * tree-vect-loop=2Ec (vectorizable_induction): Check for >>> PLUS_EXPR/MINUS_EXPR support=2E >> OK, thanks=2E >> >> Richard >----------------- >Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 2= 01, 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch= =C3=A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellsc= haft: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955