From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id B9EDA3898395 for ; Thu, 6 Oct 2022 12:50:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B9EDA3898395 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 296CBGKo021023; Thu, 6 Oct 2022 12:50:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-id : content-transfer-encoding : mime-version; s=corp-2022-7-12; bh=qir1fewCSHSDYns5z815Y1rtG+q8aNDvH8AmQX28CpA=; b=ApwqlWflb9YbKDGTmNwhUpp1Du1jmexx+a60exaZTX55FTqhfJ3GeoGOH2HtloEvbevE aUvfvlRwS8Ih2vrY7BOrCjLbxHahx8SEyAaCs1V9vehlCiLOs/E/o4g2/ye4+pZUYxDz VRBndtWzKygzbxNgwp3nB6YsxLuDxgIs0cUr09XBYG+c/FsGrM/E9TXnNwKP/OCZFF/U OyTu+PM1GCtivQk1XZtDivi94/248Jn04vytBuMj1ztn/TGT8U7J0tVhTghkxt6q63vz 9vtm9Wj0ZeRj497uQgtC9/+Bct3VNyY5y6GNqEk/5QVEmi1txE1+e2lXnsFcnWq6HlKa uQ== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3jxcb2v3pm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 06 Oct 2022 12:50:01 +0000 Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 296CGZMh037582; Thu, 6 Oct 2022 12:50:00 GMT Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2169.outbound.protection.outlook.com [104.47.58.169]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3jxc062sju-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 06 Oct 2022 12:50:00 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XixcvEHjRAgHbIZgJYrBP89QGMJ72zFTAkUllX7DQYexSvLjkAE1sFzgIK/xm2HYN8o49xdfDSzlYJeP9+yp9ncHhAG0tV4UqCTtEVvcwUNPbD3oS96//henOuuk54CDd6hrdwvfwi0Vv0Dr7O9lkqrr2zzcWXdo7vQnGYEZ64PnCy7sbSFgEfA7b/pAzZFWq0tpG7tugfaR61I5deCmC24t7JJyvTKGKcGDgKMf/oyKybkQuYp/G91I43NK67NZVaspQRcqU5eShl9tj1aMZ7NrV5XSRA0be59cvceWMFvmq1TrqbH9Juz8SHVE5Gkltn2JzgVZD8B5LB8fh+ve+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qir1fewCSHSDYns5z815Y1rtG+q8aNDvH8AmQX28CpA=; b=QwQ2F13H/NNBQEgm0kGL4tEgsJQcaaQOnFfEMulIyXADEyINg4W62fbWEecRfwgQr33rdohrKYHEJgrPU27PApOw+clnUbyR3ndGK095SXdZQ0d6X0HVlkR7P6X4bdIALMPj43fLmXgLnQV2GmKl5WdQf09SU7ky058w5HxDfpNbu7fhirKyouoJqh2EIV4O8RemOx86OPjweLhruAdN16O0heWX0cFSc6aGOEKoA9EQ1UMZ2CJDMRA/YRhwTu/Bop2cOzXH1o6itMRDBu243LXWLtrWChF6I6a4zKveVrLBAAJGFEAcXiMDOVU6eqFGHiszgcpw1JW/ym+XKzfFFA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qir1fewCSHSDYns5z815Y1rtG+q8aNDvH8AmQX28CpA=; b=bSvP8SVMvpHdhMhY/3ZaF5qrDC7wUBx/ZlIsBwS393NSJbIjXhw0oNJz/7+vuvlzG9PfU9Pmzu/TrmNWAF9bxi9PdSjCpxpTKKEXkmDlHxK2BV2ACG3tYt0ixAh5imqtoDkmRlWPuAt8FkckDi8j4c1OP+YPvKBI3SrYWyPtaYo= Received: from CH2PR10MB4344.namprd10.prod.outlook.com (2603:10b6:610:af::19) by BN0PR10MB5287.namprd10.prod.outlook.com (2603:10b6:408:12f::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.23; Thu, 6 Oct 2022 12:49:59 +0000 Received: from CH2PR10MB4344.namprd10.prod.outlook.com ([fe80::cbf8:6682:721e:835c]) by CH2PR10MB4344.namprd10.prod.outlook.com ([fe80::cbf8:6682:721e:835c%6]) with mapi id 15.20.5676.036; Thu, 6 Oct 2022 12:49:59 +0000 From: Qing Zhao To: Joseph Myers , Richard Biener CC: GCC Patches , martin Sebor , jakub Jelinek , Kees Cook Subject: Re: [GCC13][Patch][V6][PATCH 1/2] Add a new option -fstrict-flex-arrays[=n] and new attribute strict_flex_array Thread-Topic: [GCC13][Patch][V6][PATCH 1/2] Add a new option -fstrict-flex-arrays[=n] and new attribute strict_flex_array Thread-Index: AQHY2O6MDrCFXpkTTkGPTDkDvaVcQ64AP0WAgAETJQA= Date: Thu, 6 Oct 2022 12:49:59 +0000 Message-ID: <5C0AB68D-9014-44A6-A991-111EB91AF33C@oracle.com> References: <20221005191320.2087486-1-qing.zhao@oracle.com> <20221005191320.2087486-2-qing.zhao@oracle.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH2PR10MB4344:EE_|BN0PR10MB5287:EE_ x-ms-office365-filtering-correlation-id: 52082d00-2a5c-450a-56e2-08daa799472e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: nGsWLZ7dxQie66tLJ4WQrMh1sfKgag6ZVHfpDyFXoA8of0PJZooVi1iFc6aQsnMVcxKqOtUkIEgAHW5FdnuRPpSjMsZ/el7yg2xKJJmqRklK4z8NNHgnp6Ukcd+Iyh+Ft71SQPMxzuZ83+QThhlbSxhELWVBXOvgKYBGUQzkv88qi651KDu4FMKk1grWLwr0+hKfLfuibFHUJvP2FP4au4sh34C9sZZhHi1JOWR4gLWDL+km+R/tJMOU2DoypwxYTQvyUa4UeJg0pZLs+cPhRFpgABoUSZmSaPzeOvXM43g+DD1v6BJVb2c9yUXWrWGlDBxNSU3M7awz+V14bWejXyYd6Bt1Ng6gn182BY8BtELqfbllzT0bxZDp3LQlV2COwqgo2/fCdMLkm2Nt88TKD327tgDP9RuisJg46XBA7uxwhRE7MUBFd1zeQ99yytdLDxrVlveEOnhJod+jIvrt6ZJPueXZs9rQmpAODJsw9qx4+Fn7/tmyXqN5yH6q+7UocM6iyEUNwZOsr4XT+YfpWWbRdK0n4qD5643LcRS5pK8p8Epb67N/7f8JYfaG7AiA+JD8y2kHT0aQAtWZ77TBwZ1Z/6rmZCSvIzAYKEbgxy7sOI8TK1R61pdoWtrUdnhPqgJBdBWDECSO4lPnjk+4xziG95hZtztHGEkw1bccf4abWZfRxFwzAHSyZODqH4FVY4783lQotUOrA33xE4dCjDYdvN8JgW9fiMtOao+FgMLshWhL1jHgskadoJMdyufP9urRs0kdJ49CpH4M/j/Yxo0MCC8ppMJTeFFCJvYRi7w= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR10MB4344.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(39860400002)(396003)(136003)(366004)(346002)(451199015)(66476007)(36756003)(33656002)(66946007)(66446008)(64756008)(76116006)(91956017)(2906002)(44832011)(26005)(4326008)(53546011)(6512007)(41300700001)(8676002)(38070700005)(38100700002)(66556008)(86362001)(5660300002)(8936002)(122000001)(316002)(54906003)(110136005)(83380400001)(2616005)(478600001)(6486002)(71200400001)(186003)(6506007)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?kDVUsMsPNocXsajl/J2O0kUdivSD5a+5c1ojLM8mYLKW2duKGCwHQVtmINGM?= =?us-ascii?Q?sSJ81UTTeVnyBYwB1scBX1ysDGD8h2HQRKEvR6kE1vJFFf7c2j8WQkvYbVRB?= =?us-ascii?Q?Y398WaZFiyhKNyq5gFAfiUbg2s9m4si/EBg9Bs1/VqhF1zUINUL9qLNwp+wi?= =?us-ascii?Q?G6z+UIqtxPgl0ymqD46LyjKIsaReG9dzsI7iXjtqVrM39/FkbSA6jZIbjj2B?= =?us-ascii?Q?o0u40bqi2x0+nzsHbp5KMVqT+QTaYAKfhcw/EByGke+GcL3rkBiwrcWY0pbz?= =?us-ascii?Q?cDZtECBp1uSumIQZCIIP680AuPOTgH63f6LqX1B86iP55WqoqmmhwiyUPESP?= =?us-ascii?Q?tD77kBgeIvFx++MQ277JAc3EyFi4dRWzZ6g5rPxdUMjehfWSGcbwA2xk36Ba?= =?us-ascii?Q?jV6Ehzjr8WUNuYSIZcjYzUF4kSavYAcX2abttFBRATOaMbTuSJnaXMBLFEsl?= =?us-ascii?Q?VYpXFFyi5yqL9yoYhe2m7rmK9KrJaj+LXUnGcdoLl+avMqHdzsACv4P9awiD?= =?us-ascii?Q?fXsQO9v0buHKYAtd5HrOYc118lYH34MKQlVUytgn9izJXPzxmTuVdGehNdfp?= =?us-ascii?Q?6bBfjKIFlQFUnKN4ZVT+PviQAqr0Ov3+0flgNHwtZuzc5lNAWPJjOeTo9AIb?= =?us-ascii?Q?+eVGwXYWZph8sdKq+H5TO+0WvYh03kTWPORbpbSdQjIItSsLV5PFbxaUvaFb?= =?us-ascii?Q?MDdJN4h6NcSmGXqut8Ly1L+r1QYdnvlQwtH69bw+ybkVUcRt0hsk4dU5jJ0w?= =?us-ascii?Q?wjDb/jftK9vS9D+/s85bfskSopsWppE8CW8ffjojhVjTxU4zN7HMKHf55V2K?= =?us-ascii?Q?bjqzr85R5lU3FW8wqzHIwP5IJxXxGbqKUcugEFHGNOW+M3EZ9g/Et2rLe4Hx?= =?us-ascii?Q?ReOwQTIjMwV/8LAtsoP3nPQP+HsxmgqnB4/YibQheo1J90VMmjOwmvlrUiNd?= =?us-ascii?Q?gYAkn0oVxhQoFRy0gGGVaBow2db9ZkKuvw3Lvnd+uLDV4WgUN6Ig/kZWJA3P?= =?us-ascii?Q?jY6WVi9b9BWtbZQJspphFJ9zGkaXzrOETwYpUi3Pzjlk13+ga35O1mbHjOCR?= =?us-ascii?Q?3tRNI+28OY2RhHNFnOL4Zn+cIwu4uGTsMJJ8opeU5cSCYAfl7nZlfQXmHHkg?= =?us-ascii?Q?dflm3W6uEECz61bUn2bEIF7sHHWmYLCPQxp+YXqlxu0SYrVp9Cdc2HhBHXPH?= =?us-ascii?Q?GKJQAYlFnKEeFTwXKchkgzJxdFMom13NLP4ZeHDLlBYvRpv/XFr/Bxxrx4y3?= =?us-ascii?Q?+UGXENPexP0w3nzGUHWbYF6cWUD7bdUFtJAUIQMJa9mqSyEHZVPYzZlNKr37?= =?us-ascii?Q?tf0/JMnL/Pg4NRDbYjmdTviRiRxdjmwIMXHGrXhQOY0pngSwVVuusXWgcJoU?= =?us-ascii?Q?rlBh7daJPLwnyj4sXKVFoH9hNolKIdCr14v0snB/ooQglmTjEqKIeB9/KaHd?= =?us-ascii?Q?k++6vR8VxO3Qf7zBQCHiMTHTU7cWDQena8JHaytRsTYawYx2ZqLYaOJ/UEkM?= =?us-ascii?Q?xhIDZL6+M13I9XRwHv8AHQ5FP4+TyNn0bnOjMOxH/HKKYVe/+1Ia5WkvyQkY?= =?us-ascii?Q?vIpPBQ5bHDQGyWRDggV883y8s5bfnKsuu9jYWVE1?= Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: u5wh5ke8S/Hsv/ka1VzosKwR5IIaUbV54PUtIT3/HJ3HG5PDaABsP9DyOovxsHtC/voIq3aNuFf3Fz89KTZA7VoGGV6ix9iULEaK9lV7fdaMB2nfRsh7Q8SDRMZD2YieUi55m4J6W+JENIu8h9KffN9gnGoyRVSMERtPH8X2jmFv3rVnW8MDbaJcgtZZ3MSljLrGvPN+NovfqR5n0PDSgyGkGT5vFOYolyF1njv5G1QgEv4CTv+K3NtQv64bQgpTBY0icFxHP/xCf0RLUpnKVWpJv6myGhSOCr47xu9ZOWzwM5gsMgahg5+WD5DXAd7ElyySJQNCWLVMFvVJYKOFBmF/N/DuyLF8aQzOnDXO91ZR/Jiy+PQr63WnyNbUxRWfofq8irRrvfbFQ6vLCh+QdIPDVExDBbw6G9zYIbO4txtqLH5RhFloRvd4iq7dJ0sOVUbVj28QOerT4oY0F7v6L3tOPMskIoJvX2Z+ardEpfOHQZ1jXBJxSmxBe9AcG/EORKrhpNacSEzg2K+JbpXYAYcRn4ANE70nHv2Eq8ORNzF8Wauf68LMdzhx+DJjdfPhNaVdEXz1HmmZ70ZufUnG9bLTBc1kq2LjZWgyfCWhKpXcL+LSsKZa+3gQBDD061YSa6R1Qx0F2eniDB5LDpB0twddTGj07sOLo4lOjgmwkR6MNgeQhGVXM6D3Nl+wWi4mQ815sObappILTqfyG+EWFDXeIhImwbRfn/cH2Tx8EImt7eJhS1bRF6jdqxrBCIvKcTHk+69DPGDIvD1FiVMAly8T/V8VJpBOC3vkAPuFILuelOYzTnKhcdx3jnvfiQVQkPK2+0Ut2diUAJv8Ii1A3ZozrzHz4AWIAOZ4CgBZF7UvvLh0GMoUkl2FFTvwOesvsL1sWNpy3bmjNl7yKHpRAU/mlQ2TkJjMIytZ14DUOcI= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH2PR10MB4344.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 52082d00-2a5c-450a-56e2-08daa799472e X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Oct 2022 12:49:59.1775 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qap9Qyg+GMWy8M2bIBi5emn6TAtv4lNBMhktfvaxhTfNgs2rLLt9WrJwNs0yjY+KpeGeaLuvdVUGr+BBbPA41w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB5287 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1 definitions=2022-10-06_02,2022-10-06_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 phishscore=0 bulkscore=0 suspectscore=0 mlxlogscore=999 mlxscore=0 spamscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000 definitions=main-2210060077 X-Proofpoint-GUID: YsfB1L0UGkVvEoOIaBKagopieUnLWRpy X-Proofpoint-ORIG-GUID: YsfB1L0UGkVvEoOIaBKagopieUnLWRpy X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > On Oct 5, 2022, at 4:25 PM, Joseph Myers wrote: >=20 > On Wed, 5 Oct 2022, Qing Zhao via Gcc-patches wrote: >=20 >> + /* if not the last field, return false. */ >=20 > Comments should start with an uppercase letter. >=20 >> + /* if not an array field, return false. */ >=20 >> + /* if there is a strict_flex_array attribute attached to the field, >> + override the flag_strict_flex_arrays. */ >=20 >> + /* get the value of the level first from the attribute. */ >=20 >> + /* the attribute has higher priority than flag_struct_flex_array.= */ >=20 >> + /* default, all trailing arrays are flexiable array members. */ >=20 > Likewise, and "flexible" not "flexiable". >=20 >> + /* whether this field is the last field of the structure or union= . >> + for UNION, any field is the last field of it. */ >=20 > Likewise. >=20 >> +field of a structure as a flexible array member for the purposesof acce= ssing >=20 > Missing space, should be "purposes of". Will fix all the above.=20 >=20 > The C front-end and docs changes are OK with the fixes above. Thanks a lot. So this patch is considered approved, I will commit it after the above fix = and one more round of testing. Let me know if you have more comment. Qing >=20 > --=20 > Joseph S. Myers > joseph@codesourcery.com