[PATCH][testsuite] Enable vect_usad_char effective target for non-SVE aarch64

[PATCH][testsuite] Enable vect_usad_char effective target for non-SVE aarch64

[Kyrill Tkachov]

[-- Attachment #1: Type: text/plain, Size: 737 bytes --]

Hi all,

In GCC 9 the aarch64 port learned how to do V16QImode SAD operations on signed and unsigned chars.
But I had missed enabling the effective target for that.
This patch enables that target for non-SVE aarch64.
Two new tests now PASS on aarch64:
gcc.dg/vect/slp-reduc-sad.c
gcc.dg/vect/vect-reduc-sad.c

Ok for trunk?

Thanks,
Kyrill

P.S. I notice that powerpc and mips also implement the necessary optabs.
Perhaps the maintainers would like to check that the tests above pass on their appropriate (sub)targets and
enable this effective target appropriately.

2018-12-18  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>

     * lib/target-supports.exp (check_effective_target_vect_usad_char):
     Add non-SVE aarch64 to supported list.

[-- Attachment #2: test-usad.patch --]
[-- Type: text/x-patch, Size: 696 bytes --]

diff --git a/gcc/testsuite/lib/target-supports.exp b/gcc/testsuite/lib/target-supports.exp
index 5026c5906cd..76779ff7d70 100644
--- a/gcc/testsuite/lib/target-supports.exp
+++ b/gcc/testsuite/lib/target-supports.exp
@@ -5925,7 +5925,10 @@ proc check_effective_target_vect_udot_hi { } {
 
 proc check_effective_target_vect_usad_char { } {
     return [check_cached_effective_target_indexed vect_usad_char {
-      expr { [istarget i?86-*-*] || [istarget x86_64-*-*] }}]
+      expr { [istarget i?86-*-*]
+	      || [istarget x86_64-*-*]
+	      || ([istarget aarch64*-*-*]
+		  && ![check_effective_target_aarch64_sve])}}]
 }
 
 # Return 1 if the target plus current options supports both signed

Re: [PATCH][testsuite] Enable vect_usad_char effective target for non-SVE aarch64

[Richard Biener]

On Tue, Dec 18, 2018 at 12:40 PM Kyrill Tkachov
<kyrylo.tkachov@foss.arm.com> wrote:
>
> Hi all,
>
> In GCC 9 the aarch64 port learned how to do V16QImode SAD operations on signed and unsigned chars.
> But I had missed enabling the effective target for that.
> This patch enables that target for non-SVE aarch64.
> Two new tests now PASS on aarch64:
> gcc.dg/vect/slp-reduc-sad.c
> gcc.dg/vect/vect-reduc-sad.c
>
> Ok for trunk?

OK.

> Thanks,
> Kyrill
>
> P.S. I notice that powerpc and mips also implement the necessary optabs.
> Perhaps the maintainers would like to check that the tests above pass on their appropriate (sub)targets and
> enable this effective target appropriately.
>
> 2018-12-18  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>
>
>      * lib/target-supports.exp (check_effective_target_vect_usad_char):
>      Add non-SVE aarch64 to supported list.