From: Kyrill Tkachov <kyrylo.tkachov@foss.arm.com>
To: Stefan Agner <stefan@agner.ch>,
"nickc@redhat.com" <nickc@redhat.com>,
Richard Earnshaw <Richard.Earnshaw@arm.com>,
Ramana Radhakrishnan <Ramana.Radhakrishnan@arm.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] ARM: fix -masm-syntax-unified (PR88648)
Date: Tue, 08 Jan 2019 09:36:00 -0000 [thread overview]
Message-ID: <5C346F03.6020503@foss.arm.com> (raw)
In-Reply-To: <5C346E5B.1060904@foss.arm.com>
On 08/01/19 09:33, Kyrill Tkachov wrote:
> Hi Stefan,
>
> On 01/01/19 23:34, Stefan Agner wrote:
> > This allows to use unified asm syntax when compiling for the
> > ARM instruction. This matches documentation and seems what the
> > initial patch was intended doing when the flag got added.
> > ---
> > gcc/config/arm/arm.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/gcc/config/arm/arm.c b/gcc/config/arm/arm.c
> > index 3419b6bd0f8..67b2b199f3f 100644
> > --- a/gcc/config/arm/arm.c
> > +++ b/gcc/config/arm/arm.c
> > @@ -3095,7 +3095,8 @@ arm_option_override_internal (struct gcc_options *opts,
> >
> > /* Thumb2 inline assembly code should always use unified syntax.
> > This will apply to ARM and Thumb1 eventually. */
> > - opts->x_inline_asm_unified = TARGET_THUMB2_P (opts->x_target_flags);
> > + if (TARGET_THUMB2_P (opts->x_target_flags))
> > + opts->x_inline_asm_unified = true;
>
> This looks right to me and is the logic we had in GCC 5.
> How has this patch been tested?
>
For the avoidance of doubt, I mean that your patch is correct :)
(not that the existing code is right).
> Can you please provide a ChangeLog entry for this patch[1].
>
> Thanks,
> Kyrill
>
> [1] https://gcc.gnu.org/contribute.html
>
> >
> > #ifdef SUBTARGET_OVERRIDE_INTERNAL_OPTIONS
> > SUBTARGET_OVERRIDE_INTERNAL_OPTIONS;
> > --
> > 2.20.1
> >
>
next prev parent reply other threads:[~2019-01-08 9:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-01 23:34 Stefan Agner
2019-01-08 9:33 ` Kyrill Tkachov
2019-01-08 9:36 ` Kyrill Tkachov [this message]
2019-01-10 11:38 ` Kyrill Tkachov
2019-02-09 16:25 ` Stefan Agner
2019-02-11 9:27 ` Kyrill Tkachov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5C346F03.6020503@foss.arm.com \
--to=kyrylo.tkachov@foss.arm.com \
--cc=Ramana.Radhakrishnan@arm.com \
--cc=Richard.Earnshaw@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=nickc@redhat.com \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).