From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 81340 invoked by alias); 8 Jan 2019 09:36:09 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 81322 invoked by uid 89); 8 Jan 2019 09:36:08 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY,KAM_SHORT autolearn=ham version=3.3.2 spammy=Hx-languages-length:1427 X-HELO: foss.arm.com Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 08 Jan 2019 09:36:06 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 96563EBD; Tue, 8 Jan 2019 01:36:05 -0800 (PST) Received: from [10.2.207.77] (e100706-lin.cambridge.arm.com [10.2.207.77]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9DAF63F5D4; Tue, 8 Jan 2019 01:36:04 -0800 (PST) Message-ID: <5C346F03.6020503@foss.arm.com> Date: Tue, 08 Jan 2019 09:36:00 -0000 From: Kyrill Tkachov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Stefan Agner , "nickc@redhat.com" , Richard Earnshaw , Ramana Radhakrishnan CC: "gcc-patches@gcc.gnu.org" Subject: Re: [PATCH] ARM: fix -masm-syntax-unified (PR88648) References: <5C346E5B.1060904@foss.arm.com> In-Reply-To: <5C346E5B.1060904@foss.arm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2019-01/txt/msg00375.txt.bz2 On 08/01/19 09:33, Kyrill Tkachov wrote: > Hi Stefan, > > On 01/01/19 23:34, Stefan Agner wrote: > > This allows to use unified asm syntax when compiling for the > > ARM instruction. This matches documentation and seems what the > > initial patch was intended doing when the flag got added. > > --- > > gcc/config/arm/arm.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/gcc/config/arm/arm.c b/gcc/config/arm/arm.c > > index 3419b6bd0f8..67b2b199f3f 100644 > > --- a/gcc/config/arm/arm.c > > +++ b/gcc/config/arm/arm.c > > @@ -3095,7 +3095,8 @@ arm_option_override_internal (struct gcc_options *opts, > > > > /* Thumb2 inline assembly code should always use unified syntax. > > This will apply to ARM and Thumb1 eventually. */ > > - opts->x_inline_asm_unified = TARGET_THUMB2_P (opts->x_target_flags); > > + if (TARGET_THUMB2_P (opts->x_target_flags)) > > + opts->x_inline_asm_unified = true; > > This looks right to me and is the logic we had in GCC 5. > How has this patch been tested? > For the avoidance of doubt, I mean that your patch is correct :) (not that the existing code is right). > Can you please provide a ChangeLog entry for this patch[1]. > > Thanks, > Kyrill > > [1] https://gcc.gnu.org/contribute.html > > > > > #ifdef SUBTARGET_OVERRIDE_INTERNAL_OPTIONS > > SUBTARGET_OVERRIDE_INTERNAL_OPTIONS; > > -- > > 2.20.1 > > >