From: Kyrill Tkachov <kyrylo.tkachov@foss.arm.com>
To: Tamar Christina <Tamar.Christina@arm.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Cc: nd <nd@arm.com>,
Ramana Radhakrishnan <Ramana.Radhakrishnan@arm.com>,
Richard Earnshaw <Richard.Earnshaw@arm.com>,
"nickc@redhat.com" <nickc@redhat.com>
Subject: Re: [PATCH][GCC][Arm] Fix arm big-endian intrinsics regressions.
Date: Wed, 16 Jan 2019 10:36:00 -0000 [thread overview]
Message-ID: <5C3F093F.8070807@foss.arm.com> (raw)
In-Reply-To: <20190115170523.GA21796@arm.com>
Hi Tamar,
On 15/01/19 17:05, Tamar Christina wrote:
> Hi All,
>
> We are a bit inconsistent when it comes to lane index endianness on Arm,
> we don't seem to always stick to the expected GCC vector extensions index
> endianness, for these tests since they are modelled as UNSPEC anyway just
> keep the indexes in Arm NEON order.
>
> There are other intrinsics that require an update, but for now these will
> fix the new ones.
>
> Bootstrapped Regtested on arm-none-Linux-gnueabihf and no issues.
> Cross compiled on armeb-none-eabi and regtested and no issues.
> Verified example by hand with execution tests and no issues.
>
> Ok for trunk?
>
Ok.
We should aim to make the lane-flipping consistent in the future.
Thanks,
Kyrill
> Thanks,
> Tamar
>
> gcc/ChangeLog:
>
> 2019-01-15 Tamar Christina <tamar.christina@arm.com>
>
> * config/arm/arm-protos.h (neon_vcmla_lane_prepare_operands): Remove patternmode.
> * config/arm/arm.c (neon_vcmla_lane_prepare_operands): Likewise.
> * config/arm/neon.md (neon_vcmla_lane<rot><mode>, neon_vcmla_laneq<rot><mode>,
> neon_vcmlaq_lane<rot><mode>): Remove endianness conversion.
>
> --
prev parent reply other threads:[~2019-01-16 10:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-15 17:05 Tamar Christina
2019-01-16 10:36 ` Kyrill Tkachov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5C3F093F.8070807@foss.arm.com \
--to=kyrylo.tkachov@foss.arm.com \
--cc=Ramana.Radhakrishnan@arm.com \
--cc=Richard.Earnshaw@arm.com \
--cc=Tamar.Christina@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=nd@arm.com \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).