From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 36385 invoked by alias); 15 May 2019 23:12:37 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 36376 invoked by uid 89); 15 May 2019 23:12:37 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.9 required=5.0 tests=BAYES_50,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=H*u:en-US, H*UA:en-US, H*c:ISO-8859-1, HX-Languages-Length:878 X-HELO: mail-ot1-f68.google.com Received: from mail-ot1-f68.google.com (HELO mail-ot1-f68.google.com) (209.85.210.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 15 May 2019 23:12:35 +0000 Received: by mail-ot1-f68.google.com with SMTP id r7so1671650otn.6 for ; Wed, 15 May 2019 16:12:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:date:from:reply-to:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-transfer-encoding; bh=W0bS7ItTM2KhsrsDvJ9Z4FhMz+8kFUOJ+GGX1EROgI0=; b=HkWic/5Qp964Ik57C2U6+FHZGD9QUuurpSkm2PM0BP6VzXKJdDcXweImtHod5/s4sT g04tc4RtFrFps60sMQ1h08oHNiBflByugDkEAg9p8fxoZMdUKGDqv2PMVNHLslOgSnsp QUg33E5man4URZsCi37c2xEyRwjTFsQWvc7Hji+/evnklOB3dRgURf0wgkUXETxqic0S j9rfeITbo3AGs4OYv1+5Vhuyq3hZuooBqKl2u6n/PetTluZIhdp7S1KmsnZqatHZwHHO zCAk5QsFpZkLe0roYmSnJUl0/eSp+2f39lxU7cQIkbgSKd+3BxQj9XTjsxu87q4iOLMx sufw== Return-Path: Received: from [192.168.2.42] (adsl-70-133-144-166.dsl.ablntx.sbcglobal.net. [70.133.144.166]) by smtp.gmail.com with ESMTPSA id 38sm1326022otv.3.2019.05.15.16.12.32 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 15 May 2019 16:12:33 -0700 (PDT) Message-ID: <5CDC9CDF.8070105@gmail.com> Date: Wed, 15 May 2019 23:12:00 -0000 From: Jacob Bachmeyer Reply-To: jcb62281@gmail.com User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.8.1.22) Gecko/20090807 MultiZilla/1.8.3.4e SeaMonkey/1.1.17 Mnenhy/0.7.6.0 MIME-Version: 1.0 To: "Maciej W. Rozycki" CC: "gcc-patches@gcc.gnu.org" , "dejagnu@gnu.org" , Pierre-Marie de Rodat , Arnaud Charlet , Eric Botcazou Subject: Re: [PATCH 2/3][GCC] GNAT/testsuite: Pass the `ada' option to target compilation References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2019-05/txt/msg00897.txt.bz2 Maciej W. Rozycki wrote: > [...] > --- > gcc/testsuite/lib/gnat.exp | 2 ++ > 1 file changed, 2 insertions(+) > > gcc-test-gnat-options-ada.diff > Index: gcc/gcc/testsuite/lib/gnat.exp > =================================================================== > --- gcc.orig/gcc/testsuite/lib/gnat.exp > +++ gcc/gcc/testsuite/lib/gnat.exp > @@ -167,6 +167,8 @@ proc gnat_target_compile { source dest t > set options [concat "additional_flags=$TOOL_OPTIONS" $options] > } > > + set options [concat "{ada}" $options] > + > return [target_compile $source $dest $type $options] > } > Your Tcl syntax looks suspicious to me. Is there a reason for "ada" to be in both double quotes and braces? Perhaps {lappend options ada} might be simpler? Is placing ada at the beginning of the list important? -- Jacob