Re: [4.8, testsuite] Correct backported fix to gcc.dg/vect/vect-33.c

[Richard Biener <rguenther@suse.de>]

On June 15, 2015 9:58:33 PM GMT+02:00, Bill Schmidt <wschmidt@linux.vnet.ibm.com> wrote:
>I just was reading the gcc mailing list and realized that changes to
>4.8
>now require release manager approval.  Adding Richard to the CC list
>for
>consideration.  Thanks!

OK.

Richard.

>Bill
>
>On Mon, 2015-06-15 at 14:54 -0500, Bill Schmidt wrote:
>> Hi,
>> 
>> When I backported support for unaligned vector load/store operations
>on
>> POWER8 to GCC 4.8, I fumbled the change for gcc.dg/vect/vect-33.c. 
>One
>> of the original tests was:
>> 
>> /* { dg-final { scan-tree-dump-times "Vectorizing an unaligned
>access" 0 "vect" } } */ 
>> 
>> which I modified to
>> 
>> /* { dg-final { scan-tree-dump-times "Vectorizing an unaligned
>access" 0 "vect" { target { ! vect_hw_misalign } } } } */
>> 
>> This caused the test to be skipped for architectures other than
>PowerPC,
>> which was a mistake.  The correct test should have been:
>> 
>> /* { dg-final { scan-tree-dump-times "Vectorizing an unaligned
>access" 0 "vect" { target { { ! powerpc*-*-* } || { ! vect_hw_misalign
>} } } } } */
>> 
>> which leaves things alone for other architectures.
>> 
>> Ok for 4.8?
>> 
>> Thanks,
>> Bill
>> 
>> 
>> 2015-06-15  Bill Schmidt  <wschmidt@linux.vnet.ibm.com>
>> 
>> 	* gcc.dg/vect/vect-33.c: Don't exclude "Vectorizing an unaligned
>> 	access" test for non-PowerPC arches.
>> 
>> 
>> Index: gcc/testsuite/gcc.dg/vect/vect-33.c
>> ===================================================================
>> --- gcc/testsuite/gcc.dg/vect/vect-33.c	(revision 224490)
>> +++ gcc/testsuite/gcc.dg/vect/vect-33.c	(working copy)
>> @@ -38,7 +38,7 @@ int main (void)
>> 
>> 
>>  /* { dg-final { scan-tree-dump-times "vectorized 1 loops" 1 "vect" 
>} } */
>> -/* { dg-final { scan-tree-dump-times "Vectorizing an unaligned
>access" 0 "vect" { target { ! vect_hw_misalign } } } } */
>> +/* { dg-final { scan-tree-dump-times "Vectorizing an unaligned
>access" 0 "vect" { target { { ! powerpc*-*-* } || { ! vect_hw_misalign
>} } } } } */
>>  /* { dg-final { scan-tree-dump "Alignment of access forced using
>peeling" "vect" { target vector_alignment_reachable } } } */
>>  /* { dg-final { scan-tree-dump-times "Alignment of access forced
>using versioning" 1 "vect" { target { {! vector_alignment_reachable} &&
>{! vect_hw_misalign} } } } } */
>>  /* { dg-final { cleanup-tree-dump "vect" } } */
>> 
>>