From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 60452 invoked by alias); 7 Nov 2019 17:05:29 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 60369 invoked by uid 89); 7 Nov 2019 17:05:28 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,FORGED_SPF_HELO,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_WEB,SPF_HELO_PASS autolearn=no version=3.3.1 spammy=HX-Languages-Length:2700 X-HELO: NAM01-BN3-obe.outbound.protection.outlook.com Received: from mail-eopbgr740109.outbound.protection.outlook.com (HELO NAM01-BN3-obe.outbound.protection.outlook.com) (40.107.74.109) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 07 Nov 2019 17:05:26 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oDOcWMy2TesKJgkDbANMpSr/l2XeskA4l6M/TwuVooGYMjgKTmpAJeIZX3vQ80MZYkjSIAesqoQE/ZFsu9Vr+N//5rJ5BFRk7ZkRAEqot5Qb+HV7ULPy09BTkA3L1o11NBpaWLHs3Lat/SnnVse72P4ADBflgEPPr4eFS+OUTWpLfnozVii/67jlKVDlkLQKq1MXBBH8advhi6WDrD9vhHRBjOTDHrmhQcxZ5O4bWCkacEYD5jF7VG6BC/ZHMqvs1IgqiroeeH5rl4P3+qT7bou9z2miLP3Z+Q9Xnk2vkaG7MVX8d7XVFsz5PreM/dTlwIrwQ5nhyIf0eSxF0RZ9DQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=J86sH4zvWZHsAf9TDqNzek/+ziXdazTbptVGatSHzyE=; b=da0LsQ0jnQA1Fk09w3p8YeDAXHz8vGEm47Gw1Oet0S4IbaTJlcItzJLrXHYtQn0Pew3Cp9EWzr2gjKhsqKELFNXv66oJ2qIrF9yMSIL6+EHvUUhpsxkmltheQFFpTOFfI09TytQ7JQZ1B5D5oeYdqtnWuG9inGgM2sGL6uZtfalEVljDu0CqAC9+uy1Ioytb9lb4eYAmh2FCCDfGWWkjWix6ZYco0CTGs5Qn1GEZv7ixp3J5T9L5czsnFjYSqjs/1hKlhgAQuXWIXT/8jhaMbX7uGUKLsA4tp4aUdCF1fA54LzYzryOA1mS5Ul1YlYSXBlWy6SYVWXwUm523TEC1gQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=wavecomp.com; dmarc=pass action=none header.from=wavecomp.com; dkim=pass header.d=wavecomp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wavecomp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=J86sH4zvWZHsAf9TDqNzek/+ziXdazTbptVGatSHzyE=; b=E9E/L2lwGwN0Xlq1OxX+GwV92G0jxXFEwvrNy3yJfbqAKoYJ95y5HTLG7ppaBoOfoxsa1piTP9GKqbJxJWdeYcY3F4Wp87arnpmPdRZZ7q7UldTU4nlU9CRH3/zG8/lwKbPfc70WJGTb56URNaUT8ywszfK9Nj+7UZW+7L+3Wb0= Received: from BN6PR2201MB1075.namprd22.prod.outlook.com (10.174.91.24) by BN6PR2201MB1444.namprd22.prod.outlook.com (10.174.85.165) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2430.22; Thu, 7 Nov 2019 17:05:24 +0000 Received: from BN6PR2201MB1075.namprd22.prod.outlook.com ([fe80::c970:510b:bb78:9efa]) by BN6PR2201MB1075.namprd22.prod.outlook.com ([fe80::c970:510b:bb78:9efa%5]) with mapi id 15.20.2430.023; Thu, 7 Nov 2019 17:05:24 +0000 From: Dragan Mladjenovic To: Joseph Myers , Jeff Law CC: "gcc-patches@gcc.gnu.org" , Jakub Jelinek , Matthew Fortune , "Maciej W . Rozycki" , Faraz Shahbazker , Aurelien Jarno Subject: Re: [PATCH 2/2][MIPS][RFC] Emit .note.GNU-stack for hard-float linux targets. Date: Thu, 07 Nov 2019 17:05:00 -0000 Message-ID: <5DC44EC5.1010805@wavecomp.com> References: <1565001657-5145-1-git-send-email-dmladjenovic@wavecomp.com> <1565002149-5397-1-git-send-email-dmladjenovic@wavecomp.com> <0da5c1c6-3146-9981-2c86-733a20e3140e@redhat.com> <5DBC09B1.7070305@wavecomp.com> In-Reply-To: <5DBC09B1.7070305@wavecomp.com> authentication-results: spf=none (sender IP is ) smtp.mailfrom=dmladjenovic@wavecomp.com; x-ms-exchange-purlcount: 2 x-ms-exchange-transport-forked: True x-ms-oob-tlc-oobclassifiers: OLM:10000; received-spf: None (protection.outlook.com: wavecomp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 Content-Type: text/plain; charset="Windows-1252" Content-ID: <07581E10E60A184595D22D5ED50651BB@namprd22.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 2XXfpBsjih0UJ3Z/zulxDKQORxPYj/dXH3D6HwjlQuUAqGZei+OoXjWe0fI5kubV/gqV3+Nu/fbEH+qYVpr+kTY6mEs4lTkLgCtE/q+UbUY= X-SW-Source: 2019-11/txt/msg00528.txt.bz2 On 01.11.2019. 11:32, Dragan Mladjenovic wrote: > On 10.08.2019. 00:15, Joseph Myers wrote: >> On Fri, 9 Aug 2019, Jeff Law wrote: >> >>>> 2019-08-05 Dragan Mladjenovic >>>> >>>> * config.in: Regenerated. >>>> * config/mips/linux.h (NEED_INDICATE_EXEC_STACK): Define to 1 >>>> for TARGET_LIBC_GNUSTACK. >>>> * configure: Regenerated. >>>> * configure.ac: Define TARGET_LIBC_GNUSTACK if glibc version is >>>> found 2.31 or greater. >>> My only concern here is the configure bits. So for example, will it do >>> the right thing if you're cross-compiling to a MIPS linux target? If >>> so, how? If not, do we need to make it a first class configure option >>> so that it can be specified when building cross MIPS linux toolchains? >> >> The key point of using GCC_GLIBC_VERSION_GTE_IFELSE is that (a) it checks >> the target glibc headers if available when GCC is built and (b) if not >> available, you can still use --with-glibc-version when configuring >> GCC, to >> get the right configuration in a bootstrap compiler built before glibc is >> built (the latter is necessary on some architectures to get the right >> stack-protector configuration for bootstrapping glibc, but may be useful >> in other cases as well). >> >> My main concern about this patch is the one I gave in >> about what >> the configuration mechanism should be, on a whole-toolchain level, to say >> whether you are OK with a requirement for a 4.8 or later kernel. >> > > Sorry for the late reply. > > I was waiting to backport [1] to most of the glibc release branches in > use, but I got sidetracked along the way. > > After this patch lands the preferred way to configure gcc would be using > --with-glibc-version=3D2.31 and to use said glibc. > If the user/distribution can live with minimal kernel requirement of 4.8 > the glibc used should be configured with --enable-kernel=3D4.8. > I also plan to backport the [1] to limit the opportunity for building > the possibly broken glibc with the gcc w/ enabled .note.GNU-stack. > > This is all tedious and user has to be aware of all of it to make it > work, but hopefully over time the distributions will default to > --with-glibc-version=3D2.31 and --enable-kernel=3D4.8. I guess providing = the > detailed NEWS entry for this change would help a bit. > > Is there any objections to getting this on the trunk before the end of > stage1? > > [1] https://sourceware.org/ml/libc-alpha/2019-08/msg00639.html > Small update and gentle ping. The glibc change was backported all the=20 way back to 2.24. Best regards, Dragan