public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Dragan Mladjenovic <dmladjenovic@wavecomp.com>
To: Tobias Burnus <tobias@codesourcery.com>
Cc: Richard Biener <rguenther@suse.de>,
	"law@redhat.com" <law@redhat.com>,
	Joseph Myers <joseph@codesourcery.com>,
	"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
	Jakub Jelinek <jakub@redhat.com>,
	Matthew Fortune <mfortune@gmail.com>,
	"Maciej W . Rozycki" <macro@linux-mips.org>,
	Faraz Shahbazker <fshahbazker@wavecomp.com>,
	Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [PATCH 2/2][MIPS][RFC] Emit .note.GNU-stack for hard-float linux targets.
Date: Thu, 30 Jan 2020 09:20:00 -0000	[thread overview]
Message-ID: <5E329229.8030401@wavecomp.com> (raw)
In-Reply-To: <5E31FFD7.9020301@wavecomp.com>

On 29.01.2020. 22:57, Dragan Mladjenovic wrote:
>
> On 29.01.2020. 12:06, Tobias Burnus wrote:
>> Hi Dragan,
>>
>> I think your committed patch was incomplete – at least I see the
>> following bits when running --enable-maintainer-mode (see attachment,
>> line numbers wrong as I edited my changes out).
>>
>> Can you re-check?
>>
>> (The other change in gcc/configure seems to be due to Andrew Burgess's
>> e7c26e04b2dd6266d62d5a5825ff7eb44d1cf14e )
>>
>> Tobias
>>
>> PS: The following was committed as
>> 54b3d52c3cca836c7c4c08cc9c02eda6c096372a
>>
>> On 1/23/20 11:58 AM, Dragan Mladjenovic wrote: […]
>>>>>>>>> 2019-08-05  Dragan Mladjenovic  <dmladjenovic@wavecomp.com>
>>>>>>>>>
>>>>>>>>>       * config.in: Regenerated.
>>>>>>>>>       * config/mips/linux.h (NEED_INDICATE_EXEC_STACK): Define
>>>>>>>>> to 1
>>>>>>>>>       for TARGET_LIBC_GNUSTACK.
>>>>>>>>>       * configure: Regenerated.
>>>>>>>>>       * configure.ac: Define TARGET_LIBC_GNUSTACK if glibc
>>>>>>>>> version is
>>>>>>>>>       found 2.31 or greater.
>
> Thank you for letting me know.
>
> Your change looks fine. How should I handle this? Do I just commit the
> portion related to my change or perhaps you wish to commit everything
> altogether?

Ok, I now see that that e7c26e04b2dd6266d62d5a5825ff7eb44d1cf14e 
mentions that files will be regenerated later. So I went ahead and
committed this as e0332517f900c7947f03c15fd27e7f71ace98629.

Best regards,
Dragan

  reply	other threads:[~2020-01-30  8:22 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-05 10:43 [PATCH 0/2] [MIPS] Emit .note.GNU-stack for " Dragan Mladjenovic
2019-08-05 10:48 ` [PATCH 1/2][MIPS] Emit .note.GNU-stack for soft-float " Dragan Mladjenovic
2019-08-09 21:36   ` Jeff Law
2019-08-12 16:34     ` [EXTERNAL]Re: " Dragan Mladjenovic
2019-08-20  7:26       ` Jeff Law
2019-08-05 10:49 ` [PATCH 2/2][MIPS][RFC] Emit .note.GNU-stack for hard-float " Dragan Mladjenovic
2019-08-09 21:38   ` Jeff Law
2019-08-09 23:13     ` Joseph Myers
2019-11-01 10:32       ` Dragan Mladjenovic
2019-11-07 17:05         ` Dragan Mladjenovic
2019-11-27 18:59           ` [PING] " Dragan Mladjenovic
2019-12-07 18:33           ` Jeff Law
2020-01-23 11:14             ` Dragan Mladjenovic
2020-01-23 15:22               ` Jeff Law
2020-01-29 12:20               ` Tobias Burnus
2020-01-30  0:14                 ` [EXTERNAL]Re: " Dragan Mladjenovic
2020-01-30  9:20                   ` Dragan Mladjenovic [this message]
2019-08-09 22:03   ` Maciej W. Rozycki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5E329229.8030401@wavecomp.com \
    --to=dmladjenovic@wavecomp.com \
    --cc=aurelien@aurel32.net \
    --cc=fshahbazker@wavecomp.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jakub@redhat.com \
    --cc=joseph@codesourcery.com \
    --cc=law@redhat.com \
    --cc=macro@linux-mips.org \
    --cc=mfortune@gmail.com \
    --cc=rguenther@suse.de \
    --cc=tobias@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).