From: Mike Stump <mikestump@comcast.net>
To: Daniel Santos <daniel.santos@pobox.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>,
Anthony Green <green@moxielogic.com>,
Richard Henderson <rth@twiddle.net>,
Gerald Pfeifer <gerald@pfeifer.com>
Subject: Re: [testsuite] Fix loading wrong DLLs on Windows, merge duplicate target-libpath.exp
Date: Wed, 05 Apr 2017 17:35:00 -0000 [thread overview]
Message-ID: <5EC0CA7D-495B-40B4-BCB5-A250112920A4@comcast.net> (raw)
In-Reply-To: <20170403231430.17602-1-daniel.santos@pobox.com>
On Apr 3, 2017, at 4:14 PM, Daniel Santos <daniel.santos@pobox.com> wrote:
>
> We currently have two copies of target-libpath.exp in the tree under
> gcc/testsuite/lib and libffi/testsuite/lib. It was originally pulled
> into the libffi project from downstream gcc in 2009
> (https://github.com/libffi/libffi/commit/5cbe2058c128e848446ae79fe15ee54260a90559).
> Then in 2012, Anthony Green (from libffi) modified it to correct this
> Windows problem (thank you!
> https://github.com/libffi/libffi/commit/bd78c9c3311244dd5f877c915b0dff91621dd253).
> In 2015, this file got pulled from upstream libffi back into gcc, thus
> beginning two separate development paths
> (https://github.com/gcc-mirror/gcc/commit/89d8a412de548b218cf7c967e65ad98bceb1ed4e).
>
> This patch merges the changes from libffi upstream which correctly solve
> the Windows DLL load path problem and removes the duplicate from
> libffi/testsuite/lib. This fixes most of bug #79867, implementing
> correct behaviour for set_ld_library_path_env_vars and
> restore_ld_library_path_env_vars. However, there is still incorrect
> behaviour in DejaGNU's unix_load that should eventually be adddressed,
> although I cannot yet point to a specific failure that it is causing.
>
> gcc/ChangeLog:
> 2017-04-03 Daniel Santos <daniel.santos@pobox.com>
>
> PR testsuite/79867
> * testsuite/lib/target-libpath.exp (set_ld_library_path_env_vars,
> restore_ld_library_path_env_vars): Merge changes from libffi upstream,
> correcting DLL load path problems on Windows.
These are Ok.
> libffi/ChangeLog:
> 2017-04-03 Daniel Santos <daniel.santos@pobox.com>
>
> PR testsuite/79867
> * testsuite/lib/target-libpath.exp: Remove.
> * testsuite/Makefile.in: Remove target-libpath.exp.
> * testsuite/Makefile.am: Regenerated.
I don't think the libffi project wants to remove that file. There is little point being different from them in this regard. The dup should not hurt.
https://gcc.gnu.org/codingconventions.html seems like it should be updated to list libffi. Not sure why it wasn't. I just point it out if someone wants to contribute a patch for it.
next prev parent reply other threads:[~2017-04-05 17:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-03 23:10 Daniel Santos
2017-04-03 23:28 ` [PATCH, testsuite] PR79867: " Daniel Santos
2017-04-05 17:35 ` Mike Stump [this message]
2017-04-05 21:41 ` [testsuite] " Daniel Santos
2017-04-06 22:35 ` [PATCH v2,testsuite] PR79867: Merge fixes for windows DLL loading problem from libffi Daniel Santos
2017-04-10 17:46 ` Mike Stump
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5EC0CA7D-495B-40B4-BCB5-A250112920A4@comcast.net \
--to=mikestump@comcast.net \
--cc=daniel.santos@pobox.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gerald@pfeifer.com \
--cc=green@moxielogic.com \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).