From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 115042 invoked by alias); 5 Apr 2017 17:35:44 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 115023 invoked by uid 89); 5 Apr 2017 17:35:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=HTo:D*pobox.com, you! X-HELO: resqmta-po-10v.sys.comcast.net Received: from resqmta-po-10v.sys.comcast.net (HELO resqmta-po-10v.sys.comcast.net) (96.114.154.169) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 05 Apr 2017 17:35:41 +0000 Received: from resomta-po-06v.sys.comcast.net ([96.114.154.230]) by resqmta-po-10v.sys.comcast.net with SMTP id voq0ckYfciWLuvoqKcr4EE; Wed, 05 Apr 2017 17:35:40 +0000 Received: from up.mrs.kithrup.com ([24.4.193.248]) by resomta-po-06v.sys.comcast.net with SMTP id voqJcK40fufs1voqKcOBcp; Wed, 05 Apr 2017 17:35:40 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: [testsuite] Fix loading wrong DLLs on Windows, merge duplicate target-libpath.exp From: Mike Stump In-Reply-To: <20170403231430.17602-1-daniel.santos@pobox.com> Date: Wed, 05 Apr 2017 17:35:00 -0000 Cc: gcc-patches , Anthony Green , Richard Henderson , Gerald Pfeifer Content-Transfer-Encoding: quoted-printable Message-Id: <5EC0CA7D-495B-40B4-BCB5-A250112920A4@comcast.net> References: <20170403231430.17602-1-daniel.santos@pobox.com> To: Daniel Santos X-CMAE-Envelope: MS4wfO3Lt1U9X+43iIUbFMy+qaVTL6SzjOrTRbRIj8ooQ0puZA5oDRf5l4+gHXJtM9AxMgv/aPG6NkAxqzK+gD3FDDf9Ps/eFoiyS/dqm89w2MDs+cs4jxKf IyKpIMaIYojtfxCy0u5FKKoLS4I+ohJsnbYWrIfGcpHFSiD5U/ZSD4c0S3pz5P84T30WxZvc4zFhAqiBH3kpPPaTvyMf9HbcVhy2gdNN4TUX2ppTs1zJF1Xu Bxy0e95VCOzutrDIqCeSvoOoIcgGvF06yxs5U6oZDSlCc8Q+cd0C8fCfgqyAnTLBdQpwFNmlaBfeOyu7LyhnAQ== X-IsSubscribed: yes X-SW-Source: 2017-04/txt/msg00242.txt.bz2 On Apr 3, 2017, at 4:14 PM, Daniel Santos wrote: >=20 > We currently have two copies of target-libpath.exp in the tree under > gcc/testsuite/lib and libffi/testsuite/lib. It was originally pulled > into the libffi project from downstream gcc in 2009 > (https://github.com/libffi/libffi/commit/5cbe2058c128e848446ae79fe15ee542= 60a90559). > Then in 2012, Anthony Green (from libffi) modified it to correct this > Windows problem (thank you! > https://github.com/libffi/libffi/commit/bd78c9c3311244dd5f877c915b0dff916= 21dd253). > In 2015, this file got pulled from upstream libffi back into gcc, thus > beginning two separate development paths > (https://github.com/gcc-mirror/gcc/commit/89d8a412de548b218cf7c967e65ad98= bceb1ed4e). >=20 > This patch merges the changes from libffi upstream which correctly solve > the Windows DLL load path problem and removes the duplicate from > libffi/testsuite/lib. This fixes most of bug #79867, implementing > correct behaviour for set_ld_library_path_env_vars and > restore_ld_library_path_env_vars. However, there is still incorrect > behaviour in DejaGNU's unix_load that should eventually be adddressed, > although I cannot yet point to a specific failure that it is causing. >=20 > gcc/ChangeLog: > 2017-04-03 Daniel Santos >=20 > PR testsuite/79867 > * testsuite/lib/target-libpath.exp (set_ld_library_path_env_vars, > restore_ld_library_path_env_vars): Merge changes from libffi upstream, > correcting DLL load path problems on Windows. These are Ok. > libffi/ChangeLog: > 2017-04-03 Daniel Santos >=20 > PR testsuite/79867 > * testsuite/lib/target-libpath.exp: Remove. > * testsuite/Makefile.in: Remove target-libpath.exp. > * testsuite/Makefile.am: Regenerated. I don't think the libffi project wants to remove that file. There is littl= e point being different from them in this regard. The dup should not hurt. https://gcc.gnu.org/codingconventions.html seems like it should be updated = to list libffi. Not sure why it wasn't. I just point it out if someone wa= nts to contribute a patch for it.