* [testsuite, objc] Don't XFAIL objc.dg/torture/forward-1.m
@ 2011-06-28 17:21 Rainer Orth
2011-06-28 17:42 ` Iain Sandoe
0 siblings, 1 reply; 4+ messages in thread
From: Rainer Orth @ 2011-06-28 17:21 UTC (permalink / raw)
To: gcc-patches; +Cc: Mike Stump, Nicola Pero
objc.dg/torture/forward-1.m now seems to XPASS everywhere, creating an
annoying amount of testsuite noise. Dominique provided the following
patch in PR libobjc/Bug 36610.
Tested with the appropriate runtest invocations on i386-pc-solaris2.10
(both multilibs), sparc-sun-solaris2.10 (both multilibs),
alpha-dec-osf5.1b, mips-sgi-irix6.5 (both multilibs),
powerpc-apple-darwin9.8.0 (32-bit only).
Ok for mainline?
Thanks.
Rainer
2011-06-28 Dominique d'Humieres <dominiq@lps.ens.fr>
* objc.dg/torture/forward-1.m: Remove dg-xfail-run-if, dg-skip-if.
Index: gcc/testsuite/objc.dg/torture/forward-1.m
===================================================================
--- gcc/testsuite/objc.dg/torture/forward-1.m (revision 175589)
+++ gcc/testsuite/objc.dg/torture/forward-1.m (working copy)
@@ -1,7 +1,5 @@
/* { dg-do run } */
/* See if -forward:: is able to work. */
-/* { dg-xfail-run-if "PR36610" { ! { { i?86-*-* x86_64-*-* } && ilp32 } } { "-fgnu-runtime" } { "" } } */
-/* { dg-skip-if "Needs OBJC2 Implementation" { *-*-darwin* && { lp64 } } { "-fnext-runtime" } { "" } } */
#include <stdio.h>
#include <stdlib.h>
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [testsuite, objc] Don't XFAIL objc.dg/torture/forward-1.m
2011-06-28 17:21 [testsuite, objc] Don't XFAIL objc.dg/torture/forward-1.m Rainer Orth
@ 2011-06-28 17:42 ` Iain Sandoe
2011-06-29 8:45 ` Iain Sandoe
0 siblings, 1 reply; 4+ messages in thread
From: Iain Sandoe @ 2011-06-28 17:42 UTC (permalink / raw)
To: Rainer Orth; +Cc: gcc-patches, Mike Stump, Nicola Pero
On 28 Jun 2011, at 17:47, Rainer Orth wrote:
> objc.dg/torture/forward-1.m now seems to XPASS everywhere, creating an
> annoying amount of testsuite noise. Dominique provided the following
> patch in PR libobjc/Bug 36610.
>
> Tested with the appropriate runtest invocations on i386-pc-solaris2.10
> (both multilibs), sparc-sun-solaris2.10 (both multilibs),
> alpha-dec-osf5.1b, mips-sgi-irix6.5 (both multilibs),
> powerpc-apple-darwin9.8.0 (32-bit only).
>
> Ok for mainline?
>
> Thanks.
> Rainer
>
>
> 2011-06-28 Dominique d'Humieres <dominiq@lps.ens.fr>
>
> * objc.dg/torture/forward-1.m: Remove dg-xfail-run-if, dg-skip-if.
>
> Index: gcc/testsuite/objc.dg/torture/forward-1.m
> ===================================================================
> --- gcc/testsuite/objc.dg/torture/forward-1.m (revision 175589)
> +++ gcc/testsuite/objc.dg/torture/forward-1.m (working copy)
> @@ -1,7 +1,5 @@
> /* { dg-do run } */
> /* See if -forward:: is able to work. */
> -/* { dg-xfail-run-if "PR36610" { ! { { i?86-*-* x86_64-*-* } &&
> ilp32 } } { "-fgnu-runtime" } { "" } } */
> -/* { dg-skip-if "Needs OBJC2 Implementation" { *-*-darwin* &&
> { lp64 } } { "-fnext-runtime" } { "" } } */
actually, looking at this, it should likely read (untested):
/* { dg-skip-if "Needs OBJC2 Implementation" { *-*-darwin8* && { lp64
&& { ! objc2 } } } { "-fnext-runtime" } { "" } } */
and should stay in place to protect the test-cases for m64 on *-*-
darwin8*
(not that there's ever likely to be an m64 objc2 on darwin 8.. but)
Iain
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [testsuite, objc] Don't XFAIL objc.dg/torture/forward-1.m
2011-06-28 17:42 ` Iain Sandoe
@ 2011-06-29 8:45 ` Iain Sandoe
2011-06-29 23:16 ` Mike Stump
0 siblings, 1 reply; 4+ messages in thread
From: Iain Sandoe @ 2011-06-29 8:45 UTC (permalink / raw)
To: Rainer Orth; +Cc: GCC Patches, Mike Stump, Nicola Pero
On 28 Jun 2011, at 18:01, Iain Sandoe wrote:
> On 28 Jun 2011, at 17:47, Rainer Orth wrote:
>
>> objc.dg/torture/forward-1.m now seems to XPASS everywhere, creating
>> an
>> annoying amount of testsuite noise. Dominique provided the following
>> patch in PR libobjc/Bug 36610.
>>
>> Tested with the appropriate runtest invocations on i386-pc-
>> solaris2.10
>> (both multilibs), sparc-sun-solaris2.10 (both multilibs),
>> alpha-dec-osf5.1b, mips-sgi-irix6.5 (both multilibs),
>> powerpc-apple-darwin9.8.0 (32-bit only).
>>
>> Ok for mainline?
>>
>> Thanks.
>> Rainer
>>
>>
>> 2011-06-28 Dominique d'Humieres <dominiq@lps.ens.fr>
>>
>> * objc.dg/torture/forward-1.m: Remove dg-xfail-run-if, dg-skip-if.
>>
>> Index: gcc/testsuite/objc.dg/torture/forward-1.m
>> ===================================================================
>> --- gcc/testsuite/objc.dg/torture/forward-1.m (revision 175589)
>> +++ gcc/testsuite/objc.dg/torture/forward-1.m (working copy)
>> @@ -1,7 +1,5 @@
>> /* { dg-do run } */
>> /* See if -forward:: is able to work. */
>> -/* { dg-xfail-run-if "PR36610" { ! { { i?86-*-* x86_64-*-* } &&
>> ilp32 } } { "-fgnu-runtime" } { "" } } */
>
>> -/* { dg-skip-if "Needs OBJC2 Implementation" { *-*-darwin* &&
>> { lp64 } } { "-fnext-runtime" } { "" } } */
>
> actually, looking at this, it should likely read (untested):
>
> /* { dg-skip-if "Needs OBJC2 Implementation" { *-*-darwin8* &&
> { lp64 && { ! objc2 } } } { "-fnext-runtime" } { "" } } */
>
> and should stay in place to protect the test-cases for m64 on *-*-
> darwin8*
>
> (not that there's ever likely to be an m64 objc2 on darwin 8.. but)
Just FTR, this works for me on powerpc-apple-darwin9
Iain
Index: gcc/testsuite/objc.dg/torture/forward-1.m
===================================================================
--- gcc/testsuite/objc.dg/torture/forward-1.m (revision 175578)
+++ gcc/testsuite/objc.dg/torture/forward-1.m (working copy)
@@ -1,7 +1,6 @@
/* { dg-do run } */
/* See if -forward:: is able to work. */
-/* { dg-xfail-run-if "PR36610" { ! { { i?86-*-* x86_64-*-* } &&
ilp32 } } { "-fgnu-runtime" } { "" } } */
-/* { dg-skip-if "Needs OBJC2 Implementation" { *-*-darwin* &&
{ lp64 } } { "-fnext-runtime" } { "" } } */
+/* { dg-skip-if "Needs OBJC2 Implementation" { *-*-darwin8* && { lp64
&& { ! objc2 } } } { "-fnext-runtime" } { "" } } */
#include <stdio.h>
#include <stdlib.h>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [testsuite, objc] Don't XFAIL objc.dg/torture/forward-1.m
2011-06-29 8:45 ` Iain Sandoe
@ 2011-06-29 23:16 ` Mike Stump
0 siblings, 0 replies; 4+ messages in thread
From: Mike Stump @ 2011-06-29 23:16 UTC (permalink / raw)
To: Rainer Orth; +Cc: GCC Patches, Nicola Pero, Iain Sandoe
On Jun 29, 2011, at 1:37 AM, Iain Sandoe wrote:
> On 28 Jun 2011, at 18:01, Iain Sandoe wrote:
>> On 28 Jun 2011, at 17:47, Rainer Orth wrote:
>>> objc.dg/torture/forward-1.m now seems to XPASS everywhere, creating an
>>> annoying amount of testsuite noise. Dominique provided the following
>>> patch in PR libobjc/Bug 36610.
>>>
>>> Tested with the appropriate runtest invocations on i386-pc-solaris2.10
>>> (both multilibs), sparc-sun-solaris2.10 (both multilibs),
>>> alpha-dec-osf5.1b, mips-sgi-irix6.5 (both multilibs),
>>> powerpc-apple-darwin9.8.0 (32-bit only).
>>>
>>> Ok for mainline?
>>>
>>> Thanks.
>>> Rainer
>>>
>>>
>>> 2011-06-28 Dominique d'Humieres <dominiq@lps.ens.fr>
>>>
>>> * objc.dg/torture/forward-1.m: Remove dg-xfail-run-if, dg-skip-if.
>>>
>>> Index: gcc/testsuite/objc.dg/torture/forward-1.m
>>> ===================================================================
>>> --- gcc/testsuite/objc.dg/torture/forward-1.m (revision 175589)
>>> +++ gcc/testsuite/objc.dg/torture/forward-1.m (working copy)
>>> @@ -1,7 +1,5 @@
>>> /* { dg-do run } */
>>> /* See if -forward:: is able to work. */
>>> -/* { dg-xfail-run-if "PR36610" { ! { { i?86-*-* x86_64-*-* } && ilp32 } } { "-fgnu-runtime" } { "" } } */
>>
>>> -/* { dg-skip-if "Needs OBJC2 Implementation" { *-*-darwin* && { lp64 } } { "-fnext-runtime" } { "" } } */
>>
>> actually, looking at this, it should likely read (untested):
>>
>> /* { dg-skip-if "Needs OBJC2 Implementation" { *-*-darwin8* && { lp64 && { ! objc2 } } } { "-fnext-runtime" } { "" } } */
>>
>> and should stay in place to protect the test-cases for m64 on *-*-darwin8*
>>
>> (not that there's ever likely to be an m64 objc2 on darwin 8.. but)
>
> Just FTR, this works for me on powerpc-apple-darwin9
> Iain
>
> Index: gcc/testsuite/objc.dg/torture/forward-1.m
> ===================================================================
> --- gcc/testsuite/objc.dg/torture/forward-1.m (revision 175578)
> +++ gcc/testsuite/objc.dg/torture/forward-1.m (working copy)
> @@ -1,7 +1,6 @@
> /* { dg-do run } */
> /* See if -forward:: is able to work. */
> -/* { dg-xfail-run-if "PR36610" { ! { { i?86-*-* x86_64-*-* } && ilp32 } } { "-fgnu-runtime" } { "" } } */
> -/* { dg-skip-if "Needs OBJC2 Implementation" { *-*-darwin* && { lp64 } } { "-fnext-runtime" } { "" } } */
> +/* { dg-skip-if "Needs OBJC2 Implementation" { *-*-darwin8* && { lp64 && { ! objc2 } } } { "-fnext-runtime" } { "" } } */
>
> #include <stdio.h>
> #include <stdlib.h>
That means, you can check it in, Iain is my testsuite expert. :-)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-06-29 22:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-06-28 17:21 [testsuite, objc] Don't XFAIL objc.dg/torture/forward-1.m Rainer Orth
2011-06-28 17:42 ` Iain Sandoe
2011-06-29 8:45 ` Iain Sandoe
2011-06-29 23:16 ` Mike Stump
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).