From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17213 invoked by alias); 20 Feb 2018 13:23:14 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 16199 invoked by uid 89); 20 Feb 2018 13:23:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-11.9 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=Hx-languages-length:2790 X-HELO: mx2.suse.de Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 20 Feb 2018 13:23:13 +0000 Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id C9974ACE9; Tue, 20 Feb 2018 13:23:10 +0000 (UTC) Date: Tue, 20 Feb 2018 13:23:00 -0000 User-Agent: K-9 Mail for Android In-Reply-To: <20180219220250.GX5867@tucnak> References: <20180219220250.GX5867@tucnak> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH] Defer pow (C, x) folding until after vectorization always (PR middle-end/82004) To: Jakub Jelinek CC: gcc-patches@gcc.gnu.org From: Richard Biener Message-ID: <5FD66E62-AB43-4504-8907-F0ABB4EBF5A3@suse.de> X-SW-Source: 2018-02/txt/msg01162.txt.bz2 On February 19, 2018 11:02:50 PM GMT+01:00, Jakub Jelinek wrote: >Hi! > >While I've over-simplified the testcase and so this patch doesn't help >the 628.pop2_s miscompare, I still believe it is beneficial to defer >this >folding until late for these reasons: >1) if we propagate a constant into the second pow argument too, it will > be likely more precise than going through the exp (cst * x) way >2) except when C is M_E, pow is fewer operations and thus smaller IL > >Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? OK.=20 Richard.=20 >2018-02-19 Jakub Jelinek > > PR middle-end/82004 > * match.pd (pow(C,x) -> exp(log(C)*x)): Delay all folding until > after vectorization. > > * gfortran.dg/pr82004.f90: New test. > >--- gcc/match.pd.jj 2018-02-15 12:15:51.655780636 +0100 >+++ gcc/match.pd 2018-02-19 17:38:06.390763194 +0100 >@@ -4006,7 +4006,14 @@ DEFINE_INT_AND_FLOAT_ROUND_FN (RINT) > (simplify > (pows REAL_CST@0 @1) > (if (real_compare (GT_EXPR, TREE_REAL_CST_PTR (@0), &dconst0) >- && real_isfinite (TREE_REAL_CST_PTR (@0))) >+ && real_isfinite (TREE_REAL_CST_PTR (@0)) >+ /* As libmvec doesn't have a vectorized exp2, defer optimizing >+ the use_exp2 case until after vectorization. It seems actually >+ beneficial for all constants to postpone this until later, >+ because exp(log(C)*x), while faster, will have worse precision >+ and if x folds into a constant too, that is unnecessary >+ pessimization. */ >+ && canonicalize_math_after_vectorization_p ()) > (with { > const REAL_VALUE_TYPE *const value =3D TREE_REAL_CST_PTR (@0); > bool use_exp2 =3D false; >@@ -4021,10 +4028,7 @@ DEFINE_INT_AND_FLOAT_ROUND_FN (RINT) > } > (if (!use_exp2) > (exps (mult (logs @0) @1)) >- /* As libmvec doesn't have a vectorized exp2, defer optimizing >- this until after vectorization. */ >- (if (canonicalize_math_after_vectorization_p ()) >- (exp2s (mult (log2s @0) @1)))))))) >+ (exp2s (mult (log2s @0) @1))))))) >=20 > (for sqrts (SQRT) > cbrts (CBRT) >--- gcc/testsuite/gfortran.dg/pr82004.f90.jj 2018-02-19 >17:58:57.435682156 +0100 >+++ gcc/testsuite/gfortran.dg/pr82004.f90 2018-02-19 17:58:34.127684892 >+0100 >@@ -0,0 +1,18 @@ >+! PR middle-end/82004 >+! { dg-do run } >+! { dg-options "-Ofast" } >+ >+ integer, parameter :: r8 =3D selected_real_kind(13), i4 =3D kind(1) >+ integer (i4), parameter :: a =3D 400, b =3D 2 >+ real (r8), parameter, dimension(b) :: c =3D (/ .001_r8, 10.00_r8 /) >+ real (r8) :: d, e, f, g, h >+ real (r8), parameter :: j & >+ =3D 10**(log10(c(1))-(log10(c(b))-log10(c(1)))/real(a)) >+ >+ d =3D c(1) >+ e =3D c(b) >+ f =3D (log10(e)-log10(d))/real(a) >+ g =3D log10(d) - f >+ h =3D 10**(g) >+ if (h.ne.j) stop 1 >+end > > Jakub