public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
To: Andreas Schwab <schwab@suse.de>,Sebastian Huber
	<sebastian.huber@embedded-brains.de>
Cc: gcc-patches@gcc.gnu.org,libstdc++@gcc.gnu.org,devel@rtems.org
Subject: Re: [PATCH v2] [RTEMS] Always use atomic builtins for libstdc++
Date: Thu, 22 Sep 2016 19:12:00 -0000	[thread overview]
Message-ID: <5FFB22EA-59B1-4E74-A8E6-3247012D4097@gmail.com> (raw)
In-Reply-To: <mvm60po5mep.fsf@hawking.suse.de>

On 22 September 2016 11:11:42 CEST, Andreas Schwab <schwab@suse.de> wrote:
>On Sep 22 2016, Sebastian Huber <sebastian.huber@embedded-brains.de>
>wrote:
>
>> diff --git a/libstdc++-v3/acinclude.m4 b/libstdc++-v3/acinclude.m4
>> index 6d897be..d7db435 100644
>> --- a/libstdc++-v3/acinclude.m4
>> +++ b/libstdc++-v3/acinclude.m4
>> @@ -3490,9 +3490,10 @@ EOF
>>    AC_LANG_RESTORE
>>  
>>    # Set atomicity_dir to builtins if all but the long long test
>above passes.
>> -  if test "$glibcxx_cv_atomic_bool" = yes \
>> +  if { test "$glibcxx_cv_atomic_bool" = yes \
>>       && test "$glibcxx_cv_atomic_short" = yes \
>> -     && test "$glibcxx_cv_atomic_int" = yes; then
>> +     && test "$glibcxx_cv_atomic_int" = yes } \
>
>You need a semicolon (or newline) before }.

Please remind me why you need curly braces at all?

thanks

  reply	other threads:[~2016-09-22 19:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-22  8:50 Sebastian Huber
2016-09-22  9:24 ` Andreas Schwab
2016-09-22 19:12   ` Bernhard Reutner-Fischer [this message]
2016-09-26  9:15     ` Andreas Schwab
2016-09-26 15:59       ` Bernhard Reutner-Fischer
2016-09-26 16:28         ` Andreas Schwab
     [not found] ` <CAF9ehCW0mR1E-iz6wPP3ST3rRixZJvLh+cfGXQ8mpa9UfeLJ5g@mail.gmail.com>
2016-09-22 13:40   ` Sebastian Huber
2016-09-23  7:21     ` Sebastian Huber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5FFB22EA-59B1-4E74-A8E6-3247012D4097@gmail.com \
    --to=rep.dot.nop@gmail.com \
    --cc=devel@rtems.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=libstdc++@gcc.gnu.org \
    --cc=schwab@suse.de \
    --cc=sebastian.huber@embedded-brains.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).