From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 116072 invoked by alias); 22 Sep 2016 19:03:04 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 115998 invoked by uid 89); 22 Sep 2016 19:03:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=curly, H*Ad:U*devel X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-wm0-f66.google.com Received: from mail-wm0-f66.google.com (HELO mail-wm0-f66.google.com) (74.125.82.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 22 Sep 2016 19:02:53 +0000 Received: by mail-wm0-f66.google.com with SMTP id 133so15613859wmq.2; Thu, 22 Sep 2016 12:02:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:in-reply-to:references:mime-version :content-transfer-encoding:subject:from:date:to:cc:message-id; bh=gt9e0KufdEiNnTbZXsYzkYMI5GrMe7xHMyczR/K9kgM=; b=G1zGq1I8tYetutf+kqMvTnwFec3a+dQTG74ijIop1ZEMn7TAa8E4jzd7spMAHPnveo hbOLrNKoInfgWzr+X55wgIWNkVzRLITMOyGtC3kS81L+DCRfsF0R1WiOrUfaJybP5qX8 i0ruo5ajSbpbj0DZ3NfQhrpHe6nW5cqgXBWHY0asfWN7gD2ZtvAVviMLjDRpi9E/DNvx wb6Nm1YCSVite4QSNi175BIf34srb1At2ZxFwxuz0i5afs8DQvtY36ooWnNDlzK99TEX rPZ/IoiEhBiKdOJDnsyfDjprK0mpV8ZRJNhDSmmzwBENOqZFM4dNJjbDNWesvDzVQrmD lZiQ== X-Gm-Message-State: AE9vXwPK3pLalnRsa+uqd+PRhUs7D0kEn4wi0I4Dq0sFcD29H+RNARK/QQZVNvXQruS5YA== X-Received: by 10.194.89.129 with SMTP id bo1mr3339039wjb.105.1474570971649; Thu, 22 Sep 2016 12:02:51 -0700 (PDT) Received: from [10.48.86.63] (089144224063.atnat0033.highway.a1.net. [89.144.224.63]) by smtp.gmail.com with ESMTPSA id y2sm3413824wji.42.2016.09.22.12.02.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 Sep 2016 12:02:51 -0700 (PDT) In-Reply-To: References: <1474534063-8867-1-git-send-email-sebastian.huber@embedded-brains.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Subject: Re: [PATCH v2] [RTEMS] Always use atomic builtins for libstdc++ From: Bernhard Reutner-Fischer Date: Thu, 22 Sep 2016 19:12:00 -0000 To: Andreas Schwab ,Sebastian Huber CC: gcc-patches@gcc.gnu.org,libstdc++@gcc.gnu.org,devel@rtems.org Message-ID: <5FFB22EA-59B1-4E74-A8E6-3247012D4097@gmail.com> X-IsSubscribed: yes X-SW-Source: 2016-09/txt/msg01613.txt.bz2 On 22 September 2016 11:11:42 CEST, Andreas Schwab wrote: >On Sep 22 2016, Sebastian Huber >wrote: > >> diff --git a/libstdc++-v3/acinclude.m4 b/libstdc++-v3/acinclude.m4 >> index 6d897be..d7db435 100644 >> --- a/libstdc++-v3/acinclude.m4 >> +++ b/libstdc++-v3/acinclude.m4 >> @@ -3490,9 +3490,10 @@ EOF >> AC_LANG_RESTORE >> >> # Set atomicity_dir to builtins if all but the long long test >above passes. >> - if test "$glibcxx_cv_atomic_bool" = yes \ >> + if { test "$glibcxx_cv_atomic_bool" = yes \ >> && test "$glibcxx_cv_atomic_short" = yes \ >> - && test "$glibcxx_cv_atomic_int" = yes; then >> + && test "$glibcxx_cv_atomic_int" = yes } \ > >You need a semicolon (or newline) before }. Please remind me why you need curly braces at all? thanks