From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id ADE793858D38 for ; Wed, 11 Jan 2023 13:05:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org ADE793858D38 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0127361.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 30BBU6g2019055; Wed, 11 Jan 2023 13:05:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=content-type : message-id : date : mime-version : subject : to : cc : references : from : in-reply-to; s=pp1; bh=4r+LaaEupU8GZlUbcBbzEXqxCN+NWOuCLY+ry6Yv3kk=; b=hNSy5JFfI0I61etzZV+DWm2dUIXfBZRlMPY1I1CQKE94ZVGEyZxCKcGum6xcJ0R9KRB8 6/eOm7xV58zupx0290vHiod+BG1CVoo+YPr9/pjLjI2BV7dx5cCDccOEWVforkfepIRs /EVJ0uluk81rnVn2MLJk5SefvfOA4Zar4FpxKUoxxmtjEnrUFYhKx6SXMJV3sNK3hHmE D1sIsRKPLFu9hJzyPLEFzEmcdve02fSW7Gk0NKG1jbVAqZcfFGbXeZkkBMDLEnkDC8wi 6cDSRcpT5tFVSiw7/gLfwUVF7IUPxzEdHPfONM6CIEdQi36G5l43lPdj884SzCgJIV+u Bg== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3n1v9ya0e9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 11 Jan 2023 13:05:41 +0000 Received: from m0127361.ppops.net (m0127361.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 30BCgdQs040692; Wed, 11 Jan 2023 13:05:40 GMT Received: from ppma04ams.nl.ibm.com (63.31.33a9.ip4.static.sl-reverse.com [169.51.49.99]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3n1v9ya0de-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 11 Jan 2023 13:05:40 +0000 Received: from pps.filterd (ppma04ams.nl.ibm.com [127.0.0.1]) by ppma04ams.nl.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 30B1sxQR025832; Wed, 11 Jan 2023 13:05:38 GMT Received: from smtprelay05.fra02v.mail.ibm.com ([9.218.2.225]) by ppma04ams.nl.ibm.com (PPS) with ESMTPS id 3n1kv7ruvf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 11 Jan 2023 13:05:38 +0000 Received: from smtpav04.fra02v.mail.ibm.com (smtpav04.fra02v.mail.ibm.com [10.20.54.103]) by smtprelay05.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 30BD5YZX42860936 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 11 Jan 2023 13:05:35 GMT Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CB9862004D; Wed, 11 Jan 2023 13:05:34 +0000 (GMT) Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A007D20040; Wed, 11 Jan 2023 13:05:32 +0000 (GMT) Received: from [9.197.230.44] (unknown [9.197.230.44]) by smtpav04.fra02v.mail.ibm.com (Postfix) with ESMTP; Wed, 11 Jan 2023 13:05:32 +0000 (GMT) Content-Type: multipart/mixed; boundary="------------CzuZaOyQqWxPJsgOXAUlVt0u" Message-ID: <5a0019b5-0464-41f6-18c2-c7e86e6612b9@linux.ibm.com> Date: Wed, 11 Jan 2023 21:05:30 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH] rs6000: Make P10_FUSION honour tuning setting Content-Language: en-US To: GCC Patches Cc: Segher Boessenkool , David Edelsohn , Peter Bergner , Pat Haugen References: <9defdca0-1cf3-82a3-d04a-2eb4f3daf106@linux.ibm.com> From: "Kewen.Lin" In-Reply-To: X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: BqobcX8TRADE5MExqhINAWkw6IdK08AB X-Proofpoint-GUID: occsc2lzVh8-Igl_3zJ356N0Cf75dDZy X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2023-01-11_05,2023-01-11_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 lowpriorityscore=0 malwarescore=0 phishscore=0 spamscore=0 mlxlogscore=999 impostorscore=0 adultscore=0 suspectscore=0 priorityscore=1501 mlxscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2301110092 X-Spam-Status: No, score=-9.2 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,NICE_REPLY_A,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------CzuZaOyQqWxPJsgOXAUlVt0u Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit on 2023/1/6 17:28, Kewen.Lin via Gcc-patches wrote: > Hi Pat, > > on 2023/1/6 03:30, Pat Haugen wrote: >> On 1/4/23 3:20 AM, Kewen.Lin via Gcc-patches wrote: >>> diff --git a/gcc/config/rs6000/rs6000.cc b/gcc/config/rs6000/rs6000.cc >>> index 88c865b6b4b..6fa084c0807 100644 >>> --- a/gcc/config/rs6000/rs6000.cc >>> +++ b/gcc/config/rs6000/rs6000.cc >>> @@ -4378,9 +4378,15 @@ rs6000_option_override_internal (bool global_init_p) >>>         rs6000_isa_flags &= ~OPTION_MASK_MMA; >>>       } >>> >>> -  if (TARGET_POWER10 >>> -      && (rs6000_isa_flags_explicit & OPTION_MASK_P10_FUSION) == 0) >>> -    rs6000_isa_flags |= OPTION_MASK_P10_FUSION; >>> +  /* Enable power10 fusion if we are tuning for power10, even if we aren't >>> +     generating power10 instructions.  */ >>> +  if (!(rs6000_isa_flags_explicit & OPTION_MASK_P10_FUSION)) >>> +    { >>> +      if (processor_target_table[tune_index].processor == PROCESSOR_POWER10) >> >> You can use (rs6000_tune == PROCESSOR_POWER10) at this point. > > Good catch, I will update it. Thanks! Committed the updated version (as attached) in r13-5107-g6224db0e4d6d3b. BR, Kewen --------------CzuZaOyQqWxPJsgOXAUlVt0u Content-Type: text/plain; charset=UTF-8; name="0001-rs6000-Make-P10_FUSION-honour-tuning-setting.patch" Content-Disposition: attachment; filename="0001-rs6000-Make-P10_FUSION-honour-tuning-setting.patch" Content-Transfer-Encoding: base64 U3ViamVjdDogW1BBVENIXSByczYwMDA6IE1ha2UgUDEwX0ZVU0lPTiBob25vdXIgdHVuaW5n IHNldHRpbmcKCldlIG5vdGljZWQgdGhpcyBpc3N1ZSB3aGVuIFNlZ2hlciByZXZpZXdlZCB0 aGUgcGF0Y2ggZm9yClBSMTA0MDI0LiAgV2hlbiB0aGVyZSBpcyBubyBleHBsaWNpdCBzZXR0 aW5nIGZvciBvcHRpb24KLW1wb3dlcjEwLWZ1c2lvbiwgd2UgZW5hYmxlIE9QVElPTl9NQVNL X1AxMF9GVVNJT04gZm9yClRBUkdFVF9QT1dFUjEwLiAgQnV0IGl0J3Mgbm90IHJpZ2h0LCBp dCBzaG91bGQgaG9ub3VyCnR1bmluZyBzZXR0aW5nIGluc3RlYWQuCgpUaGlzIHBhdGNoIGlz IHRvIGZpeCBpdCBhY2NvcmRpbmdseSwgaXQncyBib290c3RyYXBwZWQKLCBhbmQgcmVndGVz dGVkIG9uIHBvd2VycGM2NC1saW51eC1nbnUgUDggYW5kCnBvd2VycGM2NGxlLWxpbnV4LWdu dSBQOS4KCkJ1dCBvbiBwb3dlcnBjNjRsZS1saW51eC1nbnUgUDEwIGl0IGhhZCBvbmUgcmVn cmVzc2lvbgpmYWlsdXJlIGFnYWluc3QgdGhlIHRlc3QgY2FzZSBnY2MudGFyZ2V0L3Bvd2Vy cGMvcHIxMDU1ODYuYy4KSSBsb29rZWQgaW50byBpdCBhbmQgY29uZmlybWVkIHRoYXQgYSBs YXRlbnQgYnVnIHdhcwpleHBvc2VkIGFuZCBmaWxlZCBvbmUgc2VwYXJhdGVkIGJ1ZyBQUjEw ODI3MyBpbnN0ZWFkLgoKZ2NjL0NoYW5nZUxvZzoKCgkqIGNvbmZpZy9yczYwMDAvcnM2MDAw LmNjIChyczYwMDBfb3B0aW9uX292ZXJyaWRlX2ludGVybmFsKTogTWFrZQoJT1BUSU9OX01B U0tfUDEwX0ZVU0lPTiBpbXBsaWNpdCBzZXR0aW5nIGhvbm91ciBQb3dlcjEwIHR1bmluZyBz ZXR0aW5nLgoJKiBjb25maWcvcnM2MDAwL3JzNjAwMC1jcHVzLmRlZiAoSVNBXzNfMV9NQVNL U19TRVJWRVIpOiBSZW1vdmUKCU9QVElPTl9NQVNLX1AxMF9GVVNJT04uCi0tLQogZ2NjL2Nv bmZpZy9yczYwMDAvcnM2MDAwLWNwdXMuZGVmIHwgIDMgKy0tCiBnY2MvY29uZmlnL3JzNjAw MC9yczYwMDAuY2MgICAgICAgfCAxMiArKysrKysrKystLS0KIDIgZmlsZXMgY2hhbmdlZCwg MTAgaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9nY2MvY29u ZmlnL3JzNjAwMC9yczYwMDAtY3B1cy5kZWYgYi9nY2MvY29uZmlnL3JzNjAwMC9yczYwMDAt Y3B1cy5kZWYKaW5kZXggYzM4MjViY2NjZDguLjRkNTU0NGU5MjdhIDEwMDY0NAotLS0gYS9n Y2MvY29uZmlnL3JzNjAwMC9yczYwMDAtY3B1cy5kZWYKKysrIGIvZ2NjL2NvbmZpZy9yczYw MDAvcnM2MDAwLWNwdXMuZGVmCkBAIC04NCw4ICs4NCw3IEBACiAKICNkZWZpbmUgSVNBXzNf MV9NQVNLU19TRVJWRVIJKElTQV8zXzBfTUFTS1NfU0VSVkVSCQkJXAogCQkJCSB8IE9QVElP Tl9NQVNLX1BPV0VSMTAJCQlcCi0JCQkJIHwgT1RIRVJfUE9XRVIxMF9NQVNLUwkJCVwKLQkJ CQkgfCBPUFRJT05fTUFTS19QMTBfRlVTSU9OKQorCQkJCSB8IE9USEVSX1BPV0VSMTBfTUFT S1MpCiAKIC8qIEZsYWdzIHRoYXQgbmVlZCB0byBiZSB0dXJuZWQgb2ZmIGlmIC1tbm8tcG93 ZXI5LXZlY3Rvci4gICovCiAjZGVmaW5lIE9USEVSX1A5X1ZFQ1RPUl9NQVNLUwkoT1BUSU9O X01BU0tfRkxPQVQxMjhfSFcJCVwKZGlmZiAtLWdpdCBhL2djYy9jb25maWcvcnM2MDAwL3Jz NjAwMC5jYyBiL2djYy9jb25maWcvcnM2MDAwL3JzNjAwMC5jYwppbmRleCA2YWMzYWRjZWM2 Yi4uM2JhYTJjM2I3YjAgMTAwNjQ0Ci0tLSBhL2djYy9jb25maWcvcnM2MDAwL3JzNjAwMC5j YworKysgYi9nY2MvY29uZmlnL3JzNjAwMC9yczYwMDAuY2MKQEAgLTQzOTcsOSArNDM5Nywx NSBAQCByczYwMDBfb3B0aW9uX292ZXJyaWRlX2ludGVybmFsIChib29sIGdsb2JhbF9pbml0 X3ApCiAgICAgICByczYwMDBfaXNhX2ZsYWdzICY9IH5PUFRJT05fTUFTS19NTUE7CiAgICAg fQogCi0gIGlmIChUQVJHRVRfUE9XRVIxMAotICAgICAgJiYgKHJzNjAwMF9pc2FfZmxhZ3Nf ZXhwbGljaXQgJiBPUFRJT05fTUFTS19QMTBfRlVTSU9OKSA9PSAwKQotICAgIHJzNjAwMF9p c2FfZmxhZ3MgfD0gT1BUSU9OX01BU0tfUDEwX0ZVU0lPTjsKKyAgLyogRW5hYmxlIHBvd2Vy MTAgZnVzaW9uIGlmIHdlIGFyZSB0dW5pbmcgZm9yIHBvd2VyMTAsIGV2ZW4gaWYgd2UgYXJl bid0CisgICAgIGdlbmVyYXRpbmcgcG93ZXIxMCBpbnN0cnVjdGlvbnMuICAqLworICBpZiAo IShyczYwMDBfaXNhX2ZsYWdzX2V4cGxpY2l0ICYgT1BUSU9OX01BU0tfUDEwX0ZVU0lPTikp CisgICAgeworICAgICAgaWYgKHJzNjAwMF90dW5lID09IFBST0NFU1NPUl9QT1dFUjEwKQor CXJzNjAwMF9pc2FfZmxhZ3MgfD0gT1BUSU9OX01BU0tfUDEwX0ZVU0lPTjsKKyAgICAgIGVs c2UKKwlyczYwMDBfaXNhX2ZsYWdzICY9IH5PUFRJT05fTUFTS19QMTBfRlVTSU9OOworICAg IH0KIAogICAvKiBNTUEgcmVxdWlyZXMgU0lNRCBzdXBwb3J0IGFzIElTQSAzLjEgY2xhaW1z IGFuZCBvdXIgaW1wbGVtZW50YXRpb24KICAgICAgc3VjaCBhcyAiKm1vdm9vIiB1c2VzIHZl Y3RvciBwYWlyIGFjY2VzcyB3aGljaCB1c2UgVlNYIHJlZ2lzdGVycy4KLS0gCjIuMzQuMQoK --------------CzuZaOyQqWxPJsgOXAUlVt0u--