From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x2d.google.com (mail-oa1-x2d.google.com [IPv6:2001:4860:4864:20::2d]) by sourceware.org (Postfix) with ESMTPS id 3DC003858D37 for ; Fri, 25 Aug 2023 18:53:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3DC003858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-oa1-x2d.google.com with SMTP id 586e51a60fabf-1c504386370so801429fac.1 for ; Fri, 25 Aug 2023 11:53:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692989589; x=1693594389; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=KVeuQJkBIAtE8uRSSVgCEBticJmheBWjqw1kC8ZnVUo=; b=njShFBrA6aPfzTDp6FN1b0zwggh0ilfpLB2Jrbj+Lssu1a3lMe2gT2twDvUeGQWYCH 8W5kehZ+oXBKznGMRrfsu+L1Qgff4l+v35sjKI+Fg2xbkXF/g7MX/9oGPataN7ApZ3HY CJEhqh985jl2yXWzJE4fxzEG+nawuLRf2pYymM7+ZUQeaSToP58uN8U5kx+F4w5A9/uF B4enDh7se9KZhEe0O8+GWVcgqA+LTK63K48U0VmYjPWp+8XaCPjIsJiEJ+zXN3LXDZHE FIEpN42bszcT7h6IRYG0C0PL6zjDOmUCTqIuieAT9NN70pu+Lv5ZUjeIovd/YrZtOlxs kD1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692989589; x=1693594389; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KVeuQJkBIAtE8uRSSVgCEBticJmheBWjqw1kC8ZnVUo=; b=HVqO7Zf0+uSmq6hsU33hocssWl5PdK7CDWBLzb7dmUVicRyGtTXgvNpAlPTUm5IMg8 4ETfnMKbOmxpxxFOmey5hRD0AUZx/PC5IBfAqBQzF3MrsDiwx+mN6pGRsMxxAeY2dIkB a4UZ2lFIWJ2tFu5FBEXMCOwZ3Vf2sA1znDPKf57JofUrT7s4f3b9NtCkMym7qO7DmZN2 9+RVO5pQ4UmVJKTUjATWqqXeQ44R19XYa9g4R2hJnvvTNAH7iOu1eIDKF7BEzCBq262R z/Dc7UKZKfXlpPOrtcUXilpmgdxc4eojFXyJmExqDFHvB9fnF8K3e+0kgd3D6bCsWqPd vNkA== X-Gm-Message-State: AOJu0YxRnGsgKND3F9qVmaVYvbP/sIHMg6mEVnWCkCjzMBGBsAfxj8El 5IVQMiUAkpkiRDFc0rRj05c= X-Google-Smtp-Source: AGHT+IGT/yuNlRvgQYn4AagY4YpnleJJS+qnoejUV6gN4+du89xJXPFTaI1+T7IrDWDx4EKFj3cuYA== X-Received: by 2002:a05:6870:d10f:b0:1be:f46d:a26c with SMTP id e15-20020a056870d10f00b001bef46da26cmr4204730oac.27.1692989589409; Fri, 25 Aug 2023 11:53:09 -0700 (PDT) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id d12-20020a17090a628c00b0026b3f76a063sm1939848pjj.44.2023.08.25.11.53.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Aug 2023 11:53:08 -0700 (PDT) Message-ID: <5a02fd13-95af-768a-f61d-7daf890076fa@gmail.com> Date: Fri, 25 Aug 2023 12:53:07 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH V2] RISC-V: Add Types to Un-Typed Sync Instructions: Content-Language: en-US To: Edwin Lu , gcc-patches@gcc.gnu.org Cc: gnu-toolchain@rivosinc.com References: <20230824211957.671151-1-ewlu@rivosinc.com> From: Jeff Law In-Reply-To: <20230824211957.671151-1-ewlu@rivosinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 8/24/23 15:19, Edwin Lu wrote: > Related Discussion: > https://inbox.sourceware.org/gcc-patches/12fb5088-3f28-0a69-de1e-f387371a5eb2@gmail.com/ > > This patch updates the sync instructions to ensure that no insn is left > without a type attribute. Updates a total of 6 insns to have type "atomic" > > Tested for regressions using rv32/64 multilib with newlib/linux. > > gcc/Changelog: > > * config/riscv/sync-rvwmo.md: updated types to "multi" or > "atomic" based on number of assembly lines generated > * config/riscv/sync-ztso.md: likewise > * config/riscv/sync.md: likewise OK. You should have your write access set up already. So go ahead and follow the directions in the email you received to get yourself into the MAINTAINERS file. Then you can go ahead and push this change. THanks, Jeff