From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 991743858D28 for ; Fri, 3 Dec 2021 22:35:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 991743858D28 Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1B3Ll5WZ005168; Fri, 3 Dec 2021 22:34:59 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 3cquf40pej-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 03 Dec 2021 22:34:59 +0000 Received: from m0098409.ppops.net (m0098409.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 1B3M8DW4007040; Fri, 3 Dec 2021 22:34:58 GMT Received: from ppma03wdc.us.ibm.com (ba.79.3fa9.ip4.static.sl-reverse.com [169.63.121.186]) by mx0a-001b2d01.pphosted.com with ESMTP id 3cquf40pe9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 03 Dec 2021 22:34:58 +0000 Received: from pps.filterd (ppma03wdc.us.ibm.com [127.0.0.1]) by ppma03wdc.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 1B3MSLYl016932; Fri, 3 Dec 2021 22:34:57 GMT Received: from b03cxnp07027.gho.boulder.ibm.com (b03cxnp07027.gho.boulder.ibm.com [9.17.130.14]) by ppma03wdc.us.ibm.com with ESMTP id 3cn3k44xxa-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 03 Dec 2021 22:34:57 +0000 Received: from b03ledav005.gho.boulder.ibm.com (b03ledav005.gho.boulder.ibm.com [9.17.130.236]) by b03cxnp07027.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 1B3MYuj933030614 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 3 Dec 2021 22:34:56 GMT Received: from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2BEFFBE0CD; Fri, 3 Dec 2021 22:34:56 +0000 (GMT) Received: from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7F09EBE0D0; Fri, 3 Dec 2021 22:34:55 +0000 (GMT) Received: from [9.65.255.219] (unknown [9.65.255.219]) by b03ledav005.gho.boulder.ibm.com (Postfix) with ESMTP; Fri, 3 Dec 2021 22:34:55 +0000 (GMT) Message-ID: <5a056980-d891-059f-cda0-25c3b9626e7f@linux.ibm.com> Date: Fri, 3 Dec 2021 16:34:54 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 Subject: Re: rs6000: Fix up flag_shrink_wrap handling in presence of -mrop-protect [PR101324] Content-Language: en-US From: Peter Bergner To: Segher Boessenkool Cc: David Edelsohn , GCC Patches , =?UTF-8?Q?Martin_Li=c5=a1ka?= , Tulio Magno Quites Machado Filho , Bill Schmidt References: <6c8a8e20-674e-3954-a7e2-63c2eedac828@linux.ibm.com> <20211029214558.GC614@gate.crashing.org> <9337c424-0e45-eef9-8c2a-4c243ce8a948@linux.ibm.com> In-Reply-To: <9337c424-0e45-eef9-8c2a-4c243ce8a948@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: W7ieMMOVI1j7foQ33sCUcf69vCGMqUsd X-Proofpoint-GUID: cD26tgueCorVdjW5HVwqnaQ6xTzcP091 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513 definitions=2021-12-03_11,2021-12-02_01,2021-12-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 bulkscore=0 spamscore=0 suspectscore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 mlxlogscore=999 adultscore=0 phishscore=0 clxscore=1015 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000 definitions=main-2112030143 X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, KAM_SHORT, NICE_REPLY_A, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Dec 2021 22:35:02 -0000 On 12/3/21 3:27 PM, Peter Bergner wrote: > On 12/3/21 2:39 PM, Peter Bergner wrote: >> On 10/29/21 4:45 PM, Segher Boessenkool wrote: >>> On Wed, Oct 27, 2021 at 10:17:39PM -0500, Peter Bergner wrote: >>>> 2021-10-27 Martin Liska >>>> >>>> gcc/ >>>> PR target/101324 >>>> * config/rs6000/rs6000.c (rs6000_option_override_internal): Move the >>>> disabling of shrink-wrapping when using -mrop-protect from here... >>>> (rs6000_override_options_after_change): ...to here. >>>> >>>> 2021-10-27 Peter Bergner >>>> >>>> gcc/testsuite/ >>>> PR target/101324 >>>> * gcc.target/powerpc/pr101324.c: New test. >>> >>> Okay for trunk with similar robustification. Thanks! >> >> With the rop_ok change finally committed, I have finally pushed this >> change with your suggested test case changes. Thanks Martin for the >> fix and Segher for the reviews. > > So I just checked and we have the same failure on GCC11 too. > Ok for the GCC11 release branch after this has burned-in on > trunk for a couple of days? > > Ditto for the rop_ok testsuite patch that goes with this one? FYI, both commits backported cleanly and showed no testsuite regressions on powerrpc64le-linux. Peter