From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 61870 invoked by alias); 9 Aug 2016 15:46:58 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 61860 invoked by uid 89); 9 Aug 2016 15:46:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 spammy=H*f:sk:CAOyqgc X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0a-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.156.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 09 Aug 2016 15:46:56 +0000 Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id u79FiTDn085977 for ; Tue, 9 Aug 2016 11:46:54 -0400 Received: from e36.co.us.ibm.com (e36.co.us.ibm.com [32.97.110.154]) by mx0a-001b2d01.pphosted.com with ESMTP id 24nce9prh1-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 09 Aug 2016 11:46:54 -0400 Received: from localhost by e36.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 9 Aug 2016 09:46:52 -0600 Received: from d03dlp03.boulder.ibm.com (9.17.202.179) by e36.co.us.ibm.com (192.168.1.136) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 9 Aug 2016 09:46:48 -0600 X-IBM-Helo: d03dlp03.boulder.ibm.com X-IBM-MailFrom: laboger@linux.vnet.ibm.com Received: from b03cxnp08027.gho.boulder.ibm.com (b03cxnp08027.gho.boulder.ibm.com [9.17.130.19]) by d03dlp03.boulder.ibm.com (Postfix) with ESMTP id F2A6519D805F; Tue, 9 Aug 2016 09:46:21 -0600 (MDT) Received: from b03ledav001.gho.boulder.ibm.com (b03ledav001.gho.boulder.ibm.com [9.17.130.232]) by b03cxnp08027.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u79Fkmqq11534694; Tue, 9 Aug 2016 08:46:48 -0700 Received: from b03ledav001.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 380496E041; Tue, 9 Aug 2016 09:46:48 -0600 (MDT) Received: from oc3540537726.ibm.com (unknown [9.10.86.61]) by b03ledav001.gho.boulder.ibm.com (Postfix) with ESMTP id E4C0B6E040; Tue, 9 Aug 2016 09:46:47 -0600 (MDT) Subject: Re: libgo patch committed: Change build procedure to use build tags To: Ian Lance Taylor References: Cc: gcc-patches , "gofrontend-dev@googlegroups.com" , Segher Boessenkool From: "Lynn A. Boger" Date: Tue, 09 Aug 2016 15:46:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16080915-0020-0000-0000-00000983C0DB X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00005569; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000178; SDB=6.00742272; UDB=6.00349376; IPR=6.00514829; BA=6.00004651; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00012274; XFM=3.00000011; UTC=2016-08-09 15:46:50 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16080915-0021-0000-0000-00005469E743 Message-Id: <5a0c6ea1-afeb-557a-4fe9-334051be097a@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-08-09_06:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1608090161 X-IsSubscribed: yes X-SW-Source: 2016-08/txt/msg00734.txt.bz2 libgo test results in gcc-testresults for ppc64le & ppc64 are back to what they were before the change. Thanks. On 08/08/2016 03:34 PM, Ian Lance Taylor wrote: > On Mon, Aug 8, 2016 at 11:14 AM, Lynn A. Boger > wrote: >> The libgo tests on ppc64le and ppc64 have all been failing in >> gcc-testresults since this change went in and continues to fail after the >> recent fixes for failures on other platforms. >> >> Built myself and got the same failures. I set keep=true in gotest to save >> the test dirs. Just running a single package: >> >> make bufio/check >> file /home/boger/gccgo.work/trunk/bld/../src/libgo/go/bufio/bufio.go not >> found >> Keeping gotest9734 >> FAIL: bufio >> Makefile:3645: recipe for target 'bufio/check' failed >> make: *** [bufio/check] Error 1 >> boger@willow3:~/gccgo.work/trunk/bld/powerpc64le-linux/libgo$ ls >> /home/boger/gccgo.work/trunk/bld/../src/libgo/go/bufio/bufio.go >> /home/boger/gccgo.work/trunk/bld/../src/libgo/go/bufio/bufio.go >> boger@willow3:~/gccgo.work/trunk/bld/powerpc64le-linux/libgo$ file >> /home/boger/gccgo.work/trunk/bld/../src/libgo/go/bufio/bufio.go >> /home/boger/gccgo.work/trunk/bld/../src/libgo/go/bufio/bufio.go: ASCII text > I found the problem. I always configure with a relative srcdir. You > are using an absolute srcdir. The recent changes to use build tags > changed the libgo Makefile so that when invoked with with an absolute > srcdir it would pass absolute path names to the gotest script. That > never worked. This patch makes it work, and should fix your problem. > Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu with a > relative srcdir and an absolute srcdir. Committed to mainline. > > Ian