From: Chung-Lin Tang <cltang@codesourcery.com>
To: Sandra Loosemore <sandra@codesourcery.com>,
GCC Patches <gcc-patches@gcc.gnu.org>
Cc: Marek Vasut <marex@denx.de>
Subject: Re: [nios2, committed] fix bad assertion
Date: Sat, 21 May 2016 08:30:00 -0000 [thread overview]
Message-ID: <5a47ef2e-46e7-70fc-4826-c8517d3cd07b@codesourcery.com> (raw)
In-Reply-To: <559179DB.8020505@codesourcery.com>
On 2015/6/30 1:01 AM, Sandra Loosemore wrote:
> When I was preparing to regression-test something else in a nios2-linux-gnu build, I discovered it was ICE'ing while building
> shared libraries with -fpic (glibc, libgomp). I tracked this down to having started with r224048, but on further investigation
> I decided that commit merely exposed a latent bug.
>
> The trouble is that the assertion in nios2_delegitimize_address is too restrictive compared to what nios2_legitimize_address can
> produce. It's expecting to find a SYMBOL_REF underneath but in one case it was crashing on a LABEL_REF (for a computed goto),
> and in another case it was a symbol + offset expression which is even documented with a big block of comments in
> nios2_legitimize_address. I've checked in this patch to relax the assertion; it allows the toolchain to build again, and test
> results look decent.
>
> -Sandra
>
This was backported to gcc-5-branch, to fix that ICE Marek encountered.
Chung-Lin
prev parent reply other threads:[~2016-05-21 8:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-29 17:18 Sandra Loosemore
2016-05-21 8:30 ` Chung-Lin Tang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a47ef2e-46e7-70fc-4826-c8517d3cd07b@codesourcery.com \
--to=cltang@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=marex@denx.de \
--cc=sandra@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).