From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 1DE1C3858C54; Wed, 7 Jun 2023 01:22:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1DE1C3858C54 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3571CDXx014957; Wed, 7 Jun 2023 01:22:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=mime-version : date : from : to : cc : subject : in-reply-to : references : message-id : content-type : content-transfer-encoding; s=pp1; bh=R9sjNV6qN5eYxwij4yMMhilRVPgAxrnVOrshC39H5OI=; b=k0GoJT2YmbDkosp3PltTKDtHmdvDjRYmmf34UKYAmSFDRrJHwWwOhHRocg/5ev6w5R9y sQ6UXc+mng+P/aHa4RCoXzkZzlLnqzyxFHWmp71k9Yi8mj9r6v+kWn+itEe1zPDk729J OIxIG5jwc0TLDAPFziw5rajaoM95bWtq7jLQFNDVttl4LW0UBILKGnaxASIN0LKHYQ4K CkBH9UGbw6w6DBWwbRYPussIJuFVdQKOwc1cWGYWsvSKFhmpYA10EIANlCl0afVEA7Kg LAk2rBPVSgZJgC+wCU8/e0VSqcPlON5BrbiqQBRmymOLzCnzM9HZk6jJvqVGZ/DepNM6 wQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3r2g1505yv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 07 Jun 2023 01:21:59 +0000 Received: from m0356517.ppops.net (m0356517.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 3571GR0x026992; Wed, 7 Jun 2023 01:21:59 GMT Received: from ppma04wdc.us.ibm.com (1a.90.2fa9.ip4.static.sl-reverse.com [169.47.144.26]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3r2g1505yh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 07 Jun 2023 01:21:59 +0000 Received: from pps.filterd (ppma04wdc.us.ibm.com [127.0.0.1]) by ppma04wdc.us.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 356N1gwC032735; Wed, 7 Jun 2023 01:21:58 GMT Received: from smtprelay01.wdc07v.mail.ibm.com ([9.208.129.119]) by ppma04wdc.us.ibm.com (PPS) with ESMTPS id 3r2a76hbth-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 07 Jun 2023 01:21:57 +0000 Received: from smtpav02.wdc07v.mail.ibm.com (smtpav02.wdc07v.mail.ibm.com [10.39.53.229]) by smtprelay01.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 3571LudW36962864 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 7 Jun 2023 01:21:57 GMT Received: from smtpav02.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E5E0A5805C; Wed, 7 Jun 2023 01:21:56 +0000 (GMT) Received: from smtpav02.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5D9AF58058; Wed, 7 Jun 2023 01:21:56 +0000 (GMT) Received: from ltc.linux.ibm.com (unknown [9.5.196.140]) by smtpav02.wdc07v.mail.ibm.com (Postfix) with ESMTP; Wed, 7 Jun 2023 01:21:56 +0000 (GMT) MIME-Version: 1.0 Date: Wed, 07 Jun 2023 09:21:56 +0800 From: guojiufu To: Jeff Law Cc: gcc-patches@gcc.gnu.org, rguenther@suse.de, segher@kernel.crashing.org, dje.gcc@gmail.com, linkw@gcc.gnu.org, meissner@linux.ibm.com Subject: Re: [PATCH V5] Use reg mode to move sub blocks for parameters and returns In-Reply-To: References: <20230317033952.1549050-1-guojiufu@linux.ibm.com> <0221bead-5d08-cb56-e620-642825c1abc3@gmail.com> <0473d90c-7ee0-2989-16b9-234f422e0e3c@gmail.com> <7n3545d3hq.fsf@ltcden2-lp1.aus.stglabs.ibm.com> Message-ID: <5a508fea98d0ba26ed436d2bd84a495d@linux.ibm.com> X-Sender: guojiufu@linux.ibm.com Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: 9P_m5DKMnNHhVjfwlBMklcEAQ4XBF_XF X-Proofpoint-GUID: qkKP1hbpwMCANGQbx3tOX1j3aobUmmir X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26 definitions=2023-06-06_18,2023-06-06_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 phishscore=0 adultscore=0 spamscore=0 lowpriorityscore=0 mlxlogscore=999 priorityscore=1501 mlxscore=0 suspectscore=0 clxscore=1015 impostorscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306070007 X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi, On 2023-06-05 00:59, Jeff Law wrote: > On 5/9/23 07:43, Jiufu Guo wrote: > >> Thanks for point out this! Yes, BLKmode rtx may not always be a MEM. >> MEM_SIZE is only ok for MEM after the it's known size is computed. >> Here MEM_SIZE is fine just because it is an stack rtx corresponding >> to the type of parameter and returns which has been computed. >> >> I updated the patch to resolve the conflicts with the trunk, and >> retest bootstrap&testsuite, and then updated the patch a new version. >> >> And this version pass bootstrap and regtest on ppc64{,le}, x86_64. >> >> The major change is 'move_sub_blocks' only handles the case when >> the block size can be move by same submode, or say (size % sub_size) >> is 0. If no objection, I would committed the new version. >> >> BR, >> Jeff (Jiufu) >> >> gcc/ChangeLog: >> >> * cfgexpand.cc (expand_used_vars): Update to mark >> DECL_USEDBY_RETURN_P >> for returns. >> * expr.cc (move_sub_blocks): New function. >> (expand_assignment): Update assignment code about returns/parameters. >> * function.cc (assign_parm_setup_block): Update to mark >> DECL_REGS_TO_STACK_P for parameter. >> * tree-core.h (struct tree_decl_common): Add comment. >> * tree.h (DECL_USEDBY_RETURN_P): New define. >> (DECL_REGS_TO_STACK_P): New define. >> >> gcc/testsuite/ChangeLog: >> >> * gcc.target/powerpc/pr65421-1.c: New test. >> * gcc.target/powerpc/pr65421-2.c: New test. > I don't think this was ever explicitly ACK'd. OK for the trunk. Thanks so much! And sorry for the late reply. I'm trying to investigate another patch that may fix other PRs and also could handle this issue. So, I may suspend this for the new patch. BR, Jeff (Jiufu Guo) > > jeff