From: Jan Beulich <jbeulich@suse.com>
To: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Cc: Uros Bizjak <ubizjak@gmail.com>,
Hongtao Liu <hongtao.liu@intel.com>, Jan Hubicka <hubicka@ucw.cz>,
Kirill Yukhin <kirill.yukhin@gmail.com>
Subject: [PATCH 05/10] x86: replace/correct bogus "prefix_extra"
Date: Thu, 3 Aug 2023 10:12:04 +0200 [thread overview]
Message-ID: <5a5fae9d-e240-c808-702b-93871e39be47@suse.com> (raw)
In-Reply-To: <9bef986f-7441-c4a9-5bfd-7bbed0a3d950@suse.com>
In the rdrand and rdseed cases "prefix_0f" is meant instead. For
mmx_floatv2siv2sf2 1 is correct only for the first alternative. For
the integer min/max cases 1 uniformly applies to legacy and VEX
encodings (the UB and SW variants are dealt with separately anyway).
Same for {,V}MOVNTDQA.
Unlike {,V}PEXTRW, which has two encoding forms, {,V}PINSRW only has
a single form in 0f space. (In *vec_extract<mode> note that the
dropped part if the condition also referenced non-existing alternative
2.)
Of the integer compare insns, only the 64-bit element forms are encoded
in 0f38 space.
gcc/
* config/i386/i386.md (@rdrand<mode>): Add "prefix_0f". Drop
"prefix_extra".
(@rdseed<mode>): Likewise.
* config/i386/mmx.md (<code><mode>3 [smaxmin and umaxmin cases]):
Adjust "prefix_extra".
* config/i386/sse.md (@vec_set<mode>_0): Likewise.
(*sse4_1_<code><mode>3<mask_name>): Likewise.
(*avx2_eq<mode>3): Likewise.
(avx2_gt<mode>3): Likewise.
(<sse2p4_1>_pinsr<ssemodesuffix>): Likewise.
(*vec_extract<mode>): Likewise.
(<vi8_sse4_1_avx2_avx512>_movntdqa): Likewise.
--- a/gcc/config/i386/i386.md
+++ b/gcc/config/i386/i386.md
@@ -25943,7 +25943,7 @@
"TARGET_RDRND"
"rdrand\t%0"
[(set_attr "type" "other")
- (set_attr "prefix_extra" "1")])
+ (set_attr "prefix_0f" "1")])
(define_insn "@rdseed<mode>"
[(set (match_operand:SWI248 0 "register_operand" "=r")
@@ -25953,7 +25953,7 @@
"TARGET_RDSEED"
"rdseed\t%0"
[(set_attr "type" "other")
- (set_attr "prefix_extra" "1")])
+ (set_attr "prefix_0f" "1")])
(define_expand "pause"
[(set (match_dup 0)
--- a/gcc/config/i386/mmx.md
+++ b/gcc/config/i386/mmx.md
@@ -2483,7 +2483,7 @@
vp<maxmin_int><mmxvecsize>\t{%2, %1, %0|%0, %1, %2}"
[(set_attr "isa" "noavx,noavx,avx")
(set_attr "type" "sseiadd")
- (set_attr "prefix_extra" "1,1,*")
+ (set_attr "prefix_extra" "1")
(set_attr "prefix" "orig,orig,vex")
(set_attr "mode" "TI")])
@@ -2532,7 +2532,7 @@
vp<maxmin_int>b\t{%2, %1, %0|%0, %1, %2}"
[(set_attr "isa" "noavx,noavx,avx")
(set_attr "type" "sseiadd")
- (set_attr "prefix_extra" "1,1,*")
+ (set_attr "prefix_extra" "1")
(set_attr "prefix" "orig,orig,vex")
(set_attr "mode" "TI")])
@@ -2561,7 +2561,7 @@
vp<maxmin_int><mmxvecsize>\t{%2, %1, %0|%0, %1, %2}"
[(set_attr "isa" "noavx,noavx,avx")
(set_attr "type" "sseiadd")
- (set_attr "prefix_extra" "1,1,*")
+ (set_attr "prefix_extra" "1")
(set_attr "prefix" "orig,orig,vex")
(set_attr "mode" "TI")])
@@ -2623,7 +2623,7 @@
vp<maxmin_int>w\t{%2, %1, %0|%0, %1, %2}"
[(set_attr "isa" "noavx,noavx,avx")
(set_attr "type" "sseiadd")
- (set_attr "prefix_extra" "1,1,*")
+ (set_attr "prefix_extra" "1")
(set_attr "prefix" "orig,orig,vex")
(set_attr "mode" "TI")])
--- a/gcc/config/i386/sse.md
+++ b/gcc/config/i386/sse.md
@@ -11064,7 +11064,7 @@
(const_string "1")
(const_string "*")))
(set (attr "prefix_extra")
- (if_then_else (eq_attr "alternative" "5,6,7,8,9")
+ (if_then_else (eq_attr "alternative" "5,6,9")
(const_string "1")
(const_string "*")))
(set (attr "length_immediate")
@@ -16779,7 +16779,7 @@
vp<maxmin_int><ssemodesuffix>\t{%2, %1, %0<mask_operand3>|%0<mask_operand3>, %1, %2}"
[(set_attr "isa" "noavx,noavx,avx")
(set_attr "type" "sseiadd")
- (set_attr "prefix_extra" "1,1,*")
+ (set_attr "prefix_extra" "1")
(set_attr "prefix" "orig,orig,vex")
(set_attr "mode" "TI")])
@@ -16813,7 +16813,10 @@
"TARGET_AVX2 && !(MEM_P (operands[1]) && MEM_P (operands[2]))"
"vpcmpeq<ssemodesuffix>\t{%2, %1, %0|%0, %1, %2}"
[(set_attr "type" "ssecmp")
- (set_attr "prefix_extra" "1")
+ (set (attr "prefix_extra")
+ (if_then_else (eq (const_string "<MODE>mode") (const_string "V4DImode"))
+ (const_string "1")
+ (const_string "*")))
(set_attr "prefix" "vex")
(set_attr "mode" "OI")])
@@ -17048,7 +17051,10 @@
"TARGET_AVX2"
"vpcmpgt<ssemodesuffix>\t{%2, %1, %0|%0, %1, %2}"
[(set_attr "type" "ssecmp")
- (set_attr "prefix_extra" "1")
+ (set (attr "prefix_extra")
+ (if_then_else (eq (const_string "<MODE>mode") (const_string "V4DImode"))
+ (const_string "1")
+ (const_string "*")))
(set_attr "prefix" "vex")
(set_attr "mode" "OI")])
@@ -18843,7 +18849,7 @@
(const_string "*")))
(set (attr "prefix_extra")
(if_then_else
- (and (not (match_test "TARGET_AVX"))
+ (ior (eq_attr "prefix" "evex")
(match_test "GET_MODE_NUNITS (<MODE>mode) == 8"))
(const_string "*")
(const_string "1")))
@@ -20004,8 +20010,7 @@
(set_attr "prefix_data16" "1")
(set (attr "prefix_extra")
(if_then_else
- (and (eq_attr "alternative" "0,2")
- (eq (const_string "<MODE>mode") (const_string "V8HImode")))
+ (eq (const_string "<MODE>mode") (const_string "V8HImode"))
(const_string "*")
(const_string "1")))
(set_attr "length_immediate" "1")
@@ -22349,7 +22354,7 @@
"%vmovntdqa\t{%1, %0|%0, %1}"
[(set_attr "isa" "noavx,noavx,avx")
(set_attr "type" "ssemov")
- (set_attr "prefix_extra" "1,1,*")
+ (set_attr "prefix_extra" "1")
(set_attr "prefix" "orig,orig,maybe_evex")
(set_attr "mode" "<sseinsnmode>")])
next prev parent reply other threads:[~2023-08-03 8:12 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-03 8:08 [PATCH 00/10] x86: (mainly) "prefix_extra" adjustments Jan Beulich
2023-08-03 8:09 ` [PATCH 01/10] x86: "prefix_extra" tidying Jan Beulich
2023-08-04 1:50 ` Hongtao Liu
2023-08-03 8:10 ` [PATCH 02/10] x86: "sse4arg" adjustments Jan Beulich
2023-08-04 1:54 ` Hongtao Liu
2023-08-03 8:10 ` [PATCH 03/10] x86: "ssemuladd" adjustments Jan Beulich
2023-08-04 1:55 ` Hongtao Liu
2023-08-03 8:11 ` [PATCH 04/10] x86: "prefix_extra" can't really be "2" Jan Beulich
2023-08-04 1:55 ` Hongtao Liu
2023-08-03 8:12 ` Jan Beulich [this message]
2023-08-04 1:56 ` [PATCH 05/10] x86: replace/correct bogus "prefix_extra" Hongtao Liu
2023-08-03 8:12 ` [PATCH 06/10] x86: drop stray "prefix_extra" Jan Beulich
2023-08-04 1:56 ` Hongtao Liu
2023-08-03 8:12 ` [PATCH 07/10] x86: add (adjust) XOP insn attributes Jan Beulich
2023-08-04 1:57 ` Hongtao Liu
2023-08-03 8:13 ` [PATCH 08/10] x86: add missing "prefix" attribute to VF{,C}MULC Jan Beulich
2023-08-04 1:57 ` Hongtao Liu
2023-08-03 8:13 ` [PATCH 09/10] x86: correct "length_immediate" in a few cases Jan Beulich
2023-08-04 1:57 ` Hongtao Liu
2023-08-03 8:14 ` [PATCH 10/10] x86: drop redundant "prefix_data16" attributes Jan Beulich
2023-08-04 1:58 ` Hongtao Liu
2023-08-04 2:01 ` [PATCH 00/10] x86: (mainly) "prefix_extra" adjustments Hongtao Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a5fae9d-e240-c808-702b-93871e39be47@suse.com \
--to=jbeulich@suse.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hongtao.liu@intel.com \
--cc=hubicka@ucw.cz \
--cc=kirill.yukhin@gmail.com \
--cc=ubizjak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).