From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) by sourceware.org (Postfix) with ESMTPS id 20BE0393BA59 for ; Thu, 17 Nov 2022 02:15:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 20BE0393BA59 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pj1-x102b.google.com with SMTP id v4-20020a17090a088400b00212cb0ed97eso603254pjc.5 for ; Wed, 16 Nov 2022 18:15:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=fkqB9dIvz/G3RFdV/O3L/8xVhJeM193Iwxk4cxLrraU=; b=fYWYrQAurolsZai2r+1aBZ4OxuAJ6qSsiCTxlVe0RQIl1oLfbUmsjlxwIWTQbwV22J +7Wc5PxVadZvPT+14T2xl1cK63t0xPrN3hOMguU6UnAWOSq34GAEHFMVyzksz05oOimO CiAadutOI/zu/PNmECjhs2kFKIvSrC58TO0GzX6bSh9iycPCWOCdwdcQg9GuWSthMS+7 X3JXq4+uf9cYI00sODUxKX19G7X5tkncip8aStphQBozpwn4ulcaX9q+JY5i1NE4Lcnq GMAkZqeWt4pUL95ffeUBOd7Sv9Ia6ZsJBaZFpMskLc4nEP6VBHJB18JJ/DQPsc2DBLJD f2TA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fkqB9dIvz/G3RFdV/O3L/8xVhJeM193Iwxk4cxLrraU=; b=K7DwWlaklJHfxCfvRPjzS8I3IWmp2XVHDSqtqlvNtDw4D4awlYANYvtrfAY5r9I6RR fX1DvIZ6r7w7HEEdb1nJyNYBdiXW2oThJf610o6bLhKhfoJBZVFlugXttTHgFL48nhte KKxvmr6bhASxPAHJJlKRPdkwPaEur3Dw9eHvaBOOUhq+wjLEdBA+FJEK2NaiSktX4w2y 0FnUjAtBJlxqCuaxNOkkpNMe8Ix/yYdfLs+X7OmMoJLnfepkiP7dwg3OxXeUhsjEbe1y 6jrXX3GWB3sJMGVQ61Ekie4srSawo2yNSG/9mHJCxbZKL6yaK1/rskM+QS0Njgy7Qsky yntQ== X-Gm-Message-State: ANoB5pmJZhhPHEI8oFfaoM7RcENU9UwVg0R+EiwCUWTnEaKQr4uqTxUT he/saubajjgiZkCz6MFE2+I= X-Google-Smtp-Source: AA0mqf54rE7MwoHDo+Xzxn5H7vCcFaQQIQTeueGN4spDt4HEaBCuH7xcbh8TnsNHletViKSsDdK3Ow== X-Received: by 2002:a17:902:e94e:b0:172:f5b1:e73b with SMTP id b14-20020a170902e94e00b00172f5b1e73bmr709936pll.58.1668651340902; Wed, 16 Nov 2022 18:15:40 -0800 (PST) Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a]) by smtp.gmail.com with ESMTPSA id r15-20020a17090a4dcf00b00214247ac1acsm2294026pjl.12.2022.11.16.18.15.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Nov 2022 18:15:40 -0800 (PST) Message-ID: <5a93e732-3fcc-239c-7c77-a573ffd1f236@gmail.com> Date: Wed, 16 Nov 2022 19:15:38 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH] [range-ops] Minor readability fix. Content-Language: en-US To: Aldy Hernandez , Jakub Jelinek Cc: GCC patches , Andrew MacLeod References: <20221115163135.604240-1-aldyh@redhat.com> From: Jeff Law In-Reply-To: <20221115163135.604240-1-aldyh@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/15/22 09:31, Aldy Hernandez via Gcc-patches wrote: > I know it's past the end of stage1, but I'm afraid we'll drag this > around forever in the GCC12 branch, and it's an easy readbility fix. > > p.s. Or if you prefer: > > if (!lb_nan && !ub_nan && !maybe_nan && ....) > r.clear_nan (); > > OK for trunk? > > gcc/ChangeLog: > > * range-op-float.cc (range_operator_float::fold_range): Make check > for maybe_isnan more readable. Your call.  I think we're so early in stage3 that if you think this is uber-safe go for it. jeff