From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2045.outbound.protection.outlook.com [40.107.20.45]) by sourceware.org (Postfix) with ESMTPS id 07B013858D28 for ; Mon, 19 Jun 2023 07:09:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 07B013858D28 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fsXLC7ePt9GmfrzicghgvqXhpWOTsvmr3GUVW6/idsSwivaJaJLgWbBWjsFtuD8DD4r3Fss1t+jB6q+3hPJ/CDJQibVHVpSMa29pDjx4VQvbBogJy6LhuBDQ5j/V9w+QZEkmPuArt2UFztnu0VKywVkV9wtSc9wcFUy9Ps+LBmd357thTqMaePlT6cbS2l9iqdEG++reOhkxhfEDgEr6tYrpl90f54jKMPjFZpx9uDqgZViXBARLA4UAZq5xAe46V5f0Ij2JgP9FovGlUA8Ya8RxQMVDoy+oQr+pp4Ux693n7J2hW99CNVBlgZJgsuUVW0YAAPqj6TfsXH4iWUh83A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ui7THgP+dxrJicVjMG8Vwg7Cz9V4FA+QeUqG/4OlKBQ=; b=BmStj58dmPJYBUdCDC408IKBXK7HQDG3mQ2xxxfysyn0AFujUSpwzBNRtaRkNj0svqv9ROHzSwVjaW8MqlXegE5THdaaIxR3kbeSpoYBdQjYu5xiPx2XN+Gxu0tD/phW92wVCM7Hsp2IPYv10NmTO+TBd3ojrczFyFTeWSaA9PJvnfHDuvGqudbp/iYb8wGQ9JMx5Mw7f57e1utIkcmLP1whbU37XXEzkYAyPnf2eTmnqLOIdAttc0eqXQvQ7x2Y1CXnwapDz229/zVIQbXoC8kXs7TBEmz2RxKMO2VlJcjPsN3CjsMtnnk5x04oRZx4CLNv/6eqNhw6b1Q0K1406w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ui7THgP+dxrJicVjMG8Vwg7Cz9V4FA+QeUqG/4OlKBQ=; b=z08qskzmcON3YHMVKENh5qJeNt87mcfS3aOLgfDMilgA6BDEtSKMOxWvfqbLt0sgGY5VXKWF+C4+Z1XtndkVf+9rD6Z4HvE5654JCRCvau3pwNjN5miuvF1CNnu8vwGGkKpvJl8XnOjhxvORj4no+NUX0ZpoSdlYxWnynZ3QgUoVyE/mwhqc2hJAcfnvi73d4cEhevBUQlJsE7cffLV3vuP8H1agNAotKsbuTfNG1b/EjIrrhzXMRt7WMcDbyoiIhAgyV89rMPysfFPgWT0Tv+b8B7ERm2OVe3mh+1ce+ropjWnML8iAyFdNkTlX+8ShLc18Pf6BfPuACHQipzZvQQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PR3PR04MB7209.eurprd04.prod.outlook.com (2603:10a6:102:92::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.36; Mon, 19 Jun 2023 07:09:20 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e442:306f:7711:e24c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e442:306f:7711:e24c%5]) with mapi id 15.20.6500.031; Mon, 19 Jun 2023 07:09:20 +0000 Message-ID: <5aa77cbb-02cc-195b-c052-22c2d993a966@suse.com> Date: Mon, 19 Jun 2023 09:09:21 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v2] x86: make VPTERNLOG* usable on less than 512-bit operands with just AVX512F Content-Language: en-US To: "Liu, Hongtao" Cc: Kirill Yukhin , "gcc-patches@gcc.gnu.org" References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0149.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:96::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PR3PR04MB7209:EE_ X-MS-Office365-Filtering-Correlation-Id: d4ff2818-d9ee-402b-8b44-08db70941a34 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: y4KsDhdcb6kj+B2ZlPAUxda3ZJGrHhsg7rTxcGgs2eAblRTHjGlGPmRohfJ3giitL501DS14YXN4F3yCr1SwJGFVe6jLMxC2zMBJAjRG27moj1ceTS2N1boM6qXT69zpTxJYF8z7gmF3NQyrLcHgzI8J+vAfDvQkAtg6H+zEIRCAciYB9tyXfLhsH9+u5zHXAEViVXPoH8iauxuoz4EYvgijvi1wbVqdUv0TfFV0ws4x/LCGNNYGr0i53RJl94T4v2s486lBylaNc3wfdQY0zycLlz/pTVEPXoRBBcOaEscDtBO7nsVtw82leZ23N34a1k+mnNp3EqcwO6f67IO/7uOl34jGX2jsHd7orXckk0WEsiMiihG7vIMFhB/yU1lIY2Q9xiPhakVVR4rR3tA4xHnSLOwEM3v+UhpA3FAqBP3rkNs9RFYPcFdsxDfYKDV2eJ+TpSslPz/LYQpWYAtmQXXHU+pjvocsUJ3sAPXJzzUzc01itIW3Kpk0S7G547MZPICZ2qs8Aezf4JAw5EMjWf/y67wb2ROlFpq6TKvbqUWQPGiAnAsKfB6YG0krLCpiD/f2+xWKgn2N+/R0Sy59evy7puTy3UPzsr+nkbRdntDfF0WLVk+E8Jz74QHh5jMn0Vsc2OVLo0suhcL/Chu63Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(396003)(136003)(366004)(346002)(39860400002)(451199021)(31696002)(478600001)(2906002)(54906003)(6486002)(2616005)(86362001)(36756003)(26005)(186003)(6506007)(6512007)(53546011)(8936002)(8676002)(66476007)(66556008)(66946007)(5660300002)(38100700002)(316002)(6916009)(4326008)(83380400001)(31686004)(41300700001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MklTdGsvSG1VR1p2VzhsRGVTU2szV1l0MCtMR3BSaXVPWE40QlR0NVY0MWM0?= =?utf-8?B?d01kcFErR1dVNDRaN3FwVk54bWtveGREempFNEVKSGF5UFk4NTZNZFp1ZnJE?= =?utf-8?B?YTFkb2xSeGs0OWk0TTYwbnJQbXJsNFdQRVFDd2dEbHhHOEh6bldzSHVtNjhH?= =?utf-8?B?dmcydy9JWE9tR0IrMGFlelZUVnRZRngvbmFTS2hWQ1paR0tqc0dtN01PMG5m?= =?utf-8?B?RGMzNWtRTzhTNThscEorSTRZbThIMExJQk1KSHgvRzZteWpGdWN5TlJ1NjRn?= =?utf-8?B?TURhWUttaWpkdmhIVlMrVFdZL1dyS1RQb0dNb1A4c2YvRXQ2UEhMaEtOaW9T?= =?utf-8?B?MkV3cHFVeU9xT0hoT2FxNC9IYkNwWExYeHIzeGRTTnFwMnJrYStjeEVrQmFl?= =?utf-8?B?NWhxVCtYTzFDdXZmbmdRVkl3MHdYVXpTaWl4cTZGSWE5T09XUU9HUWQ1Vkg2?= =?utf-8?B?S2ZSbXNMMy8rcEliM0VPampaV1NNOTcxYVFLQ1NORzFVaW04aWpBODNLeUZq?= =?utf-8?B?L0t4Vk5JVitJWmF3WmtyZEQrbzNCNWhENHdsaTBYWmZGTUM1dXlwa21mZ1FI?= =?utf-8?B?eXNJazFUazU1b29iQ2U2aXlONmd3MXdJeWV3NHE1Mi9rVG1VSHBiNEJsVnpK?= =?utf-8?B?eVM0Rk5CdWsxMThJM2prMW1VN0xqTUh3S2g5MTJ0VWRCZXRKV3piRXIwWllK?= =?utf-8?B?RWNVYXZ3RHNxOHlvL0RwTHl4OThDQmxKR2t0WndvTVZpL0tzNGkya2tWTWg1?= =?utf-8?B?MmVqT09BaWlEN2dTN1dUWkJUbkZyU25kY2wyd2YxczliNzBwSU51Qkd2ZWFY?= =?utf-8?B?Ynk4UHNjQlk3bWVwcUt4SXNTM1pxaEM3cGZsSDhUNHYrYnhhN212cStpWkxH?= =?utf-8?B?bXRhZWFhaXR5YzlKMTA0QVIrTnlPeU1DUldqNWhaTEZJQnVBaVVpU3NJMUoy?= =?utf-8?B?ZDhxQ1JBbmpwZEQwSVRKZWFoZkQ4Mzk5NStqVUVUbEpBcjRHblNlYjZnNzQ1?= =?utf-8?B?MjNhWFpPTGlwaFBDTzNuUldZU2diZ3kvM2ZPNVN4VjlPRlFYUTlFbGsyUjNn?= =?utf-8?B?eXI0eHB5bWYzd0JHRFE0T2hSM3VUK2RrSEpGbGxPN1ZWM3N2TkF4UG9oUXB1?= =?utf-8?B?RXVEOVE5U1MrZmx6c2l0UzgyYUJ4NHQ4RGN3NVdhZlFQdjFEQmd6QVBnMWtK?= =?utf-8?B?ZGNoQ3ExbXg5NVR0WWlSZURxakRIU1VXcWx5MFhpUGNyc0YwMTNQN3JObFNP?= =?utf-8?B?S2lVMDJNMlBVUjBRWlJiMU1Ob2EvbGd1YUlFNTFTUDBqMWZXUWk4OU45b2du?= =?utf-8?B?WlREL1Bwc3ptZ2liejNFVjZYWmRVNmJERER3Rkk1NVU1VGVDZmJRblgvbjNL?= =?utf-8?B?QWF2V1JFUlpNNjJQOWNpbFRMRklic0x6OTNZSnd0bm5wU2FibEVMNFAyMkdk?= =?utf-8?B?RVJTTmEwTktXV2ZPYWt6MnllWEJab0tMOG5lU21Jd2dvRFp2aksySE5SRVJH?= =?utf-8?B?cmVsNmVoS1BSdHQwVVdTZ2xhR2NFK21wN25ZYTdneEo3S0VDWW96bytCc3Nq?= =?utf-8?B?QzJkS3FaWHN3UmJKeWJJTDhWMmRZT1hsNTNwTzJvK0tLL1BhTHNoelFwT1dR?= =?utf-8?B?eFhjYWZRRmhDbUk0ZUtnTlBGUVhGSTBpV21qY1hIWk1FTncxd2YyVlArU08w?= =?utf-8?B?eExNK25QcjQ0aUt4K2xBcEtXNTE0VXFVTUl4TjNVbEdsSHhKTWV5NlM1eEFN?= =?utf-8?B?NDE1d0hXLytScEFDMkpLTUhRMk5LWXRUUFAycjRIMzJzMThLZ1ZvaWhvZUhS?= =?utf-8?B?cTVHajgyQXA4V2U2NGEzRkkrMU5lck5VUWtzaURtVzVBbm5ISHJGdEtydnI5?= =?utf-8?B?WTh3cDR1VVB0QzVQaEF5MUxKbzZhTE42RTFhSzA4VUVnREQrTGEyaHNrNlFj?= =?utf-8?B?MEhxZnVEYi9JbWdMSStXSytxc2g4RTREdHQzMmhoSFFNMHRBbCtxalNWT1Vx?= =?utf-8?B?VDNRSVNwWlJUMU9EV2Rib0NnWThtbzV0cHhJOUZXRm1VSlNPNTdMRkMrVnY4?= =?utf-8?B?YjQ4dTFRUjdJejd1anREbmVsakdUMlJaRkc3VTNKUlpTS25XdFJXU3hYc0FK?= =?utf-8?Q?GrzUkPpE1M7LOsdV6VGlwM3JY?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d4ff2818-d9ee-402b-8b44-08db70941a34 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jun 2023 07:09:20.1935 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ci1ldai+V9HQiAW+J3wdOlM/1F6QqbdIRjk/jpH1FpnNdTGssTbuBEubsiFA+Yqz/ZKZlTcP63UECjN2Yiatvg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7209 X-Spam-Status: No, score=-3027.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 19.06.2023 04:07, Liu, Hongtao wrote: >> -----Original Message----- >> From: Jan Beulich >> Sent: Friday, June 16, 2023 2:22 PM >> >> --- a/gcc/config/i386/sse.md >> +++ b/gcc/config/i386/sse.md >> @@ -12597,11 +12597,11 @@ >> (set_attr "mode" "")]) >> >> (define_insn "*_vternlog_all" >> - [(set (match_operand:V 0 "register_operand" "=v") >> + [(set (match_operand:V 0 "register_operand" "=v,v") >> (unspec:V >> - [(match_operand:V 1 "register_operand" "0") >> - (match_operand:V 2 "register_operand" "v") >> - (match_operand:V 3 "bcst_vector_operand" "vmBr") >> + [(match_operand:V 1 "register_operand" "0,0") >> + (match_operand:V 2 "register_operand" "v,v") >> + (match_operand:V 3 "bcst_vector_operand" "vBr,m") >> (match_operand:SI 4 "const_0_to_255_operand")] >> UNSPEC_VTERNLOG))] >> "TARGET_AVX512F > Change condition to == 64 || TARGET_AVX512VL || (TARGET_AVX512F && !TARGET_PREFER_AVX256) May I ask why you think this is necessary? The condition of the insn already wasn't in sync with the condition used in all three splitters, and I didn't see any reason why now they would need to be brought in sync. First and foremost because of the use of the UNSPEC (equally before and after this patch). Furthermore, isn't it the case that I'm already mostly expressing this with the "enabled" attribute? At the very least I think I should drop that again then if following your request? > Also please add a testcase for case TARGET_AVX512F && !TARGET_PREFER_AVX256. Especially in a case like this one I'm wondering about the usefulness of a contrived testcase: It won't test more than one minor sub-case of the whole set of constructs covered here. But well, here as well as for the other change I'll invent something. Jan