From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) by sourceware.org (Postfix) with ESMTPS id 754773858023 for ; Thu, 7 Jan 2021 21:36:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 754773858023 Received: by mail-pl1-x62d.google.com with SMTP id y8so4455684plp.8 for ; Thu, 07 Jan 2021 13:36:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=nyu71ybJBbuTLVrC7othdY/uZKziGGH8H1CSmFUETwc=; b=mBd5Mq1eIVRgIk7SPAjbpF5j6+fMVKmlXgeS2Phtk47xmYDXFOc0tcTo8RAveClJ7K mAjnYVENTG/NDQ+aM0noMs11b/jaNzo9sjbb4Z1c8YCifFpaUNFMeWlrKj5oU7UYwy7Q AIuZ6omx3RD7cVKrqxdlIm9DuoI5CIv650QyukHAMd3tsEYBqct7r+oH75qTHnwwlF4S uzQ8UFQQkaevR9MSCUt0pIFZ3qant8z9MC5GihNINcllT2mknA61Fv5nhqkJ43IQ+2Eg YFW0QkqkLuRaUCqX21/Mt8BKSsldHA2wCH9LXmf17AC/lRBD/HtnfYHzfLRMrdfPawDJ WHKA== X-Gm-Message-State: AOAM533eRZUfsaoCOirN6szOoknxPqJnIDJn8LKPyIvyZ/4RgwIyV9zc jhoHIqnrZi4dKqIWLZggTyE= X-Google-Smtp-Source: ABdhPJzrZnKfjyRH161fSO/d8Ea33PrL8HeU3yMhGH7fCT4aCg00Rci0X62c4eJvTdKX0tibKjRhRw== X-Received: by 2002:a17:90a:4142:: with SMTP id m2mr455256pjg.156.1610055379484; Thu, 07 Jan 2021 13:36:19 -0800 (PST) Received: from [192.168.0.41] (75-166-96-128.hlrn.qwest.net. [75.166.96.128]) by smtp.gmail.com with ESMTPSA id 17sm6381692pfj.91.2021.01.07.13.36.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Jan 2021 13:36:18 -0800 (PST) Subject: Re: [PATCH v3] handle MEM_REF with void* arguments (PR c++/95768) To: Jakub Jelinek Cc: gcc-patches , Jason Merrill , Richard Biener References: <29c9b3fa-69a2-dca9-1477-54aac80c8680@gmail.com> <5b4805a5-1949-267c-dc40-6f084349a68b@gmail.com> <658215da-753d-8df6-4467-b43db150e5bd@gmail.com> <887c792e-ba8e-33ee-a607-dc4fbd8a1b8e@gmail.com> <20210107082640.GJ725145@tucnak> From: Martin Sebor Message-ID: <5ab85e4b-a568-bfe4-da38-fd0b93167d29@gmail.com> Date: Thu, 7 Jan 2021 14:36:17 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20210107082640.GJ725145@tucnak> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Jan 2021 21:36:22 -0000 On 1/7/21 1:26 AM, Jakub Jelinek wrote: > On Sat, Jan 02, 2021 at 03:22:25PM -0700, Martin Sebor via Gcc-patches wrote: >> PR c++/95768 - pretty-printer ICE on -Wuninitialized with allocated storage >> >> gcc/c-family/ChangeLog: >> >> PR c++/95768 >> * c-pretty-print.c (c_pretty_printer::primary_expression): For >> SSA_NAMEs print VLA names and GIMPLE defining statements. >> (print_mem_ref): New function. >> (c_pretty_printer::unary_expression): Call it. > > This broke: > +FAIL: gcc.dg/plugin/gil-1.c -fplugin=./analyzer_gil_plugin.so (test for warnings, line 16) > +FAIL: gcc.dg/plugin/gil-1.c -fplugin=./analyzer_gil_plugin.so (test for warnings, line 63) > +FAIL: gcc.dg/plugin/gil-1.c -fplugin=./analyzer_gil_plugin.so (test for excess errors) > and > +FAIL: g++.dg/cpp0x/constexpr-trivial2.C -std=c++11 (test for errors, line 13) > +FAIL: g++.dg/cpp0x/constexpr-trivial2.C -std=c++11 (test for excess errors) > The former one is just a different printing of the MEM_REF from what the > test expects, but the latter is an ICE (one needs > make check-c++-all RUNTESTFLAGS=dg.exp=constexpr-trivial2.C > to reproduce or GXX_TESTSUITE_STDS=11 or similar as C++11 is not tested by > default). I saw the gcc.dg/plugin/gil-1.c failure but missed the subtle difference in the output. Rerunning the test didn't show any failures so I assumed it was something transient. But when I tried gain today and looked more carefully at the output I saw the test doesn't run at all by itself. This doesn't work: $ nice make -C /ssd/test/build/gcc-95768/gcc check-c RUNTESTFLAGS="plugin.exp=gil-1.c" Is there some special magic to get it to run by itself or do these tests just not do that? Running all the plugin tests does work but also shows the failures below that don't show up in the final summary (or on gcc-testresults). I assume those are unrelated (I think I've seen this test fail in a similarly mysterious way before). FAIL: gcc.dg/plugin/diagnostic-test-expressions-1.c -fplugin=./diagnostic_plugin_test_tree_expression_range.so 1 blank line(s) in output FAIL: gcc.dg/plugin/diagnostic-test-expressions-1.c -fplugin=./diagnostic_plugin_test_tree_expression_range.so expected multiline pattern lines 550-551 not found: " __builtin_types_compatible_p \(long, int\) \+ f \(i\)\);.*\n ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\^~~~~~~\n" FAIL: gcc.dg/plugin/diagnostic-test-expressions-1.c -fplugin=./diagnostic_plugin_test_tree_expression_range.so (test for excess errors) Martin PS I committed a fix for both the ICE and the gil-1.c failure in r11-6532.