From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=Zjzd=56=mentor.com=Andrew_Stubbs@sourceware.org>
Received: from esa4.mentor.iphmx.com (esa4.mentor.iphmx.com [68.232.137.252])
	by sourceware.org (Postfix) with ESMTPS id 80DF83858C52
	for <gcc-patches@gcc.gnu.org>; Thu,  2 Feb 2023 15:25:51 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 80DF83858C52
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com
X-IronPort-AV: E=Sophos;i="5.97,267,1669104000"; 
   d="scan'208";a="95588816"
Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165])
  by esa4.mentor.iphmx.com with ESMTP; 02 Feb 2023 07:25:50 -0800
IronPort-SDR: MUZiM1SpA5JrQN+NLfzoBnmEXx31+GmP8D3JtyTbLM6QqiWg9stWskK638Y//Rv8prBbpgFWfF
 mMsU11/2oKKpo98rHATLRJNeHezKTSm5bBhFOs7+M1RMZMZI2SQysVzcLLLfFLRgyDpvbe7AYu
 BfdhGS08rN3l9WIMqFuDk1QqODv0bBSUjWlkFs2IpUbzCBCj7Fnnof1UwMzpyrItV7tCVArON0
 CS/b3IzQcV3/kzxAXpu4Qg6nX9nWmp7HHBwbcPuQylFb1D6VZFjsMDDraTRZCqityBIOC/m2GN
 T5g=
Message-ID: <5acbccb0-1c33-ef78-b738-8817beb7a2f5@codesourcery.com>
Date: Thu, 2 Feb 2023 15:25:42 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [Patch] libgomp: enable reverse offload for AMDGCN
To: Tobias Burnus <tobias@codesourcery.com>, gcc-patches
	<gcc-patches@gcc.gnu.org>, Jakub Jelinek <jakub@redhat.com>
References: <aaf61c75-5fda-58ac-8921-bf27dda19c8e@codesourcery.com>
 <e83c3329-2233-0155-6e19-0e7eac8b06bc@codesourcery.com>
Content-Language: en-GB
From: Andrew Stubbs <ams@codesourcery.com>
In-Reply-To: <e83c3329-2233-0155-6e19-0e7eac8b06bc@codesourcery.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-Originating-IP: [137.202.0.90]
X-ClientProxiedBy: svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) To
 svr-ies-mbx-11.mgc.mentorg.com (139.181.222.11)
X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gcc-patches.gcc.gnu.org>

On 02/02/2023 14:59, Tobias Burnus wrote:
> Maybe it becomes better reviewable with an attached patch ...
> 
> On 02.02.23 15:31, Tobias Burnus wrote:
>> Now that the stack handling has been changed for AMDGCN, this patch
>> enables reverse offload.
>> (cf. today's "[committed] amdgcn, libgomp: Manually allocated stacks"
>> patch email/commit
>> by Andrew).
>>
>> Any comments, suggestions?

LGTM.

Andrew