From: Vladimir Makarov <vmakarov@redhat.com>
To: Tom de Vries <Tom_deVries@mentor.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: patch to fix PR82353
Date: Thu, 14 Dec 2017 17:01:00 -0000 [thread overview]
Message-ID: <5ae37149-3559-8221-fc74-68f4e90ff4de@redhat.com> (raw)
In-Reply-To: <98df25f2-0282-7eca-f6d9-c320c023ec0d@mentor.com>
On 12/13/2017 07:34 AM, Tom de Vries wrote:
> On 10/16/2017 10:38 PM, Vladimir Makarov wrote:
>> This is another version of the patch to fix
>>
>> Â Â Â https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82353
>>
>> The patch was successfully bootstrapped on x86-64 with Go and Ada.
>>
>> Committed as rev. 253796.
>
> Hi Vladimir,
>
> AFAIU this bit of the patch makes sure that the flags register show up
> in the bb_livein of the bb in which it's used (and not defined before
> the use), but not in the bb_liveout of the predecessors of that bb.
>
> I wonder if that's a compile-speed optimization, or an oversight.
>
Hi, Tom. It was just a minimal fix. I prefer minimal fixes for LRA
because even for me it is hard to predict in many cases how the patch
will affect all the targets. Therefore many LRA patches have a few
iterations before to be final.
I remember that I had some serious problems in the past when I tried to
implement fixed hard reg liveness propagation in LRA. It was long ago
so we could try it again. If you send patch you mentioned to gcc
mailing list, I'll review and approve it. But we need to be ready to
revert it if some problems occur again.
next prev parent reply other threads:[~2017-12-14 17:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-16 20:39 Vladimir Makarov
2017-12-13 12:35 ` Tom de Vries
2017-12-14 17:01 ` Vladimir Makarov [this message]
2017-12-15 11:26 ` [PATCH, PR83327] Fix liveness analysis in lra for spilled-into hard regs Tom de Vries
2017-12-18 16:57 ` Vladimir Makarov
2018-01-08 16:52 ` Tom de Vries
2018-02-26 9:32 ` Tom de Vries
2018-02-26 11:01 ` Matthew Fortune
2018-02-26 13:46 ` Tom de Vries
2018-02-26 14:17 ` Matthew Fortune
2018-02-28 22:18 ` Matthew Fortune
-- strict thread matches above, loose matches on Subject: below --
2017-10-12 11:38 patch to fix PR82353 Uros Bizjak
2017-10-11 19:51 Vladimir Makarov
2017-10-11 21:17 ` Jakub Jelinek
2017-10-11 22:54 ` Vladimir Makarov
2017-10-12 17:05 ` Jakub Jelinek
2017-10-12 17:11 ` Vladimir Makarov
2017-10-12 17:34 ` Jakub Jelinek
2017-10-13 18:49 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ae37149-3559-8221-fc74-68f4e90ff4de@redhat.com \
--to=vmakarov@redhat.com \
--cc=Tom_deVries@mentor.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).