From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd2e.google.com (mail-io1-xd2e.google.com [IPv6:2607:f8b0:4864:20::d2e]) by sourceware.org (Postfix) with ESMTPS id 108C13858D35 for ; Thu, 9 Nov 2023 17:12:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 108C13858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 108C13858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::d2e ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699549935; cv=none; b=gU9HX6kg2uxwHWVH6GA67gK4kZpByBVuzTLTkxKvFS9q/64GBVo0HKoGO7e0i7ORl85kHl0v49j+htYuWeeh3pPC9vyw9IgQiRwnHi/4h1mghEXZIvS2HVspry/yp1uFc40sBuiA9mLlFk7Ita+ALuABu487h2eIBEyhp+JIfS4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699549935; c=relaxed/simple; bh=nMcORILd9cIkFJo2YCfM/Hyc8AqfXKFfex4J+vTBobU=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=w0sDBZ2ZYgMFNRHT54tFudrpcI6DRdsAWj2/ErUEuLr7M3lKiKi6rBmI9KmKYgvgJirdB50cXzBZ4ooRlQYau8fdNe384mY8Y9prhigwg2J5Rfmx5B+6EgQZdQcSNEiTS/XlO8wddG2xYWnkVatkewtoMOluavpylITd4lKomHc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-io1-xd2e.google.com with SMTP id ca18e2360f4ac-7a956887c20so38659539f.1 for ; Thu, 09 Nov 2023 09:12:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699549930; x=1700154730; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=mjpuWkuVNwnOeYgDLSklAl1g8TZhtxrdMbnLf9RP04E=; b=PxHoz/2TMYWZpHNoi6iZJAA/Z+ev63V8RCzbNmmwYiGYA2NcHV/IOqSbBqXREo+Des rsXq9dq6P2jSCVK/bosXCHbIT9FEojtsb8hpGk4uCqscSxOrFi+Q9S7K5Wd9ShBx5/oq vBUAglmwZpsIBbAeOoBl/ZBPD3OYbLFwf5L+ZkBlaRlAHvauf91Wm7u/bRVCbEpO9i8X OWlFt/su8pFBgesCpWHnUdcFda3u0qJVbpmSd9fg6LWnyayyeI1wMweN+VxhI3f/ksyf G+SEbzWgL5Cmjiy7MG8w0oSwLI0TtreZrVoj5oPTLU7fSw7xlSEDHoKN9ngTnoqK5QnZ HZZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699549930; x=1700154730; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mjpuWkuVNwnOeYgDLSklAl1g8TZhtxrdMbnLf9RP04E=; b=VPcOKSdL/4Z9lLNPH1Lyi3R2HUHZJ3hBu1qh+fWBaNjs21QwUvuUUs1sEpxZjikJ2S 5lkaQ/zEeUqG1GIZ5geTb00Rkk28JbHkG3hgPTZkzasVOOWcwQuRCvlwLlBvclUT4tRc qAUyfXa+Dg6FILn4hkOzhDSy0eDtTmN8g9tQDFrMM5I8fHNE1bGrPbLS6lZKh5PeGT0W WyQL5Lx/ZwZG8rO2W1uliE/1Jr3Zs7zYbARQOD+cVToGh7uW06YTBHhe1Zxo1bpbH/3G BwTLWMUgMHEZucXydzS9Hhz5OyWp8bQQE7nfHemJ0QYL7otxyuT0ieseZmdNyv1nM6cS k9VA== X-Gm-Message-State: AOJu0Yx9Aw+vRAzZzgJIqIMSk2Vf8lgXJ6mQ2bf6P7qjTxcEr7Ho3KY5 G39V7bABXVEvz4ASpx0gW27/rKYPAsIYmw== X-Google-Smtp-Source: AGHT+IHqiK/R4L8oD3CCE9OpMWcz402EXJ9uKM29fgx0Wo9YhntqmSNrOzKA6JAmDoH8fsqW/BcKXA== X-Received: by 2002:a6b:d314:0:b0:7a9:b1c9:4382 with SMTP id s20-20020a6bd314000000b007a9b1c94382mr2537213iob.5.1699549930058; Thu, 09 Nov 2023 09:12:10 -0800 (PST) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id u13-20020a02cbcd000000b0045bc0378faasm4073137jaq.29.2023.11.09.09.11.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Nov 2023 09:12:02 -0800 (PST) Message-ID: <5b34db93-d653-4ad4-9839-ac7fd42836e5@gmail.com> Date: Thu, 9 Nov 2023 10:11:43 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] RISC-V: Add support for XCVelw extension in CV32E40P Content-Language: en-US To: Mary Bennett , gcc-patches@gcc.gnu.org References: <20231108110914.2710021-1-mary.bennett@embecosm.com> <20231108110914.2710021-2-mary.bennett@embecosm.com> From: Jeff Law In-Reply-To: <20231108110914.2710021-2-mary.bennett@embecosm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/8/23 04:09, Mary Bennett wrote: > +;; XCVELW builtins > +(define_insn "riscv_cv_elw_elw_si" > + [(set (match_operand:SI 0 "register_operand" "=r") > + (unspec_volatile [(mem:SI (match_operand:SI 1 "address_operand" "p"))] > + UNSPECV_CV_ELW))] > + > + "TARGET_XCVELW && !TARGET_64BIT" > + "cv.elw\t%0,%a1" > + > + [(set_attr "type" "load") > + (set_attr "mode" "SI")]) Would it make more sense to pull the MEM into the operand? So instead of "address_operand", you'd define a new operand predicate which accepted (mem (...)) and that chunk of your insn looks like (unspec_volatile [(match_operand:SI 1 "new_predicate" "")] UNSPEC_CV_ELW))] Or something close to that. From a quick look at the docs it looks like the addressing modes are similar to other extensions and could be re-used. Thoughts? jeff