From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 43A003860C36 for ; Wed, 5 May 2021 09:37:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 43A003860C36 Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 1459X4hk048720 for ; Wed, 5 May 2021 05:37:06 -0400 Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 38bqnpa2a5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 05 May 2021 05:37:06 -0400 Received: from m0098417.ppops.net (m0098417.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 1459XW3m050388 for ; Wed, 5 May 2021 05:37:06 -0400 Received: from ppma06fra.de.ibm.com (48.49.7a9f.ip4.static.sl-reverse.com [159.122.73.72]) by mx0a-001b2d01.pphosted.com with ESMTP id 38bqnpa295-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 05 May 2021 05:37:05 -0400 Received: from pps.filterd (ppma06fra.de.ibm.com [127.0.0.1]) by ppma06fra.de.ibm.com (8.16.0.43/8.16.0.43) with SMTP id 1459N84A022376; Wed, 5 May 2021 09:37:04 GMT Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by ppma06fra.de.ibm.com with ESMTP id 38bedrr3yq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 05 May 2021 09:37:03 +0000 Received: from d06av24.portsmouth.uk.ibm.com (d06av24.portsmouth.uk.ibm.com [9.149.105.60]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 1459b1cA17039618 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 5 May 2021 09:37:01 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E71D442042; Wed, 5 May 2021 09:37:00 +0000 (GMT) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B3A514203F; Wed, 5 May 2021 09:37:00 +0000 (GMT) Received: from li-23497a81-5215-11cb-9bae-a81330ecc14b.ibm.com (unknown [9.171.39.250]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP; Wed, 5 May 2021 09:37:00 +0000 (GMT) Subject: Re: [PATCH v2] IBM Z: Handle hard registers in s390_md_asm_adjust() To: Ilya Leoshkevich Cc: gcc-patches@gcc.gnu.org, Jakub Jelinek References: <20210428014834.84861-1-iii@linux.ibm.com> <828d4e77dd6bec33222cb47f5844bab761ae668b.camel@linux.ibm.com> From: Andreas Krebbel Message-ID: <5b55e0d4-539d-da0c-5e15-a9133b8c8100@linux.ibm.com> Date: Wed, 5 May 2021 11:37:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 In-Reply-To: <828d4e77dd6bec33222cb47f5844bab761ae668b.camel@linux.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: vlCR7GoB96Yr5DoaXUtg7YH7hV5UYSGe X-Proofpoint-GUID: Paax6Jpd9pgyyc-X2xAY1uc78jQ2p7s4 Content-Transfer-Encoding: 8bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761 definitions=2021-05-05_03:2021-05-05, 2021-05-05 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 bulkscore=0 mlxlogscore=999 mlxscore=0 malwarescore=0 spamscore=0 suspectscore=0 lowpriorityscore=0 priorityscore=1501 phishscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104060000 definitions=main-2105050069 X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, KAM_SHORT, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 May 2021 09:37:12 -0000 On 5/3/21 1:09 PM, Ilya Leoshkevich wrote: > On Fri, 2021-04-30 at 08:49 +0200, Andreas Krebbel wrote: >> On 4/28/21 3:48 AM, Ilya Leoshkevich wrote: >>> Bootstrapped and regtested on s390x-redhat-linux.  Tested with >>> valgrind >>> too (PR 100278 is now fixed).  Ok for master? >>> >>> v1: >>> https://gcc.gnu.org/pipermail/gcc-patches/2021-April/568771.html >>> v1 -> v2: Use the UNSPEC pattern, which is less efficient, but is >>> more >>>           on the "obviously correct" side than gen_raw_SUBREG(). >>> >>> >>> >>> gen_fprx2_to_tf() and gen_tf_to_fprx2() cannot handle hard >>> registers, >>> since the subregs they create do not pass validation.  Change >>> s390_md_asm_adjust() to manually copy between hard VRs and FPRs >>> instead >>> of using these two functions. >>> >>> gcc/ChangeLog: >>> >>>         PR target/100217 >>>         * config/s390/s390.c (s390_hard_fp_reg_p): New function. >>>         (s390_md_asm_adjust): Handle hard registers. >>> >>> gcc/testsuite/ChangeLog: >>> >>>         PR target/100217 >>>         * gcc.target/s390/vector/long-double-asm-in-out-hard-fp- >>> reg.c: New test. >>>         * gcc.target/s390/vector/long-double-asm-inout-hard-fp- >>> reg.c: New test. >> >> Ok. Thanks! >> >> Andreas > > Thanks! > > I forgot to ask: ok for gcc-11 branch? Ok for GCC 11 branch as well. Thanks! Andreas