From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-505849-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 66230 invoked by alias); 30 Jul 2019 14:51:57 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 66222 invoked by uid 89); 30 Jul 2019 14:51:57 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-4.9 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=HContent-Transfer-Encoding:8bit, super
X-HELO: mx1.suse.de
Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 30 Jul 2019 14:51:55 +0000
Received: from relay2.suse.de (unknown [195.135.220.254])	by mx1.suse.de (Postfix) with ESMTP id D0264AE60;	Tue, 30 Jul 2019 14:51:53 +0000 (UTC)
Subject: Re: [PATCH v2] Use edge->indirect_unknown_callee in cgraph_edge::make_direct (PR ipa/89330).
From: =?UTF-8?Q?Martin_Li=c5=a1ka?= <mliska@suse.cz>
To: Richard Biener <richard.guenther@gmail.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>, Andreas Schwab <schwab@suse.de>, Martin Jambor <mjambor@suse.cz>
References: <e238458c-64c5-3a56-237a-18823085aced@suse.cz> <CAFiYyc0yxm=L3wpuMfbBOBRPnJBYMJRr6Ng7zdu4-roXC1fONA@mail.gmail.com> <972e1d34-729d-23d2-09a1-cdaf758cda5c@suse.cz> <1b2b43ee-bd5f-2c2f-88ee-20fb558460f6@suse.cz>
Message-ID: <5b5a5a54-e20d-1f82-1ae9-ed7d61e8277d@suse.cz>
Date: Tue, 30 Jul 2019 14:54:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <1b2b43ee-bd5f-2c2f-88ee-20fb558460f6@suse.cz>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-IsSubscribed: yes
X-SW-Source: 2019-07/txt/msg01817.txt.bz2

On 7/30/19 3:37 PM, Martin Liška wrote:
> Hi.
> 
> Thanks to Martin I was able to prepare a proper fix. The issue is that
> cgraph_edge::resolve_speculation can delete this pointer (yes, it's
> super nasty) and so that the caller can't use this->something
> right after the function returns.
> 
> For the long term, I'll rework the ::resolve_speculation function.
> 
> The patch survives --enable-checking bootstrap on x86_64-linux-gnu.
> 
> Ready to be installed after proper testing?
> Thanks,
> Martin
> 

Honza approved me the patch offline.

Martin