public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jason Merrill <jason@redhat.com>
To: Nick Huang <nickhuang99@gmail.com>
Cc: Gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] c++: Suppress error when cv-qualified reference is introduced by typedef [PR101783]
Date: Tue, 5 Oct 2021 15:40:05 -0400	[thread overview]
Message-ID: <5b8d687e-bda5-08de-686c-a4eb7321122d@redhat.com> (raw)
In-Reply-To: <CAP6LXBuf8gg6B+ptvfUE5pKk=aV8A4wJuV9TrCnmwckJHx+FDA@mail.gmail.com>

On 10/1/21 15:52, Nick Huang wrote:
>> ...the subject line for the commit should be the first line of the
>> commit message, followed by a blank line, followed by the description of
>> the patch; without the subject line, git format-patch thought your whole
>> description was the subject of the patch.
> 
> oh,  I didn't realize this without your mentioning it. I read this guide
> (https://gcc.gnu.org/codingconventions.html#ChangeLogs) many times
> and still don't get this. I guess it was written long long ago.

FYI that's a git thing, not a ChangeLog thing.  From the git 
format-patch manual:

>        By default, the subject of a single patch is "[PATCH] " followed by the
>        concatenation of lines from the commit message up to the first blank
>        line (see the DISCUSSION section of git-commit(1)).

And from git-commit(1):

>        Though not required, it’s a good idea to begin the commit message with
>        a single short (less than 50 character) line summarizing the change,
>        followed by a blank line and then a more thorough description. The text
>        up to the first blank line in a commit message is treated as the commit
>        title, and that title is used throughout Git. For example, git-format-
>        patch(1) turns a commit into email, and it uses the title on the
>        Subject line and the rest of the commit in the body.
But yes, it would be good to give more of this instruction in the gcc 
contribute.html.

Jason


  reply	other threads:[~2021-10-05 19:40 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAP6LXBsdU3xULuu8B3cEDGbcpHUXxF4roCC-zboWmtpGoPdVvw@mail.gmail.com>
2021-09-27  1:31 ` nick huang
2021-09-28 19:51   ` Jason Merrill
2021-09-30 18:24     ` nick huang
2021-10-01 13:29       ` Jason Merrill
2021-10-01 15:10         ` Nick Huang
2021-10-01 15:45           ` Jason Merrill
2021-10-01 19:52             ` Nick Huang
2021-10-05 19:40               ` Jason Merrill [this message]
2021-08-10  5:36 [PATCH] c++: Fix unnecessary error when top-level cv-qualifiers is dropped [PR101783] nick huang
2021-08-28 11:54 ` [PATCH] c++: Suppress error when cv-qualified reference is introduced by typedef [PR101783] nick huang
2021-09-24 20:33   ` Jason Merrill

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5b8d687e-bda5-08de-686c-a4eb7321122d@redhat.com \
    --to=jason@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=nickhuang99@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).