From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 9C794385802D for ; Tue, 5 Oct 2021 19:40:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9C794385802D Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-441-K3uLwDOOMvit9KUAgVDGMQ-1; Tue, 05 Oct 2021 15:40:08 -0400 X-MC-Unique: K3uLwDOOMvit9KUAgVDGMQ-1 Received: by mail-qv1-f72.google.com with SMTP id y12-20020ad457cc000000b0038311f804f6so394358qvx.2 for ; Tue, 05 Oct 2021 12:40:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=ul9wpqS2eKqFxiDjqKd78Hno3CoycfLPAjEe6L6jEt0=; b=TEHN6Q7nRa/SN80DoK48JyrniL8adg7QZeyyjY8WEaOKVxVKGQG5FR0vHuJ64dlyBV BY5U2CAKTjglricnF0GQfxYFF1w0yNT/Gmih38BH+dJPnHdqCsqBSq4chN81xUyDaC8e FF5A8agRvWQQy5lcaGGR2snm1yOgmYSloG+P1LQpbW6PXN8HQxMFJ3OInAYV0q/C0FU6 vMeVp4+kytj48/mZ0xHhoSD4hv1ScqmZIx3VYfU0B9AD0pEu5qaUXtSpvE1p4I2ShhhV DreOZ2vmdBgRprN0MSo1wW+DIgZ4IiVWI8nIpz3GKcZtLXbNfeVx0+VLWl6gatpiBPNO toWA== X-Gm-Message-State: AOAM533OOO+/xegmu2eRYWzOETEixHMjziy5cIBixVFQlp9kdrTph0dN I2fdrSIYArgmVeGBrd2PwbD6uS/iZsNHRYruUajXOC2Wf579mMZM6aCp0RO+ZlJ6UGe9dLyvuHp 5rGRzRMTZ6lgAm0Jpyg== X-Received: by 2002:ac8:4744:: with SMTP id k4mr21321818qtp.247.1633462808213; Tue, 05 Oct 2021 12:40:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwl4auVtdoqyZGaTfr+q2kg7pKF7OWMwejkKu3ZGFk6vdatu7elXwjwiZM1deTiDf4AjErykA== X-Received: by 2002:ac8:4744:: with SMTP id k4mr21321773qtp.247.1633462807869; Tue, 05 Oct 2021 12:40:07 -0700 (PDT) Received: from [192.168.1.149] (130-44-159-43.s15913.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.159.43]) by smtp.gmail.com with ESMTPSA id m13sm326606qtq.15.2021.10.05.12.40.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Oct 2021 12:40:06 -0700 (PDT) Message-ID: <5b8d687e-bda5-08de-686c-a4eb7321122d@redhat.com> Date: Tue, 5 Oct 2021 15:40:05 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.2 Subject: Re: [PATCH] c++: Suppress error when cv-qualified reference is introduced by typedef [PR101783] To: Nick Huang Cc: Gcc-patches References: <41fa824d-59ff-07d1-50f5-2aacd88abf7e@redhat.com> <7ff72053-60e7-3c9b-3737-458ec40f1f77@redhat.com> <083cc6db-55bf-3b9c-efeb-c71ed5171c09@redhat.com> From: Jason Merrill In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_SHORT, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Oct 2021 19:40:11 -0000 On 10/1/21 15:52, Nick Huang wrote: >> ...the subject line for the commit should be the first line of the >> commit message, followed by a blank line, followed by the description of >> the patch; without the subject line, git format-patch thought your whole >> description was the subject of the patch. > > oh, I didn't realize this without your mentioning it. I read this guide > (https://gcc.gnu.org/codingconventions.html#ChangeLogs) many times > and still don't get this. I guess it was written long long ago. FYI that's a git thing, not a ChangeLog thing. From the git format-patch manual: > By default, the subject of a single patch is "[PATCH] " followed by the > concatenation of lines from the commit message up to the first blank > line (see the DISCUSSION section of git-commit(1)). And from git-commit(1): > Though not required, it’s a good idea to begin the commit message with > a single short (less than 50 character) line summarizing the change, > followed by a blank line and then a more thorough description. The text > up to the first blank line in a commit message is treated as the commit > title, and that title is used throughout Git. For example, git-format- > patch(1) turns a commit into email, and it uses the title on the > Subject line and the rest of the commit in the body. But yes, it would be good to give more of this instruction in the gcc contribute.html. Jason