From: Jeff Law <law@redhat.com>
To: Siddhesh Poyarekar <siddhesh@gotplt.org>, gcc-patches@gcc.gnu.org
Cc: hubicka@gcc.gnu.org
Subject: Re: [PATCH] [pr#83069] Keep profile_count for bb under real_bb_freq_max
Date: Tue, 05 Dec 2017 20:10:00 -0000 [thread overview]
Message-ID: <5bb6f676-ab4f-e54b-9808-69680cf36c38@redhat.com> (raw)
In-Reply-To: <92763fbb-ece2-ced8-0214-8c97f4dcc508@gotplt.org>
On 11/28/2017 04:34 AM, Siddhesh Poyarekar wrote:
> On Friday 24 November 2017 05:36 PM, Siddhesh Poyarekar wrote:
>> freq_max < 1, i.e. highest frequency among bbs in the function being
>> higher than real_bb_freq_max means that the bb ends up with a profile
>> count larger than real_bb_freq_max and then can go all the way up to
>> and beyond profile_count::max_count.
>>
>> Bootstrapped on aarch64, testsuite in progress.
>
> Tests came out clean (no new regressions) on aarch64 and x86_64. Ping?
>
> Siddhesh
>
>>
>> * gcc/predict.c (estimate_bb_frequencies): Don't reset freq_max.
>> * gcc/testsuite/gcc.dg/pr83069.c: New test case.
Just a note. Honza indicated in the associated BZ that he was going to
prepare an alternate patch to address this problem.
Jeff
prev parent reply other threads:[~2017-12-05 20:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-24 13:00 Siddhesh Poyarekar
2017-11-28 11:49 ` Siddhesh Poyarekar
2017-12-05 20:10 ` Jeff Law [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5bb6f676-ab4f-e54b-9808-69680cf36c38@redhat.com \
--to=law@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hubicka@gcc.gnu.org \
--cc=siddhesh@gotplt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).