From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 36212 invoked by alias); 5 Dec 2017 20:10:09 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 36196 invoked by uid 89); 5 Dec 2017 20:10:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=among X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 05 Dec 2017 20:10:07 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7F2C2A0B2B; Tue, 5 Dec 2017 20:10:06 +0000 (UTC) Received: from localhost.localdomain (ovpn-112-2.rdu2.redhat.com [10.10.112.2]) by smtp.corp.redhat.com (Postfix) with ESMTP id AB6D068D73; Tue, 5 Dec 2017 20:10:03 +0000 (UTC) Subject: Re: [PATCH] [pr#83069] Keep profile_count for bb under real_bb_freq_max To: Siddhesh Poyarekar , gcc-patches@gcc.gnu.org Cc: hubicka@gcc.gnu.org References: <1511525181-25726-1-git-send-email-siddhesh@gotplt.org> <92763fbb-ece2-ced8-0214-8c97f4dcc508@gotplt.org> From: Jeff Law Message-ID: <5bb6f676-ab4f-e54b-9808-69680cf36c38@redhat.com> Date: Tue, 05 Dec 2017 20:10:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <92763fbb-ece2-ced8-0214-8c97f4dcc508@gotplt.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-12/txt/msg00262.txt.bz2 On 11/28/2017 04:34 AM, Siddhesh Poyarekar wrote: > On Friday 24 November 2017 05:36 PM, Siddhesh Poyarekar wrote: >> freq_max < 1, i.e. highest frequency among bbs in the function being >> higher than real_bb_freq_max means that the bb ends up with a profile >> count larger than real_bb_freq_max and then can go all the way up to >> and beyond profile_count::max_count. >> >> Bootstrapped on aarch64, testsuite in progress. > > Tests came out clean (no new regressions) on aarch64 and x86_64. Ping? > > Siddhesh > >> >> * gcc/predict.c (estimate_bb_frequencies): Don't reset freq_max. >> * gcc/testsuite/gcc.dg/pr83069.c: New test case. Just a note. Honza indicated in the associated BZ that he was going to prepare an alternate patch to address this problem. Jeff