From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24413 invoked by alias); 24 Sep 2018 10:49:14 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 24298 invoked by uid 89); 24 Sep 2018 10:49:13 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-11.1 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3,KAM_ASCII_DIVIDERS,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=x86_64linux, x86_64-linux, nathan, Nathan X-HELO: userp2130.oracle.com Received: from userp2130.oracle.com (HELO userp2130.oracle.com) (156.151.31.86) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 24 Sep 2018 10:49:11 +0000 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w8OAiP6c113468; Mon, 24 Sep 2018 10:49:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : from : subject : message-id : date : mime-version : content-type; s=corp-2018-07-02; bh=fjxBeMJotWp+jIntIDPcT5fQ9tdjh2oj7g00/2sr8pY=; b=RAjHZysJj1BZq4geUY2R/s4LoXhy6r3MqJeEftX69asLeS4socLxRWCDChY7DnmJzxrP BCEUw9S2nlTHsbTy+lnAPIEPqv6J+gNSGw5BeHzql3eGC8G9u8RL2Dvlq9Nhll777vjM /FHDhDNRdkH3+aNKbLNmOMVpT2vkZBr8AyJNHDYeWw4zNdHz3zylyXJ1Lfw5O6t9puRZ ZgR+IHNpR4cKzRFdTb9lxKcdcLty57jkDtKR9NSDmf40j/jDJgiMNVNyindJI6OZC5dG JO+VOglG8RypOpQp33mGL1LNTaLNdDwmWGBErXUjfo6OmlLeQx9jqLh6wyRcrNZUqXnQ RQ== Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by userp2130.oracle.com with ESMTP id 2mnd5t4x5e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 24 Sep 2018 10:49:07 +0000 Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id w8OAn1ZQ003366 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 24 Sep 2018 10:49:01 GMT Received: from abhmp0003.oracle.com (abhmp0003.oracle.com [141.146.116.9]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id w8OAn0GF006323; Mon, 24 Sep 2018 10:49:00 GMT Received: from [192.168.1.4] (/79.27.215.207) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 24 Sep 2018 03:49:00 -0700 To: "gcc-patches@gcc.gnu.org" Cc: Nathan Sidwell , Jason Merrill From: Paolo Carlini Subject: [C++ Patch] PR 85070 ("[8/9 Regression] ICE on C++ code: in lazily_declare_fn, at cp/method.c:2409") Message-ID: <5bbe72a0-c9c7-4d62-c5b2-74fe5d9098f9@oracle.com> Date: Mon, 24 Sep 2018 10:58:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------034FF1CF956713A99430727B" X-IsSubscribed: yes X-SW-Source: 2018-09/txt/msg01331.txt.bz2 This is a multi-part message in MIME format. --------------034FF1CF956713A99430727B Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-length: 308 Hi, as explained in the audit trail, the gcc_assert added by Nathan triggers during error-recovery too, when add_method correctly returns false because it failed to add the method. Thus it seems that we should simply loosen a bit the assertion. Tested x86_64-linux. Thanks, Paolo. /////////////////// --------------034FF1CF956713A99430727B Content-Type: text/plain; charset=UTF-8; name="CL_85070" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="CL_85070" Content-length: 371 L2NwCjIwMTgtMDktMjQgIFBhb2xvIENhcmxpbmkgIDxwYW9sby5jYXJsaW5p QG9yYWNsZS5jb20+CgoJUFIgYysrLzg1MDcwCgkqIG1ldGhvZC5jIChsYXpp bHlfZGVjbGFyZV9mbik6IER1cmluZyBlcnJvci1yZWNvdmVyeSBhZGRfbWV0 aG9kCgltYXkgcmV0dXJuIGZhbHNlLgoKL3Rlc3RzdWl0ZQoyMDE4LTA5LTI0 ICBQYW9sbyBDYXJsaW5pICA8cGFvbG8uY2FybGluaUBvcmFjbGUuY29tPgoK CVBSIGMrKy84NTA3MAoJKiBnKysuZGcvY3BwMHgvcHI4NTA3MC5DOiBOZXcu Cg== --------------034FF1CF956713A99430727B Content-Type: text/plain; charset=UTF-8; name="patch_85070" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="patch_85070" Content-length: 1277 SW5kZXg6IGNwL21ldGhvZC5jCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IGNwL21ldGhvZC5jCShyZXZpc2lvbiAyNjQ1MjQpCisrKyBjcC9tZXRob2Qu Ywkod29ya2luZyBjb3B5KQpAQCAtMjQyMSw3ICsyNDIxLDcgQEAgbGF6aWx5 X2RlY2xhcmVfZm4gKHNwZWNpYWxfZnVuY3Rpb25fa2luZCBzZmssIHRyZWUK IAogICAvKiBBZGQgaXQgdG8gdGhlIGNsYXNzICAqLwogICBib29sIGFkZGVk ID0gYWRkX21ldGhvZCAodHlwZSwgZm4sIGZhbHNlKTsKLSAgZ2NjX2Fzc2Vy dCAoYWRkZWQpOworICBnY2NfYXNzZXJ0IChhZGRlZCB8fCBlcnJvcmNvdW50 KTsKIAogICAvKiBBZGQgaXQgdG8gVFlQRV9GSUVMRFMuICAqLwogICBpZiAo c2ZrID09IHNma19kZXN0cnVjdG9yCkluZGV4OiB0ZXN0c3VpdGUvZysrLmRn L2NwcDB4L3ByODUwNzAuQwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSB0 ZXN0c3VpdGUvZysrLmRnL2NwcDB4L3ByODUwNzAuQwkobm9uZXhpc3RlbnQp CisrKyB0ZXN0c3VpdGUvZysrLmRnL2NwcDB4L3ByODUwNzAuQwkod29ya2lu ZyBjb3B5KQpAQCAtMCwwICsxLDEzIEBACisvLyB7IGRnLWRvIGNvbXBpbGUg eyB0YXJnZXQgYysrMTEgfSB9CisKK3N0cnVjdCBBOworCitzdHJ1Y3QgQgor eworICBjb25zdGV4cHIgQSAmIG9wZXJhdG9yPSAoY29uc3QgQSAmKTsgIC8v IHsgZGctd2FybmluZyAidXNlZCIgIiIgeyB0YXJnZXQgYysrMTRfb25seSB9 IH0KK307CisKK3N0cnVjdCBBIDogQiAgLy8geyBkZy1lcnJvciAiY2Fubm90 IGJlIG92ZXJsb2FkZWQiICIiIHsgdGFyZ2V0IGMrKzE0X29ubHkgfSB9Cit7 CisgIHVzaW5nIEI6Om9wZXJhdG9yPTsKK30gYSB7IGEgPSBhIH07Cg== --------------034FF1CF956713A99430727B--