From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) by sourceware.org (Postfix) with ESMTPS id 0C94A3858D1E for ; Tue, 21 May 2024 03:54:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0C94A3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0C94A3858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::102b ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716263687; cv=none; b=DGyonr3uZfjepqDJ4brBLWwbjyvgIYhKSHQA5PLUw8t69Y7lwfmj9LXbfPP7HJ79v1MUjdTCvQY1bsi1CXWoifieYEP8Dhx59oYjiLgRXjCAzbd9TnR7lAy8fNIafKvjXSo8xhu1sSlLRsuYu+8aSWaBzggXw+iD8I7EuG+0OWk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716263687; c=relaxed/simple; bh=sV+esjMft8eJuAOUXk/CDXWM24mXP1q+0faCUaTzCJk=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=ZE98/KKyM4LiKBolUixN7gQKwh+ZuK/VtNBWPFHYcpXkDBhbHF7T8dn3JxMByfTuszwxbHu9oZCQ4bl7oWmueFSBFhEuRQ1Lcw7Is63KP7VIQChupA3Jq9H5JlWsSH/N89pIbY8Pk31PlaXOI0hk+Vl33v0FV8Bay7YvnMbt/3g= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pj1-x102b.google.com with SMTP id 98e67ed59e1d1-2bd9256ffdfso231831a91.1 for ; Mon, 20 May 2024 20:54:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716263684; x=1716868484; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=l2heYSUaqbu+F3SZ57DNT3Wrx5D20fsg4Npny3iXR3g=; b=U2IGkVwn+SCz8/6g2NVeDga0oTxIk62++M5muaqSw9TNdG2L2EUJyeVFj+v/HQtpb0 /8l+7zVbIrpdDB7y8mDIJEeKNcUtqDcQS9+F7dxU3Go80SD6UKx+CfS03IXPYhEFy/fy ALm8dPOVp94XaDMhMrBfcFRlm5zoI3KMvt52jZOs/CIWGMLZM8FS/F2MYRV1NKUmaWFt SHCrFtzDY03ItfOw/PIDoyTfT8Q8S2TmqhuNTSpvruXeIBSUCi+O+D3BBWVpoUVtk03p sFQrengco69CMD4f9jj86pr1h7eg6klyVfyjOAYKCYiCBbU6PKHHCg6rnpFd8R763IrD dIdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716263684; x=1716868484; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=l2heYSUaqbu+F3SZ57DNT3Wrx5D20fsg4Npny3iXR3g=; b=jq/JiFk+89Ejnqp42cJ+xaWVQABUkjHuQT/jsVDpLF7oGyRtHQlIyiQeNMh5kOYEfe oSFv6G93MDWE5VNMuVnyJtkcipYKvp15xm49GICBLl6A3HTkDfjFUkc/xYtQB5z8P/d4 BLJj3EBpfIVr7jSwo/CVQuMEpfFTCX2dIrn1VqILyEQveRQ6h34x5/Npi27kE2B2ycvC jTfMs+ySQZ1Ah5FjNaf/TtCdDSX+9esEJWtirIIMLQUPOsbMWtUW5EHBsxSOsNi7jRod ok3kZKkuDLgY2sSN3aEt3lXYHSIcsU77GF2YKkJsW44m5hqXxgxUMYcOKBPWknLtNinQ 4Mrw== X-Forwarded-Encrypted: i=1; AJvYcCUrZXpdqwJ5dZ2MYZdLOXveOev+xQz18rXtkzRA3Dhewf/GizTrHKTSqOYWYtjfqIVJBltRJpS/8v1O7UIRB/FLamPTNU7Ikw== X-Gm-Message-State: AOJu0Ywokk2/+JA+XPHpL7UmvlJuCjbLcQiYNb7Wp5i7SLVaLJPczuk0 9WJNTZM44zTz0aWmwcRZ9SHhiGAVW57Zp8TrwgZAoE6bDwodWJ3F X-Google-Smtp-Source: AGHT+IE6/zvzemNace5ESAi1H1yxLU5tkJEKiq7ZcR9UkWMmpzDxYFv88NEgbMjptDnrzlaWQWv5ww== X-Received: by 2002:a17:90a:4a0c:b0:2aa:8130:e3eb with SMTP id 98e67ed59e1d1-2bd603a90fbmr11683436a91.11.1716263683916; Mon, 20 May 2024 20:54:43 -0700 (PDT) Received: from [172.31.0.109] ([136.36.72.243]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-6f4d2af526csm20465525b3a.176.2024.05.20.20.54.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 May 2024 20:54:43 -0700 (PDT) Message-ID: <5c0457b2-df23-49c4-9baa-a048cd2e56a5@gmail.com> Date: Mon, 20 May 2024 21:54:41 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH v3 2/2] RISC-V: avoid LUI based const mat in alloca epilogue expansion Content-Language: en-US To: Vineet Gupta , gcc-patches@gcc.gnu.org Cc: kito.cheng@gmail.com, Palmer Dabbelt , gnu-toolchain@rivosinc.com References: <20240520233237.109269-1-vineetg@rivosinc.com> <20240520233237.109269-2-vineetg@rivosinc.com> From: Jeff Law In-Reply-To: <20240520233237.109269-2-vineetg@rivosinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 5/20/24 5:32 PM, Vineet Gupta wrote: > This is testsuite clean however there's a dwarf quirk which I want to > run by the experts. The test that was tripping CI has following > fragment: > > Before patch | After Patch > ------------------------------------------------------ > li t0,-4096 | addi sp,s0,-2048 > addi t0,t0,560 | .cfi_def_cfa 2, 2048 <- #1 > add sp,s0,t0 | addi sp,sp,-1488 > .cfi_def_cfa 2, 3536 | .cfi_def_cfa_offset 3536 <- #2 > addi sp,sp,1504 | addi sp,sp,1504 > .cfi_def_cfa_offset 2032 | .cfi_def_cfa_offset 2032 <- #3 > > The dwarf insn #1 and #3 seem ok, however #2 seems dubious to me. What about it seems dubious? We need a CFA adjustment on each insn that modifies the stack pointer so that we can unwind at any arbitrary point. The first adjustment says the prior frame is at sp + 2048. Then it's at sp + 3536. Then after the final insn the prior frame is at sp+2032. Jeff