public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: "Martin Liška" <mliska@suse.cz>
To: gcc-patches@gcc.gnu.org
Cc: Jason Merrill <jason@redhat.com>, Jakub Jelinek <jakub@redhat.com>
Subject: [RFC] Remaining references of Pascal
Date: Tue, 11 Jul 2017 14:42:00 -0000	[thread overview]
Message-ID: <5c4321de-8b19-e26d-c5c8-ed63abf010ba@suse.cz> (raw)
In-Reply-To: <b1d44588-5a54-a970-118c-292b372d5042@suse.cz>

And there are remaining references of Pascal:

1) dbxout.c:

   1661	{
   1662	  stabstr_C ('r');
   1663	  if (TREE_TYPE (type))
   1664	    dbxout_type (TREE_TYPE (type), 0);
   1665	  else if (TREE_CODE (type) != INTEGER_TYPE)
   1666	    dbxout_type (type, 0); /* E.g. Pascal's ARRAY [BOOLEAN] of INTEGER */
   1667	  else
   1668	    {

Can we remove that Jason? It's dead according to LCOV output.

2) dwarf2out.c:

  23295	
  23296	#if 0
  23297	/* Don't generate either pointer_type DIEs or reference_type DIEs here.
  23298	   Use modified_type_die instead.
  23299	   We keep this code here just in case these types of DIEs may be needed to
  23300	   represent certain things in other languages (e.g. Pascal) someday.  */
  23301	
  23302	static void
  23303	gen_pointer_type_die (tree type, dw_die_ref context_die)
  23304	{
  23305	  dw_die_ref ptr_die
--
  23312	}
  23313	
  23314	/* Don't generate either pointer_type DIEs or reference_type DIEs here.
  23315	   Use modified_type_die instead.
  23316	   We keep this code here just in case these types of DIEs may be needed to
  23317	   represent certain things in other languages (e.g. Pascal) someday.  */
  23318	
  23319	static void
  23320	gen_reference_type_die (tree type, dw_die_ref context_die)
  23321	{
  23322	  dw_die_ref ref_die, scope_die = scope_die_for (type, context_die);

The piece of code is guarded in #if 0, is it candidate for removal?

3) stor-layout.c:

   2648	/* Set the extreme values of TYPE based on its precision in bits,
   2649	   then lay it out.  Used when make_signed_type won't do
   2650	   because the tree code is not INTEGER_TYPE.
   2651	   E.g. for Pascal, when the -fsigned-char option is given.  */
   2652	
   2653	void
   2654	fixup_signed_type (tree type)
   2655	{
   2656	  int precision = TYPE_PRECISION (type);
   2657	
   2658	  set_min_and_max_values_for_integral_type (type, precision, SIGNED);
   2659	
   2660	  /* Lay out the type: set its alignment, size, etc.  */
   2661	  layout_type (type);

This is probably useful not just for Pascal?

Thanks,
Martin

  reply	other threads:[~2017-07-11 14:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-11 14:30 [PATCH] Remove Pascal language in source code Martin Liška
2017-07-11 14:42 ` Martin Liška [this message]
2017-07-11 15:57   ` [RFC] Remaining references of Pascal Jason Merrill
2017-07-13  8:10     ` [PATCH] Cleanup #2 of Pascal references Martin Liška
2017-07-13 13:37       ` Jason Merrill
2017-07-13 14:59 ` [PATCH] Remove Pascal language in source code Jeff Law
2017-07-13 16:07   ` Pedro Alves
2017-07-14  7:05     ` Martin Liška

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5c4321de-8b19-e26d-c5c8-ed63abf010ba@suse.cz \
    --to=mliska@suse.cz \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jakub@redhat.com \
    --cc=jason@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).