From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by sourceware.org (Postfix) with ESMTPS id D35673858D28 for ; Fri, 31 Mar 2023 16:20:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D35673858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pj1-x1032.google.com with SMTP id p3-20020a17090a74c300b0023f69bc7a68so23858947pjl.4 for ; Fri, 31 Mar 2023 09:20:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680279625; x=1682871625; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+8FX1n6YVyMQ5qZfWiNjJtxaAERuQ9lnDibk95p+Ogc=; b=cnHUW1B1tLfHoHB+efUdQe4CFPU1y/YisBzttVQXOnoVI1t9zbQcr2IT1M2rOZQ4v8 78pCqJ4fYkGf7wm/PSCxKhSkpb4mBUxUksgXCRgd0fKNRKIJmp9/iiGTCTzdMMTaRkdk gFKvOyesDc0Fln1WQ2bjdeyAen6DUMt1qzi4R8N+DnOQRJj4f6abwdzBno3pHgq7IWH5 JGl/ZiM8UtBMw5WFljkKNcW6SynzandbkzVXaCFlEpmbpGbIR36DSPpzCdQTtuxZQgbW CFVa4Gu2FJtiHqaeZVGIv/8K46ZGjvrNl9lX1Uh1dvf12RUMCyEh2VzmcMUevJxVkSus ybDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680279625; x=1682871625; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+8FX1n6YVyMQ5qZfWiNjJtxaAERuQ9lnDibk95p+Ogc=; b=nGS218yLlcTCBs8pqfBTqPJzS3v6ioA82Kx99g6pGdzYyefXO8LK/n5yn7Y6hZnqLf YYRPIy5QDOJ/QstzWWG1YkIQ902DfivUwpXkjo4sVBtlL36MicXWC9aooKgxG7EfKqQt sLKm7tfBVaKXj52ue82JANDanz/WXqhgx6hszBgWre4882jgC8lWYtTUW0Vlap5BkRgb AIdnK9w4/5Cm5Pl4BVFR5kIYsqMks37DE49KNjgWT7DGJWr/i+HJq3/xaXJ7Ajs5UbGj 0WLmX41aFLLco8xmRDqLIjaBADsAmTuCJPs8JltmpdrBgyI0HUDzzEPomnGJdhhysdcL 3k3Q== X-Gm-Message-State: AAQBX9dFtqDoPpPF9Y2zDymCybOPsJzpPdP8BMZv+DVJWwkWt+FpyB1E qrG5kpYBOSxxMLFhXofWEJE= X-Google-Smtp-Source: AKy350YPQR5OPxl5vE3rWfPYiEm8M14uhFdrcYSXMkF6eU0ObpMr05I16C9UZ7XBjOaG2S2LaNGvPw== X-Received: by 2002:a17:902:daca:b0:19f:3d59:e0ac with SMTP id q10-20020a170902daca00b0019f3d59e0acmr33988308plx.44.1680279625537; Fri, 31 Mar 2023 09:20:25 -0700 (PDT) Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a]) by smtp.gmail.com with ESMTPSA id g3-20020a170902934300b0019e8c3cd3f4sm1761070plp.201.2023.03.31.09.20.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 31 Mar 2023 09:20:25 -0700 (PDT) Message-ID: <5c5825b2-c4f0-8aa7-c324-8256829e52f5@gmail.com> Date: Fri, 31 Mar 2023 10:20:23 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: Regression with "recomputation and PR 109154" Content-Language: en-US To: Hans-Peter Nilsson , Andrew MacLeod Cc: jakub@redhat.com, gcc-patches@gcc.gnu.org, richard.guenther@gmail.com, aldyh@redhat.com References: <54bb3bc9-e0c1-b5ab-4447-5908b09fd19f@redhat.com> <20230331161207.DB49620444@pchp3.se.axis.com> From: Jeff Law In-Reply-To: <20230331161207.DB49620444@pchp3.se.axis.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/31/23 10:12, Hans-Peter Nilsson via Gcc-patches wrote: >> Attached. I also removed the bogus warning in Walloc-13.c that no longer >> happens > >> Add recursive GORI recompuations with a depth limit. >> >> PR tree-optimization/109154 >> gcc/ >> * gimple-range-gori.cc (gori_compute::may_recompute_p): Add depth limit. >> * gimple-range-gori.h (may_recompute_p): Add depth param. >> * params.opt (ranger-recompute-depth): New param. >> >> gcc/testsuite/ >> * gcc.dg/Walloca-13.c: Remove bogus warning that is now fixed. > > This patch, commit r13-6945-g429a7a88438cc8, caused a > test-suite regression; FAIL for 'gcc.dg/tree-ssa/pr23109.c > scan-tree-dump-not recip "reciptmp"' for cris-elf that I > logged at PR109363. > > Perhaps it's somewhat of a similar nature as Walloca-13.c > but then again it's not an bogus warning that's gone. > > Is it expected and I should just blankly xfail it or is it > worth more attention? I'm a bit surprised that it hasn't > shown up for other targets though. I already let Andrew know -- it's affecting a ton of targets. It may be the case that we just need to adjust the param for that test. jeff